From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iJaIy-0002ra-R1 for kexec@lists.infradead.org; Sun, 13 Oct 2019 09:36:51 +0000 Subject: Re: [PATCH 3/3 v3] x86/kdump: clean up all the code related to the backup region References: <20191012022140.19003-1-lijiang@redhat.com> <20191012022140.19003-4-lijiang@redhat.com> <87d0f22oi5.fsf@x220.int.ebiederm.org> <20191012121625.GA11587@dhcp-128-65.nay.redhat.com> <87zhi51ers.fsf@x220.int.ebiederm.org> From: lijiang Message-ID: <72edff0b-9778-2e83-224b-7fe70dfb8d73@redhat.com> Date: Sun, 13 Oct 2019 17:36:28 +0800 MIME-Version: 1.0 In-Reply-To: <87zhi51ers.fsf@x220.int.ebiederm.org> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: "Eric W. Biederman" , Dave Young Cc: jgross@suse.com, Thomas.Lendacky@amd.com, bhe@redhat.com, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, dhowells@redhat.com, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, tglx@linutronix.de, vgoyal@redhat.com 5ZyoIDIwMTnlubQxMOaciDEz5pelIDExOjU0LCBFcmljIFcuIEJpZWRlcm1hbiDlhpnpgZM6Cj4g RGF2ZSBZb3VuZyA8ZHlvdW5nQHJlZGhhdC5jb20+IHdyaXRlczoKPiAKPj4gSGkgRXJpYywKPj4K Pj4gT24gMTAvMTIvMTkgYXQgMDY6MjZhbSwgRXJpYyBXLiBCaWVkZXJtYW4gd3JvdGU6Cj4+PiBM aWFuYm8gSmlhbmcgPGxpamlhbmdAcmVkaGF0LmNvbT4gd3JpdGVzOgo+Pj4KPj4+PiBXaGVuIHRo ZSBjcmFzaGtlcm5lbCBrZXJuZWwgY29tbWFuZCBsaW5lIG9wdGlvbiBpcyBzcGVjaWZpZWQsIHRo ZQo+Pj4+IGxvdyAxTWlCIG1lbW9yeSB3aWxsIGFsd2F5cyBiZSByZXNlcnZlZCwgd2hpY2ggbWFr ZXMgdGhhdCB0aGUgbWVtb3J5Cj4+Pj4gYWxsb2NhdGVkIGxhdGVyIHdvbid0IGZhbGwgaW50byB0 aGUgbG93IDFNaUIgYXJlYSwgdGhlcmVieSwgaXQncyBub3QKPj4+PiBuZWNlc3NhcnkgdG8gY3Jl YXRlIGEgYmFja3VwIHJlZ2lvbiBhbmQgYWxzbyBubyBuZWVkIHRvIGNvcHkgdGhlIGZpcnN0Cj4+ Pj4gNjQwayBjb250ZW50IHRvIGEgYmFja3VwIHJlZ2lvbi4KPj4+Pgo+Pj4+IEN1cnJlbnRseSwg dGhlIGNvZGUgcmVsYXRlZCB0byB0aGUgYmFja3VwIHJlZ2lvbiBjYW4gYmUgc2FmZWx5IHJlbW92 ZWQsCj4+Pj4gc28gbGV0cyBjbGVhbiB1cC4KPj4+Pgo+Pj4+IFNpZ25lZC1vZmYtYnk6IExpYW5i byBKaWFuZyA8bGlqaWFuZ0ByZWRoYXQuY29tPgo+Pj4+IC0tLQo+Pj4KPj4+PiBkaWZmIC0tZ2l0 IGEvYXJjaC94ODYva2VybmVsL2NyYXNoLmMgYi9hcmNoL3g4Ni9rZXJuZWwvY3Jhc2guYwo+Pj4+ IGluZGV4IGViNjUxZmJkZTkyYS4uY2M1Nzc0ZmM4NGMwIDEwMDY0NAo+Pj4+IC0tLSBhL2FyY2gv eDg2L2tlcm5lbC9jcmFzaC5jCj4+Pj4gKysrIGIvYXJjaC94ODYva2VybmVsL2NyYXNoLmMKPj4+ PiBAQCAtMTczLDggKzE3Myw2IEBAIHZvaWQgbmF0aXZlX21hY2hpbmVfY3Jhc2hfc2h1dGRvd24o c3RydWN0IHB0X3JlZ3MgKnJlZ3MpCj4+Pj4gIAo+Pj4+ICAjaWZkZWYgQ09ORklHX0tFWEVDX0ZJ TEUKPj4+PiAgCj4+Pj4gLXN0YXRpYyB1bnNpZ25lZCBsb25nIGNyYXNoX3plcm9fYnl0ZXM7Cj4+ Pj4gLQo+Pj4+ICBzdGF0aWMgaW50IGdldF9ucl9yYW1fcmFuZ2VzX2NhbGxiYWNrKHN0cnVjdCBy ZXNvdXJjZSAqcmVzLCB2b2lkICphcmcpCj4+Pj4gIHsKPj4+PiAgCXVuc2lnbmVkIGludCAqbnJf cmFuZ2VzID0gYXJnOwo+Pj4+IEBAIC0yMzQsOSArMjMyLDE1IEBAIHN0YXRpYyBpbnQgcHJlcGFy ZV9lbGY2NF9yYW1faGVhZGVyc19jYWxsYmFjayhzdHJ1Y3QgcmVzb3VyY2UgKnJlcywgdm9pZCAq YXJnKQo+Pj4+ICB7Cj4+Pj4gIAlzdHJ1Y3QgY3Jhc2hfbWVtICpjbWVtID0gYXJnOwo+Pj4+ICAK Pj4+PiAtCWNtZW0tPnJhbmdlc1tjbWVtLT5ucl9yYW5nZXNdLnN0YXJ0ID0gcmVzLT5zdGFydDsK Pj4+PiAtCWNtZW0tPnJhbmdlc1tjbWVtLT5ucl9yYW5nZXNdLmVuZCA9IHJlcy0+ZW5kOwo+Pj4+ IC0JY21lbS0+bnJfcmFuZ2VzKys7Cj4+Pj4gKwlpZiAocmVzLT5zdGFydCA+PSBTWl8xTSkgewo+ Pj4+ICsJCWNtZW0tPnJhbmdlc1tjbWVtLT5ucl9yYW5nZXNdLnN0YXJ0ID0gcmVzLT5zdGFydDsK Pj4+PiArCQljbWVtLT5yYW5nZXNbY21lbS0+bnJfcmFuZ2VzXS5lbmQgPSByZXMtPmVuZDsKPj4+ PiArCQljbWVtLT5ucl9yYW5nZXMrKzsKPj4+PiArCX0gZWxzZSBpZiAocmVzLT5lbmQgPiBTWl8x TSkgewo+Pj4+ICsJCWNtZW0tPnJhbmdlc1tjbWVtLT5ucl9yYW5nZXNdLnN0YXJ0ID0gU1pfMU07 Cj4+Pj4gKwkJY21lbS0+cmFuZ2VzW2NtZW0tPm5yX3Jhbmdlc10uZW5kID0gcmVzLT5lbmQ7Cj4+ Pj4gKwkJY21lbS0+bnJfcmFuZ2VzKys7Cj4+Pj4gKwl9Cj4+Pgo+Pj4gV2hhdCBpcyBnb2luZyBv biB3aXRoIHRoaXMgY2h1bms/ICBJIGNhbiBndWVzcyBidXQgdGhpcyBuZWVkcyBhIGNsZWFyCj4+ PiBjb21tZW50Lgo+Pgo+PiBJbmRlZWQgaXQgbmVlZHMgc29tZSBjb2RlIGNvbW1lbnQsIHRoaXMg aXMgYmFzZWQgb24gc29tZSBvZmZsaW5lCj4+IGRpc2N1c3Npb24uICBjYXQgL3Byb2Mvdm1jb3Jl IHdpbGwgZ2l2ZSBhIHdhcm5pbmcgYmVjYXVzZSBpb3JlbWFwIGlzCj4+IG1hcHBpbmcgdGhlIHN5 c3RlbSByYW0uCj4+Cj4+IFdlIHBhc3MgdGhlIGZpcnN0IDFNIHRvIGtkdW1wIGtlcm5lbCBpbiBl ODIwIGFzIHN5c3RlbSByYW0gc28gdGhhdCAybmQKPj4ga2VybmVsIGNhbiB1c2UgdGhlIGxvdyAx TSBtZW1vcnkgYmVjYXVzZSBmb3IgZXhhbXBsZSB0aGUgdHJhbXBvbGluZQo+PiBjb2RlLgo+Pgo+ Pj4KPj4+PiAgCj4+Pj4gIAlyZXR1cm4gMDsKPj4+PiAgfQo+Pj4KPj4+PiBAQCAtMzU2LDkgKzMz NywxMiBAQCBpbnQgY3Jhc2hfc2V0dXBfbWVtbWFwX2VudHJpZXMoc3RydWN0IGtpbWFnZSAqaW1h Z2UsIHN0cnVjdCBib290X3BhcmFtcyAqcGFyYW1zKQo+Pj4+ICAJbWVtc2V0KCZjbWQsIDAsIHNp emVvZihzdHJ1Y3QgY3Jhc2hfbWVtbWFwX2RhdGEpKTsKPj4+PiAgCWNtZC5wYXJhbXMgPSBwYXJh bXM7Cj4+Pj4gIAo+Pj4+IC0JLyogQWRkIGZpcnN0IDY0MEsgc2VnbWVudCAqLwo+Pj4+IC0JZWku YWRkciA9IGltYWdlLT5hcmNoLmJhY2t1cF9zcmNfc3RhcnQ7Cj4+Pj4gLQllaS5zaXplID0gaW1h Z2UtPmFyY2guYmFja3VwX3NyY19zejsKPj4+PiArCS8qCj4+Pj4gKwkgKiBBZGQgdGhlIGxvdyBt ZW1vcnkgcmFuZ2VbMHgxMDAwLCBTWl8xTV0sIHNraXAKPj4+PiArCSAqIHRoZSBmaXJzdCB6ZXJv IHBhZ2UuCj4+Pj4gKwkgKi8KPj4+PiArCWVpLmFkZHIgPSBQQUdFX1NJWkU7Cj4+Pj4gKwllaS5z aXplID0gU1pfMU0gLSBQQUdFX1NJWkU7Cj4+Pj4gIAllaS50eXBlID0gRTgyMF9UWVBFX1JBTTsK Pj4+PiAgCWFkZF9lODIwX2VudHJ5KHBhcmFtcywgJmVpKTsKPj4+Cj4+PiBMaWtld2lzZSBoZXJl LiAgV2h5IGRvIHdlIG5lZWQgYSBzcGVjaWFsIGNhc2U/Cj4+PiBXaHkgdGhlIG1hZ2ljIHdpdGgg UEFHRV9TSVpFPwo+Pgo+PiBHb29kIGNhdGNoLCB0aGUgemVybyBwYWdlIHBhcnQgaXMgdXNlbGVz cywgSSB0aGluayBubyBvdGhlciBzcGVjaWFsCj4+IHJlYXNvbiwganVzdCBhc3N1bWVkIHplcm8g cGFnZSBpcyBub3QgdXNhYmxlLCBidXQgaXQgc2hvdWxkIGJlIG9rIHRvCj4+IHJlbW92ZSB0aGUg c3BlY2lhbCBoYW5kbGluZywganVzdCBwYXNzIDAgLSAxTSBpcyBnb29kIGVub3VnaC4KPiAKPiBC dXQgaWYgd2UgaGF2ZSBzdG9wcGVkIHNwZWNpYWwgY2FzaW5nIHRoZSBsb3cgMU0uICBXaHkgZG8g d2UgbmVlZCBhCj4gc3BlY2lhbCBjYXNlIGhlcmUgYXQgYWxsPwo+IApIZXJlLCBuZWVkIHRvIHBh c3MgdGhlIGxvdyBtZW1vcnkgcmFuZ2UgdG8ga2R1bXAga2VybmVsLCB3aGljaCB3aWxsIGd1YXJh bnRlZQp0aGUgYXZhaWxhYmlsaXR5IG9mIGxvdyBtZW1vcnkgaW4ga2R1bXAga2VybmVsLCBvdGhl cndpc2UsIGtkdW1wIGtlcm5lbCB3b24ndAp1c2UgdGhlIGxvdyBtZW1vcnkgcmVnaW9uLgoKPiBJ ZiB5b3UgbmVlZCB0aGUgc3BlY2lhbCBjYXNlIGl0IGlzIGFsbW9zdCBjZXJ0YWlubHkgd3Jvbmcg dG8gc2F5IHlvdQo+IGhhdmUgcmFtIGFib3ZlIDY0MEtpQiBhbmQgYmVsb3cgMU1pQi4gIFRoYXQg aXMgdGhlIGxlZ2FjeSBST00gYW5kIHZpZGVvCj4gTU1JTyBhcmVhLgo+IAo+IFRoZXJlIGlzIGEg cmVhc29uIHRoZSBvcmlnaW5hbCBjb2RlIHNhaWQgNjQwS2lCLgo+IApEbyB5b3UgbWVhbiB0aGF0 IHRoZSA2NDBrIHJlZ2lvbiBpcyBnb29kIGVub3VnaCBoZXJlIGluc3RlYWQgb2YgMU1pQj8KClRo YW5rcy4KTGlhbmJvCgo+IEVyaWMKPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmtleGVjIG1haWxpbmcgbGlzdAprZXhlY0BsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8va2V4ZWMK