Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: John Ogness <john.ogness@linutronix.de>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: parri.andrea@gmail.com, pmladek@suse.com,
	sergey.senozhatsky.work@gmail.com, paulmck@kernel.org,
	peterz@infradead.org, gregkh@linuxfoundation.org,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	rostedt@goodmis.org, swboyd@chromium.org,
	sergey.senozhatsky@gmail.com, tglx@linutronix.de,
	torvalds@linux-foundation.org
Subject: Re: [PATCH v5 4/4] printk: use the lockless ringbuffer
Date: Wed, 12 Aug 2020 18:46:22 +0206	[thread overview]
Message-ID: <871rkb4y2x.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <20200811204729.1116341-1-ndesaulniers@google.com>

On 2020-08-11, Nick Desaulniers <ndesaulniers@google.com> wrote:
> From what I can tell, I think this patch ("printk: use the lockless
> ringbuffer") breaks lx-dmesg in CONFIG_GDB_SCRIPTS.
>
> (gdb) lx-dmesg
> Python Exception <class 'gdb.error'> No symbol "log_first_idx" in specified context.: 
> Error occurred in Python: No symbol "log_first_idx" in specified context.
>
> This command is used to dump the printk log buffer.
>
> It looks like the only places left in the kernel that reference are:
>
> - Documentation/admin-guide/kdump/gdbmacros.txt
> - Documentation/admin-guide/kdump/vmcoreinfo.rst
> - scripts/gdb/linux/dmesg.py
>
> I believe this commit removed log_first_idx, so all of the above
> probably need to be fixed up, too.

Thanks for pointing this out! I will get to work on a patch for this.

John Ogness

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2020-08-12 16:40 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-09 13:23 [PATCH v5 0/4] printk: replace ringbuffer John Ogness
2020-07-09 13:23 ` [PATCH v5 1/4] crash: add VMCOREINFO macro to define offset in a struct declared by typedef John Ogness
2020-07-09 13:23 ` [PATCH v5 2/4] printk: add lockless ringbuffer John Ogness
2020-07-10  8:43   ` Sergey Senozhatsky
2020-07-10  8:47     ` Sergey Senozhatsky
2020-07-09 13:23 ` [PATCH v5 3/4] Revert "printk: lock/unlock console only for new logbuf entries" John Ogness
2020-07-09 13:23 ` [PATCH v5 4/4] printk: use the lockless ringbuffer John Ogness
2020-07-14  5:26   ` [printk] 96d5c61b1f: stress-ng.timerfd.ops_per_sec 8.3% improvement kernel test robot
2020-07-18 12:10   ` [PATCH v5 4/4] printk: use the lockless ringbuffer Marco Elver
2020-07-19  3:43     ` Sergey Senozhatsky
2020-07-20  6:43       ` Marco Elver
2020-07-20  8:22         ` Andy Shevchenko
2020-07-20  8:34         ` Sergey Senozhatsky
2020-07-20  8:41         ` Sergey Senozhatsky
2020-07-20  9:40           ` Marco Elver
2020-07-20 10:01             ` Dmitry Vyukov
2020-07-20 10:20     ` John Ogness
2020-07-20 10:32       ` Marco Elver
2020-08-11 20:47   ` Nick Desaulniers
2020-08-12 16:40     ` John Ogness [this message]
2021-01-22 23:52   ` Issue in dmesg time with lockless ring buffer J. Avila
2021-01-25 13:32     ` John Ogness
2021-01-26  0:00       ` J. Avila
2021-01-29  1:46         ` J. Avila
2020-07-10  8:28 ` [PATCH v5 0/4] printk: replace ringbuffer Petr Mladek
2020-07-13  2:23   ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rkb4y2x.fsf@jogness.linutronix.de \
    --to=john.ogness@linutronix.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=parri.andrea@gmail.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=swboyd@chromium.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox