From: Michael Ellerman <mpe@ellerman.id.au>
To: Sven Schnelle <svens@stackframe.org>,
Christophe Leroy <christophe.leroy@c-s.fr>
Cc: kexec@lists.infradead.org, deller@gmx.de, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 5/7] kexec_elf: remove elf_addr_to_cpu macro
Date: Thu, 11 Jul 2019 21:08:51 +1000 [thread overview]
Message-ID: <871rywhlq4.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20190710180518.GA6343@t470p.stackframe.org>
Sven Schnelle <svens@stackframe.org> writes:
> On Wed, Jul 10, 2019 at 05:09:29PM +0200, Christophe Leroy wrote:
>> Le 10/07/2019 à 16:29, Sven Schnelle a écrit :
>> > It had only one definition, so just use the function directly.
>>
>> It had only one definition because it was for ppc64 only.
>> But as far as I understand (at least from the name of the new file), you
>> want it to be generic, don't you ? Therefore I get on 32 bits it would be
>> elf32_to_cpu().
>
> That brings up the question whether we need those endianess conversions. I would
> assume that the ELF file has always the same endianess as the running kernel. So
> i think we could just drop them. What do you think?
We should be able to kexec from big to little endian or vice versa, so
they are necessary.
cheers
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2019-07-11 11:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 14:29 [PATCH v3 0/7] kexec: add generic support for elf kernel images Sven Schnelle
2019-07-10 14:29 ` [PATCH v3 1/7] kexec: add KEXEC_ELF Sven Schnelle
2019-07-10 14:29 ` [PATCH v3 2/7] kexec_elf: change order of elf_*_to_cpu() functions Sven Schnelle
2019-07-10 14:29 ` [PATCH v3 3/7] kexec_elf: remove parsing of section headers Sven Schnelle
2019-07-10 14:29 ` [PATCH v3 4/7] kexec_elf: remove PURGATORY_STACK_SIZE Sven Schnelle
2019-07-10 14:29 ` [PATCH v3 5/7] kexec_elf: remove elf_addr_to_cpu macro Sven Schnelle
2019-07-10 15:09 ` Christophe Leroy
2019-07-10 18:05 ` Sven Schnelle
2019-07-11 11:08 ` Michael Ellerman [this message]
2019-07-15 7:24 ` Sven Schnelle
2019-07-19 14:06 ` Michael Ellerman
2019-07-10 14:29 ` [PATCH v3 6/7] kexec_elf: remove Elf_Rel macro Sven Schnelle
2019-07-10 15:02 ` Christophe Leroy
2019-07-10 14:29 ` [PATCH v3 7/7] kexec_elf: remove unused variable in kexec_elf_load() Sven Schnelle
2019-07-10 14:55 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rywhlq4.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=christophe.leroy@c-s.fr \
--cc=deller@gmx.de \
--cc=kexec@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox