From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from out02.mta.xmission.com ([166.70.13.232]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKKec-0004cb-1H for kexec@lists.infradead.org; Tue, 15 Oct 2019 11:06:15 +0000 From: ebiederm@xmission.com (Eric W. Biederman) References: <20191012022140.19003-1-lijiang@redhat.com> <20191012022140.19003-4-lijiang@redhat.com> <87d0f22oi5.fsf@x220.int.ebiederm.org> <20191012121625.GA11587@dhcp-128-65.nay.redhat.com> <87zhi51ers.fsf@x220.int.ebiederm.org> <72edff0b-9778-2e83-224b-7fe70dfb8d73@redhat.com> Date: Tue, 15 Oct 2019 06:04:27 -0500 In-Reply-To: <72edff0b-9778-2e83-224b-7fe70dfb8d73@redhat.com> (lijiang's message of "Sun, 13 Oct 2019 17:36:28 +0800") Message-ID: <8736fu1d8k.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Subject: Re: [PATCH 3/3 v3] x86/kdump: clean up all the code related to the backup region List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: lijiang Cc: jgross@suse.com, Thomas.Lendacky@amd.com, bhe@redhat.com, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, dhowells@redhat.com, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, tglx@linutronix.de, Dave Young , vgoyal@redhat.com bGlqaWFuZyA8bGlqaWFuZ0ByZWRoYXQuY29tPiB3cml0ZXM6Cgo+IOWcqCAyMDE55bm0MTDmnIgx M+aXpSAxMTo1NCwgRXJpYyBXLiBCaWVkZXJtYW4g5YaZ6YGTOgo+PiBEYXZlIFlvdW5nIDxkeW91 bmdAcmVkaGF0LmNvbT4gd3JpdGVzOgo+PiAKPj4+IEhpIEVyaWMsCj4+Pgo+Pj4gT24gMTAvMTIv MTkgYXQgMDY6MjZhbSwgRXJpYyBXLiBCaWVkZXJtYW4gd3JvdGU6Cj4+Pj4gTGlhbmJvIEppYW5n IDxsaWppYW5nQHJlZGhhdC5jb20+IHdyaXRlczoKPj4+Pgo+Pj4+PiBXaGVuIHRoZSBjcmFzaGtl cm5lbCBrZXJuZWwgY29tbWFuZCBsaW5lIG9wdGlvbiBpcyBzcGVjaWZpZWQsIHRoZQo+Pj4+PiBs b3cgMU1pQiBtZW1vcnkgd2lsbCBhbHdheXMgYmUgcmVzZXJ2ZWQsIHdoaWNoIG1ha2VzIHRoYXQg dGhlIG1lbW9yeQo+Pj4+PiBhbGxvY2F0ZWQgbGF0ZXIgd29uJ3QgZmFsbCBpbnRvIHRoZSBsb3cg MU1pQiBhcmVhLCB0aGVyZWJ5LCBpdCdzIG5vdAo+Pj4+PiBuZWNlc3NhcnkgdG8gY3JlYXRlIGEg YmFja3VwIHJlZ2lvbiBhbmQgYWxzbyBubyBuZWVkIHRvIGNvcHkgdGhlIGZpcnN0Cj4+Pj4+IDY0 MGsgY29udGVudCB0byBhIGJhY2t1cCByZWdpb24uCj4+Pj4+Cj4+Pj4+IEN1cnJlbnRseSwgdGhl IGNvZGUgcmVsYXRlZCB0byB0aGUgYmFja3VwIHJlZ2lvbiBjYW4gYmUgc2FmZWx5IHJlbW92ZWQs Cj4+Pj4+IHNvIGxldHMgY2xlYW4gdXAuCj4+Pj4+Cj4+Pj4+IFNpZ25lZC1vZmYtYnk6IExpYW5i byBKaWFuZyA8bGlqaWFuZ0ByZWRoYXQuY29tPgo+Pj4+PiAtLS0KPj4+Pgo+Pj4+PiBkaWZmIC0t Z2l0IGEvYXJjaC94ODYva2VybmVsL2NyYXNoLmMgYi9hcmNoL3g4Ni9rZXJuZWwvY3Jhc2guYwo+ Pj4+PiBpbmRleCBlYjY1MWZiZGU5MmEuLmNjNTc3NGZjODRjMCAxMDA2NDQKPj4+Pj4gLS0tIGEv YXJjaC94ODYva2VybmVsL2NyYXNoLmMKPj4+Pj4gKysrIGIvYXJjaC94ODYva2VybmVsL2NyYXNo LmMKPj4+Pj4gQEAgLTE3Myw4ICsxNzMsNiBAQCB2b2lkIG5hdGl2ZV9tYWNoaW5lX2NyYXNoX3No dXRkb3duKHN0cnVjdCBwdF9yZWdzICpyZWdzKQo+Pj4+PiAgCj4+Pj4+ICAjaWZkZWYgQ09ORklH X0tFWEVDX0ZJTEUKPj4+Pj4gIAo+Pj4+PiAtc3RhdGljIHVuc2lnbmVkIGxvbmcgY3Jhc2hfemVy b19ieXRlczsKPj4+Pj4gLQo+Pj4+PiAgc3RhdGljIGludCBnZXRfbnJfcmFtX3Jhbmdlc19jYWxs YmFjayhzdHJ1Y3QgcmVzb3VyY2UgKnJlcywgdm9pZCAqYXJnKQo+Pj4+PiAgewo+Pj4+PiAgCXVu c2lnbmVkIGludCAqbnJfcmFuZ2VzID0gYXJnOwo+Pj4+PiBAQCAtMjM0LDkgKzIzMiwxNSBAQCBz dGF0aWMgaW50IHByZXBhcmVfZWxmNjRfcmFtX2hlYWRlcnNfY2FsbGJhY2soc3RydWN0IHJlc291 cmNlICpyZXMsIHZvaWQgKmFyZykKPj4+Pj4gIHsKPj4+Pj4gIAlzdHJ1Y3QgY3Jhc2hfbWVtICpj bWVtID0gYXJnOwo+Pj4+PiAgCj4+Pj4+IC0JY21lbS0+cmFuZ2VzW2NtZW0tPm5yX3Jhbmdlc10u c3RhcnQgPSByZXMtPnN0YXJ0Owo+Pj4+PiAtCWNtZW0tPnJhbmdlc1tjbWVtLT5ucl9yYW5nZXNd LmVuZCA9IHJlcy0+ZW5kOwo+Pj4+PiAtCWNtZW0tPm5yX3JhbmdlcysrOwo+Pj4+PiArCWlmIChy ZXMtPnN0YXJ0ID49IFNaXzFNKSB7Cj4+Pj4+ICsJCWNtZW0tPnJhbmdlc1tjbWVtLT5ucl9yYW5n ZXNdLnN0YXJ0ID0gcmVzLT5zdGFydDsKPj4+Pj4gKwkJY21lbS0+cmFuZ2VzW2NtZW0tPm5yX3Jh bmdlc10uZW5kID0gcmVzLT5lbmQ7Cj4+Pj4+ICsJCWNtZW0tPm5yX3JhbmdlcysrOwo+Pj4+PiAr CX0gZWxzZSBpZiAocmVzLT5lbmQgPiBTWl8xTSkgewo+Pj4+PiArCQljbWVtLT5yYW5nZXNbY21l bS0+bnJfcmFuZ2VzXS5zdGFydCA9IFNaXzFNOwo+Pj4+PiArCQljbWVtLT5yYW5nZXNbY21lbS0+ bnJfcmFuZ2VzXS5lbmQgPSByZXMtPmVuZDsKPj4+Pj4gKwkJY21lbS0+bnJfcmFuZ2VzKys7Cj4+ Pj4+ICsJfQo+Pj4+Cj4+Pj4gV2hhdCBpcyBnb2luZyBvbiB3aXRoIHRoaXMgY2h1bms/ICBJIGNh biBndWVzcyBidXQgdGhpcyBuZWVkcyBhIGNsZWFyCj4+Pj4gY29tbWVudC4KPj4+Cj4+PiBJbmRl ZWQgaXQgbmVlZHMgc29tZSBjb2RlIGNvbW1lbnQsIHRoaXMgaXMgYmFzZWQgb24gc29tZSBvZmZs aW5lCj4+PiBkaXNjdXNzaW9uLiAgY2F0IC9wcm9jL3ZtY29yZSB3aWxsIGdpdmUgYSB3YXJuaW5n IGJlY2F1c2UgaW9yZW1hcCBpcwo+Pj4gbWFwcGluZyB0aGUgc3lzdGVtIHJhbS4KPj4+Cj4+PiBX ZSBwYXNzIHRoZSBmaXJzdCAxTSB0byBrZHVtcCBrZXJuZWwgaW4gZTgyMCBhcyBzeXN0ZW0gcmFt IHNvIHRoYXQgMm5kCj4+PiBrZXJuZWwgY2FuIHVzZSB0aGUgbG93IDFNIG1lbW9yeSBiZWNhdXNl IGZvciBleGFtcGxlIHRoZSB0cmFtcG9saW5lCj4+PiBjb2RlLgo+Pj4KPj4+Pgo+Pj4+PiAgCj4+ Pj4+ICAJcmV0dXJuIDA7Cj4+Pj4+ICB9Cj4+Pj4KPj4+Pj4gQEAgLTM1Niw5ICszMzcsMTIgQEAg aW50IGNyYXNoX3NldHVwX21lbW1hcF9lbnRyaWVzKHN0cnVjdCBraW1hZ2UgKmltYWdlLCBzdHJ1 Y3QgYm9vdF9wYXJhbXMgKnBhcmFtcykKPj4+Pj4gIAltZW1zZXQoJmNtZCwgMCwgc2l6ZW9mKHN0 cnVjdCBjcmFzaF9tZW1tYXBfZGF0YSkpOwo+Pj4+PiAgCWNtZC5wYXJhbXMgPSBwYXJhbXM7Cj4+ Pj4+ICAKPj4+Pj4gLQkvKiBBZGQgZmlyc3QgNjQwSyBzZWdtZW50ICovCj4+Pj4+IC0JZWkuYWRk ciA9IGltYWdlLT5hcmNoLmJhY2t1cF9zcmNfc3RhcnQ7Cj4+Pj4+IC0JZWkuc2l6ZSA9IGltYWdl LT5hcmNoLmJhY2t1cF9zcmNfc3o7Cj4+Pj4+ICsJLyoKPj4+Pj4gKwkgKiBBZGQgdGhlIGxvdyBt ZW1vcnkgcmFuZ2VbMHgxMDAwLCBTWl8xTV0sIHNraXAKPj4+Pj4gKwkgKiB0aGUgZmlyc3QgemVy byBwYWdlLgo+Pj4+PiArCSAqLwo+Pj4+PiArCWVpLmFkZHIgPSBQQUdFX1NJWkU7Cj4+Pj4+ICsJ ZWkuc2l6ZSA9IFNaXzFNIC0gUEFHRV9TSVpFOwo+Pj4+PiAgCWVpLnR5cGUgPSBFODIwX1RZUEVf UkFNOwo+Pj4+PiAgCWFkZF9lODIwX2VudHJ5KHBhcmFtcywgJmVpKTsKPj4+Pgo+Pj4+IExpa2V3 aXNlIGhlcmUuICBXaHkgZG8gd2UgbmVlZCBhIHNwZWNpYWwgY2FzZT8KPj4+PiBXaHkgdGhlIG1h Z2ljIHdpdGggUEFHRV9TSVpFPwo+Pj4KPj4+IEdvb2QgY2F0Y2gsIHRoZSB6ZXJvIHBhZ2UgcGFy dCBpcyB1c2VsZXNzLCBJIHRoaW5rIG5vIG90aGVyIHNwZWNpYWwKPj4+IHJlYXNvbiwganVzdCBh c3N1bWVkIHplcm8gcGFnZSBpcyBub3QgdXNhYmxlLCBidXQgaXQgc2hvdWxkIGJlIG9rIHRvCj4+ PiByZW1vdmUgdGhlIHNwZWNpYWwgaGFuZGxpbmcsIGp1c3QgcGFzcyAwIC0gMU0gaXMgZ29vZCBl bm91Z2guCj4+IAo+PiBCdXQgaWYgd2UgaGF2ZSBzdG9wcGVkIHNwZWNpYWwgY2FzaW5nIHRoZSBs b3cgMU0uICBXaHkgZG8gd2UgbmVlZCBhCj4+IHNwZWNpYWwgY2FzZSBoZXJlIGF0IGFsbD8KPj4g Cj4gSGVyZSwgbmVlZCB0byBwYXNzIHRoZSBsb3cgbWVtb3J5IHJhbmdlIHRvIGtkdW1wIGtlcm5l bCwgd2hpY2ggd2lsbCBndWFyYW50ZWUKPiB0aGUgYXZhaWxhYmlsaXR5IG9mIGxvdyBtZW1vcnkg aW4ga2R1bXAga2VybmVsLCBvdGhlcndpc2UsIGtkdW1wIGtlcm5lbCB3b24ndAo+IHVzZSB0aGUg bG93IG1lbW9yeSByZWdpb24uCj4KPj4gSWYgeW91IG5lZWQgdGhlIHNwZWNpYWwgY2FzZSBpdCBp cyBhbG1vc3QgY2VydGFpbmx5IHdyb25nIHRvIHNheSB5b3UKPj4gaGF2ZSByYW0gYWJvdmUgNjQw S2lCIGFuZCBiZWxvdyAxTWlCLiAgVGhhdCBpcyB0aGUgbGVnYWN5IFJPTSBhbmQgdmlkZW8KPj4g TU1JTyBhcmVhLgo+PiAKPj4gVGhlcmUgaXMgYSByZWFzb24gdGhlIG9yaWdpbmFsIGNvZGUgc2Fp ZCA2NDBLaUIuCj4+IAo+IERvIHlvdSBtZWFuIHRoYXQgdGhlIDY0MGsgcmVnaW9uIGlzIGdvb2Qg ZW5vdWdoIGhlcmUgaW5zdGVhZCBvZiAxTWlCPwoKUmVhZGluZyB0aHJvdWdoIHRoZSBjb2RlIG9m IGNyYXNoX3NldHVwX21lbWFwX2VudHJpZXMgSSBzZWUgdGhhdCB3aGF0CnRoZSBjb2RlIGlzIGRv aW5nIG5vdy4gIFRoZSBjb2RlIGlzIHJlcGVhdGluZyB0aGUgZTgyMCBtZW1vcnkgbWFwIHdpdGgK dGhlIG1lbW9yeSBhcmVhcyB0aGF0IHdlcmUgbm90IHJlc2VydmVkIGZvciB0aGUgY3Jhc2gga2Vy bmVsIHJlbW92ZWQuCgpJbiB3aGljaCBjYXNlIHdoYXQgdGhlIGNvZGUgbmVlZHMgdG8gYmUgZG9p bmcgc29tZXRoaW5nIGxpa2U6CgoJY21kLnR5cGUgPSBFODIwX1RZUEVfUkFNOwoJZmxhZ3MgPSBJ T1JFU09VUkNFX01FTTsKCXdhbGtfaW9tZW1fcmVzX2Rlc2MoSU9SRVNfREVTQ19SRVNFUlZFRCwg ZmxhZ3MsIDAsIDEwMjQqMTAyNCwgJmNtZCwKCQkJICAgICAgIG1lbW1hcF9lbnRyeV9jYWxsYmFj ayk7CgpEZXBlbmRpbmcgb24gd2hpY2ggYnVncyBleGlzdCBpdCBtaWdodCBtYWtlIHNlbnNlIHRv IGxpbWl0IHRoaXMgdG8KdGhlIGxvdyA2NDBLaUIuICBCdXQgZmluZGluZyBzb21ldGhpbmcgdGhl IGtlcm5lbCBhbHJlYWR5IHJlY29nbml6ZXMKYXMgUkFNIHNob3VsZCBwcmV2ZW50IG1vc3Qgb2Yg dGhvc2UgcHJvYmxlbXMgYWxyZWFkeS4gIEJhcnJpbmcgYnVncwpJIGFkbWl0IGl0IGRvZXNuJ3Qg bWFrZSBzZW5zZSB0byByZXBlYXQgdGhlIHdvcmsgdGhhdCBzb21lb25lIGVsc2UKaGFzIGFscmVh ZHkgZG9uZS4KClRoaXMgYml0OgoJLyogQWRkIGU4MjAgcmVzZXJ2ZWQgcmFuZ2VzICovCgljbWQu dHlwZSA9IEU4MjBfVFlQRV9SRVNFUlZFRDsKCWZsYWdzID0gSU9SRVNPVVJDRV9NRU07Cgl3YWxr X2lvbWVtX3Jlc19kZXNjKElPUkVTX0RFU0NfUkVTRVJWRUQsIGZsYWdzLCAwLCAtMSwgJmNtZCwK CQkJICAgbWVtbWFwX2VudHJ5X2NhbGxiYWNrKTsKClNob3VsZCBwcm9iYWJseSBzdGFydCBhdCAx TWlCIGluc3RlYWQgb2YgMC4gIEp1c3Qgc28gd2UgZG9uJ3QgcmVwb3J0IHRoZQptZW1vcnkgYmVs b3cgMU1pQiBhcyB1bmNvbmRpdGlvbmFsbHkgcmVzZXJ2ZWQuICAgSSBkb24ndCBwcm9wZXJseQp1 bmRlcnN0YW5kIHRoZSBJT1JFU19ERVNDX1JFU0VSVkVEIGZsYWcsIGFuZCBob3cgdGhhdCBkaWZm ZXJzIGZyb20KZmxhZ3MuICBTbyBwbGVhc2UgdGVzdCBteSBzdWdnZXN0aW9ucyB0byB2ZXJpZnkg dGhlIGNvZGUgd29ya3MgYXMKZXhwZWN0ZWQuCgpFcmljCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwprZXhlYyBtYWlsaW5nIGxpc3QKa2V4ZWNAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2tleGVjCg==