public inbox for kexec@lists.infradead.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Yinghai Lu <yinghai@kernel.org>
Cc: Simon Horman <horms@verge.net.au>,
	Kexec Mailing List <kexec@lists.infradead.org>
Subject: [PATCH] kexec: Teach configure to find the strip binary.
Date: Mon, 03 Dec 2012 14:25:25 -0800	[thread overview]
Message-ID: <8738zm93je.fsf_-_@xmission.com> (raw)
In-Reply-To: <CAE9FiQWvNYOfg1=uYYzdfoy5q6RnroNCVyqXRw2ffgLQp_UvFw@mail.gmail.com> (Yinghai Lu's message of "Mon, 3 Dec 2012 12:34:04 -0800")


For some reason my version of the Makefile generated by configure
included the line STRIP=strp.  Rerunning configure from a fresh slate
did not regenerate that line so I don't know how it got there.  So add
the code to Makefile.in and configure.ac to autodetect the strip binary.

This is needed so that we can remove from purgatory all of the
relocations to sections that are not needed at runtime, by stripping
out those sections.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
---
 Makefile.in                    |    1 +
 configure.ac                   |    2 ++
 purgatory/arch/x86_64/Makefile |    2 +-
 3 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/Makefile.in b/Makefile.in
index ba2e638..7a50200 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -64,6 +64,7 @@ SED		= @SED@
 FIND		= @FIND@
 XARGS		= @XARGS@
 DIRNAME		= @DIRNAME@
+STRIP		= @STRIP@
 
 
 pkgdatadir = $(datadir)/$(PACKAGE_NAME)
diff --git a/configure.ac b/configure.ac
index 401b11e..b7e4f2e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -142,6 +142,7 @@ AC_CHECK_PROG([SED],      sed,      sed,      "no", [$PATH])
 AC_CHECK_PROG([FIND],     find,     find,     "no", [$PATH])
 AC_CHECK_PROG([XARGS],    xargs,    xargs,    "no", [$PATH])
 AC_CHECK_PROG([DIRNAME],  dirname,  dirname,  "no", [$PATH])
+AC_CHECK_PROG([STRIP],    strip,    strip,    "no", [$PATH])
 
 dnl See if I have a usable copy of zlib available
 if test "$with_zlib" = yes ; then
@@ -185,6 +186,7 @@ if test "$SED"     = "no"; then AC_MSG_ERROR([ sed not found]); fi
 if test "$FIND"    = "no"; then AC_MSG_ERROR([ find not found]); fi
 if test "$XARGS"   = "no"; then AC_MSG_ERROR([ xargs not found]); fi
 if test "$DIRNAME" = "no"; then AC_MSG_ERROR([ dirname not found]); fi
+if test "$STRIP"   = "no"; then AC_MSG_ERROR([ strip not found]); fi
 
 dnl ---Output variables...
 AC_SUBST([BUILD_CC])
diff --git a/purgatory/arch/x86_64/Makefile b/purgatory/arch/x86_64/Makefile
index 7300937..bfc7b24 100644
--- a/purgatory/arch/x86_64/Makefile
+++ b/purgatory/arch/x86_64/Makefile
@@ -16,7 +16,7 @@ dist += purgatory/arch/x86_64/Makefile $(x86_64_PURGATORY_SRCS_native) 	\
 	purgatory/arch/x86_64/purgatory-x86_64.h
 
 # Don't add sources in i386/ to dist, as i386/Makefile adds them
-x86_64_PURGATORY_SRCS += purgatory/arch/i386/entry32-16.S
+x86_64_PURGATORY_SRCS +=  purgatory/arch/i386/entry32-16.S
 x86_64_PURGATORY_SRCS += purgatory/arch/i386/entry32-16-debug.S
 x86_64_PURGATORY_SRCS += purgatory/arch/i386/crashdump_backup.c
 x86_64_PURGATORY_SRCS += purgatory/arch/i386/console-x86.c
-- 
1.7.5.4

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2012-12-03 22:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19 16:56 [PATCH] kexec x86_64: Make purgatory relocatable anywhere in the 64bit address space Eric W. Biederman
2012-11-21  0:16 ` Simon Horman
2012-12-03 20:34 ` Yinghai Lu
2012-12-03 22:25   ` Eric W. Biederman [this message]
2012-12-04  0:09     ` [PATCH] kexec: Teach configure to find the strip binary Simon Horman
2012-12-04  1:11       ` Eric W. Biederman
2012-12-04  1:18         ` Yinghai Lu
2012-12-04  1:26           ` Eric W. Biederman
2012-12-04  1:29             ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8738zm93je.fsf_-_@xmission.com \
    --to=ebiederm@xmission.com \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox