From: John Ogness <john.ogness@linutronix.de>
To: "HAGIO KAZUHITO(萩尾 一仁)" <k-hagio-ab@nec.com>
Cc: "kexec@lists.infradead.org" <kexec@lists.infradead.org>,
Dave Anderson <anderson@redhat.com>,
"Discussion list for crash utility usage,
maintenance and development" <crash-utility@redhat.com>
Subject: Re: [Crash-utility] new printk ringbuffer interface
Date: Fri, 24 Apr 2020 14:53:49 +0200 [thread overview]
Message-ID: <875zdp59k2.fsf@vostro.fn.ogness.net> (raw)
In-Reply-To: <OSBPR01MB1991F08228D7E9BDBEF07105DDD30@OSBPR01MB1991.jpnprd01.prod.outlook.com> ("HAGIO \=\?utf-8\?B\?S0FaVUhJVE8o6JCp5bC+44CA5LiA5LuBKSIncw\=\=\?\= message of "Thu, 23 Apr 2020 19:21:14 +0000")
On 2020-04-23, HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab@nec.com> wrote:
>> Should all struct sizes and field offsets be exported? It
>> would look something like this:
>>
>> VMCOREINFO_SYMBOL(prb);
>>
>> VMCOREINFO_STRUCT_SIZE(printk_ringbuffer);
>> VMCOREINFO_OFFSET(printk_ringbuffer, desc_ring);
>> VMCOREINFO_OFFSET(printk_ringbuffer, text_data_ring);
>> VMCOREINFO_OFFSET(printk_ringbuffer, dict_data_ring);
>> VMCOREINFO_OFFSET(printk_ringbuffer, fail);
>>
>> VMCOREINFO_STRUCT_SIZE(prb_desc_ring);
>> VMCOREINFO_OFFSET(prb_desc_ring, count_bits);
>> VMCOREINFO_OFFSET(prb_desc_ring, descs);
>> VMCOREINFO_OFFSET(prb_desc_ring, head_id);
>> VMCOREINFO_OFFSET(prb_desc_ring, tail_id);
>>
>> VMCOREINFO_STRUCT_SIZE(prb_desc);
>> VMCOREINFO_OFFSET(prb_desc, info);
>> VMCOREINFO_OFFSET(prb_desc, state_var);
>> VMCOREINFO_OFFSET(prb_desc, text_blk_lpos);
>> VMCOREINFO_OFFSET(prb_desc, dict_blk_lpos);
>>
>> VMCOREINFO_STRUCT_SIZE(prb_data_blk_lpos);
>> VMCOREINFO_OFFSET(prb_data_blk_lpos, begin);
>> VMCOREINFO_OFFSET(prb_data_blk_lpos, next);
>>
>> VMCOREINFO_STRUCT_SIZE(printk_info);
>> VMCOREINFO_OFFSET(printk_info, seq);
>> VMCOREINFO_OFFSET(printk_info, ts_nsec);
>> VMCOREINFO_OFFSET(printk_info, text_len);
>> VMCOREINFO_OFFSET(printk_info, dict_len);
>> VMCOREINFO_OFFSET(printk_info, caller_id);
>>
>> VMCOREINFO_STRUCT_SIZE(prb_data_ring);
>> VMCOREINFO_OFFSET(prb_data_ring, size_bits);
>> VMCOREINFO_OFFSET(prb_data_ring, data);
>> VMCOREINFO_OFFSET(prb_data_ring, head_id);
>> VMCOREINFO_OFFSET(prb_data_ring, tail_id);
>
> If there is no efficient way, we will need all of the entries in
> VMCOREINFO.
It seems like a lot to export everything, but I don't have a problem
with it. If we decide to export everything (which I expect we will need
to do), then I would change my crash(8) implementation to also rely only
on the VMCOREINFO. I see no point in having some implementations using
debug data and other implementations using VMCOREINFO data, if
VMCOREINFO has everything that is needed.
John Ogness
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2020-04-24 12:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 14:23 [Crash-utility] new printk ringbuffer interface HAGIO KAZUHITO(萩尾 一仁)
2020-04-23 14:43 ` Dave Anderson
2020-04-23 15:23 ` HAGIO KAZUHITO(萩尾 一仁)
2020-04-23 19:21 ` HAGIO KAZUHITO(萩尾 一仁)
2020-04-24 12:53 ` John Ogness [this message]
2020-04-24 13:16 ` Dave Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zdp59k2.fsf@vostro.fn.ogness.net \
--to=john.ogness@linutronix.de \
--cc=anderson@redhat.com \
--cc=crash-utility@redhat.com \
--cc=k-hagio-ab@nec.com \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox