Re: [PATCH v8 1/2] x86/kexec: add a new atomic notifier list for kdump

Eric W. Biederman
2012-11-27T01:49:53Z

Zhang Yanfei <zhangyanfei@cn.fujitsu.com> writes:

> So in summary,
>
> 1. a specific callback function instead of a notifier?

Yes.

> 2. Instead of calling vmclear_local_loaded_vmcss, the vmclear operation
> will just call the vmclear on every vmcss loaded on the cpu?
>
> like below:
>
> static void crash_vmclear_local_loaded_vmcss(void)
> {
> int cpu = raw_smp_processor_id();
> struct loaded_vmcs *v, *n;
>
> if (!crash_local_vmclear_enabled(cpu))
> return;
>
> list_for_each_entry_safe(v, n, &per_cpu(loaded_vmcss_on_cpu, cpu),
> loaded_vmcss_on_cpu_link)
> vmcs_clear(v->vmcs);
> }
>
> right?

Yeah that looks good. I would do list_for_each_entry because the list
isn't changing.

Eric