public inbox for kexec@lists.infradead.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Yinghai Lu <yinghai@kernel.org>
Cc: Simon Horman <horms@verge.net.au>,
	Kexec Mailing List <kexec@lists.infradead.org>
Subject: Re: [PATCH] kexec: Teach configure to find the strip binary.
Date: Mon, 03 Dec 2012 17:26:31 -0800	[thread overview]
Message-ID: <87lide7gl4.fsf@xmission.com> (raw)
In-Reply-To: <CAE9FiQVc_3SC5JM497x3uPYyLqAyrOaRqocNNoZh98_5or1vzw@mail.gmail.com> (Yinghai Lu's message of "Mon, 3 Dec 2012 17:18:33 -0800")

Yinghai Lu <yinghai@kernel.org> writes:

> On Mon, Dec 3, 2012 at 5:11 PM, Eric W. Biederman <ebiederm@xmission.com> wrote:
>> Simon Horman <horms@verge.net.au> writes:
>>
>>> On Mon, Dec 03, 2012 at 02:25:25PM -0800, Eric W. Biederman wrote:
>>>>
>>>> For some reason my version of the Makefile generated by configure
>>>> included the line STRIP=strp.  Rerunning configure from a fresh slate
>>>> did not regenerate that line so I don't know how it got there.  So add
>>>> the code to Makefile.in and configure.ac to autodetect the strip binary.
>>>>
>>>> This is needed so that we can remove from purgatory all of the
>>>> relocations to sections that are not needed at runtime, by stripping
>>>> out those sections.
>>>>
>>>> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
>>>
>>> Thanks, I removed the last hunk, which seems to be a white-space only
>>> change to purgatory/arch/x86_64/Makefile, and applied the rest.
>>
>> Oops.  Thanks for cacthing that.  I didn't realize I had that change
>> sitting in my tree.
>
> after re config it. got
>
> DIRNAME         = dirname
> STRIP           = @STRIP@
>
>
> instead of
>
> STRIP = strip

Run bootstrap.  At the very least it looks like you haven't regeneratged
configure by running autoconf.

Eric


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2012-12-04  1:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19 16:56 [PATCH] kexec x86_64: Make purgatory relocatable anywhere in the 64bit address space Eric W. Biederman
2012-11-21  0:16 ` Simon Horman
2012-12-03 20:34 ` Yinghai Lu
2012-12-03 22:25   ` [PATCH] kexec: Teach configure to find the strip binary Eric W. Biederman
2012-12-04  0:09     ` Simon Horman
2012-12-04  1:11       ` Eric W. Biederman
2012-12-04  1:18         ` Yinghai Lu
2012-12-04  1:26           ` Eric W. Biederman [this message]
2012-12-04  1:29             ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lide7gl4.fsf@xmission.com \
    --to=ebiederm@xmission.com \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox