From: ebiederm@xmission.com (Eric W. Biederman)
To: Alex Deucher <alexdeucher@gmail.com>
Cc: "Christian König" <deathsimple@vodafone.de>,
kexec@lists.infradead.org,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"Markus Trippelsdorf" <markus@trippelsdorf.de>
Subject: Re: [PATCH 0/3] drm/radeon kexec fixes
Date: Tue, 10 Sep 2013 11:27:59 -0700 [thread overview]
Message-ID: <87ppsg8rbk.fsf@xmission.com> (raw)
In-Reply-To: <CADnq5_Oyd0hyr+WFYuA=a9Pa3i2e_ZY+Oc7LPawn8gSz3KPHUA@mail.gmail.com> (Alex Deucher's message of "Mon, 9 Sep 2013 09:04:01 -0400")
Alex Deucher <alexdeucher@gmail.com> writes:
> On Mon, Sep 9, 2013 at 5:21 AM, Markus Trippelsdorf
> <markus@trippelsdorf.de> wrote:
>
>> IIRC Alex said the sanity checks are expensive and boot-time could be
>> improved by dropping them. Maybe he can chime in?
>
> They shouldn't be necessary with a proper shutdown, but in this
> particular case, they are not very expensive. What is expensive is
> having a separate sanity check functions for all the various hw blocks
> to teardown everything on startup prior to starting it up in case
> kexec, etc. left the system in a bad state. It ends up amounting to a
> full tear down sequence followed by a full start up sequence every
> time you load the driver.
>
> I can't really comment on the first patch, but the rest seem fine.
Let me reask the question just a little bit.
Is it the sanity checks that are expensive? Or is it the
reinitialization that is triggered by the sanity checks that is
expensive?
From what Christian said in the other reply it sounds like this is a
game we will never completely win, but it would be nice to have half a
chance in the kexec on panic case to have video. So I am curious to
know if the checks are expensive when we are coming at hardware in a
clean state.
Eric
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-09-10 18:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-08 12:09 [PATCH 0/3] drm/radeon kexec fixes Markus Trippelsdorf
2013-09-08 12:10 ` [PATCH 1/3] kexec: get rid of late printk Markus Trippelsdorf
2013-09-08 20:11 ` Daniel Vetter
2013-09-08 20:42 ` Bruno Prémont
2013-09-08 12:10 ` [PATCH 2/3] drm/radeon: Implement radeon_pci_shutdown Markus Trippelsdorf
2013-09-09 13:32 ` Konrad Rzeszutek Wilk
2013-09-08 12:11 ` [PATCH 3/3] drm/radeon: get rid of r100_restore_sanity hack Markus Trippelsdorf
2013-09-09 0:32 ` [PATCH 0/3] drm/radeon kexec fixes Eric W. Biederman
2013-09-09 9:21 ` Markus Trippelsdorf
2013-09-09 9:38 ` Christian König
2013-09-11 9:01 ` Markus Trippelsdorf
2013-09-11 9:10 ` Christian König
2013-09-11 13:30 ` Alex Deucher
2013-09-09 13:04 ` Alex Deucher
2013-09-10 18:27 ` Eric W. Biederman [this message]
2013-09-10 20:40 ` Alex Deucher
2013-09-11 8:53 ` Markus Trippelsdorf
2013-09-11 9:21 ` Christian König
2013-09-11 13:40 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppsg8rbk.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=alexdeucher@gmail.com \
--cc=deathsimple@vodafone.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=kexec@lists.infradead.org \
--cc=markus@trippelsdorf.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox