From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from out03.mta.xmission.com ([166.70.13.233]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fEKbi-0003qP-IL for kexec@lists.infradead.org; Thu, 03 May 2018 20:13:40 +0000 From: ebiederm@xmission.com (Eric W. Biederman) References: <1523572911-16363-1-git-send-email-zohar@linux.vnet.ibm.com> Date: Thu, 03 May 2018 15:13:18 -0500 In-Reply-To: <1523572911-16363-1-git-send-email-zohar@linux.vnet.ibm.com> (Mimi Zohar's message of "Thu, 12 Apr 2018 18:41:48 -0400") Message-ID: <87r2mso5up.fsf@xmission.com> MIME-Version: 1.0 Subject: Re: [PATCH 0/3] kexec: limit kexec_load syscall List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Mimi Zohar Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Matthew Garrett , David Howells , linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org Mimi Zohar writes: > In environments that require the kexec kernel image to be signed, prevent > using the kexec_load syscall. In order for LSMs and IMA to differentiate > between kexec_load and kexec_file_load syscalls, this patch set adds a > call to security_kernel_read_file() in kexec_load_check(). Having thought about it some more this justification for these changes does not work. The functionality of kexec_load is already root-only. So in environments that require the kernel image to be signed just don't use kexec_load. Possibly even compile kexec_load out to save space because you will never need it. You don't need a new security hook to do any of that. Userspace is a very fine mechanism for being the instrument of policy. If you don't trust userspace that needs to be spelled out very clearly. You need to talk about what your threat models are. If the only justification is so that that we can't boot windows if someone hacks into userspace it has my nack because that is another kind of complete non-sense. Given that you are not trusting userspace this changeset also probably needs to have the kernel-hardening list cc'd. Because the only possible justification I can imagine for something like this is kernel-hardening. Eric _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec