From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from out03.mta.xmission.com ([166.70.13.233]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKKkS-0006uY-Sg for kexec@lists.infradead.org; Tue, 15 Oct 2019 11:12:18 +0000 From: ebiederm@xmission.com (Eric W. Biederman) References: <20191012022140.19003-1-lijiang@redhat.com> <20191012022140.19003-4-lijiang@redhat.com> <87d0f22oi5.fsf@x220.int.ebiederm.org> <20191012121625.GA11587@dhcp-128-65.nay.redhat.com> Date: Tue, 15 Oct 2019 06:11:21 -0500 In-Reply-To: (lijiang's message of "Mon, 14 Oct 2019 18:02:22 +0800") Message-ID: <87tv8az2jq.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Subject: Re: [PATCH 3/3 v3] x86/kdump: clean up all the code related to the backup region List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: lijiang Cc: jgross@suse.com, Thomas.Lendacky@amd.com, bhe@redhat.com, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, dhowells@redhat.com, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, tglx@linutronix.de, Dave Young , vgoyal@redhat.com bGlqaWFuZyA8bGlqaWFuZ0ByZWRoYXQuY29tPiB3cml0ZXM6Cgo+IOWcqCAyMDE55bm0MTDmnIgx MuaXpSAyMDoxNiwgRGF2ZSBZb3VuZyDlhpnpgZM6Cj4+IEhpIEVyaWMsCj4+IAo+PiBPbiAxMC8x Mi8xOSBhdCAwNjoyNmFtLCBFcmljIFcuIEJpZWRlcm1hbiB3cm90ZToKPj4+IExpYW5ibyBKaWFu ZyA8bGlqaWFuZ0ByZWRoYXQuY29tPiB3cml0ZXM6Cj4+Pgo+Pj4+IFdoZW4gdGhlIGNyYXNoa2Vy bmVsIGtlcm5lbCBjb21tYW5kIGxpbmUgb3B0aW9uIGlzIHNwZWNpZmllZCwgdGhlCj4+Pj4gbG93 IDFNaUIgbWVtb3J5IHdpbGwgYWx3YXlzIGJlIHJlc2VydmVkLCB3aGljaCBtYWtlcyB0aGF0IHRo ZSBtZW1vcnkKPj4+PiBhbGxvY2F0ZWQgbGF0ZXIgd29uJ3QgZmFsbCBpbnRvIHRoZSBsb3cgMU1p QiBhcmVhLCB0aGVyZWJ5LCBpdCdzIG5vdAo+Pj4+IG5lY2Vzc2FyeSB0byBjcmVhdGUgYSBiYWNr dXAgcmVnaW9uIGFuZCBhbHNvIG5vIG5lZWQgdG8gY29weSB0aGUgZmlyc3QKPj4+PiA2NDBrIGNv bnRlbnQgdG8gYSBiYWNrdXAgcmVnaW9uLgo+Pj4+Cj4+Pj4gQ3VycmVudGx5LCB0aGUgY29kZSBy ZWxhdGVkIHRvIHRoZSBiYWNrdXAgcmVnaW9uIGNhbiBiZSBzYWZlbHkgcmVtb3ZlZCwKPj4+PiBz byBsZXRzIGNsZWFuIHVwLgo+Pj4+Cj4+Pj4gU2lnbmVkLW9mZi1ieTogTGlhbmJvIEppYW5nIDxs aWppYW5nQHJlZGhhdC5jb20+Cj4+Pj4gLS0tCj4+Pgo+Pj4+IGRpZmYgLS1naXQgYS9hcmNoL3g4 Ni9rZXJuZWwvY3Jhc2guYyBiL2FyY2gveDg2L2tlcm5lbC9jcmFzaC5jCj4+Pj4gaW5kZXggZWI2 NTFmYmRlOTJhLi5jYzU3NzRmYzg0YzAgMTAwNjQ0Cj4+Pj4gLS0tIGEvYXJjaC94ODYva2VybmVs L2NyYXNoLmMKPj4+PiArKysgYi9hcmNoL3g4Ni9rZXJuZWwvY3Jhc2guYwo+Pj4+IEBAIC0xNzMs OCArMTczLDYgQEAgdm9pZCBuYXRpdmVfbWFjaGluZV9jcmFzaF9zaHV0ZG93bihzdHJ1Y3QgcHRf cmVncyAqcmVncykKPj4+PiAgCj4+Pj4gICNpZmRlZiBDT05GSUdfS0VYRUNfRklMRQo+Pj4+ICAK Pj4+PiAtc3RhdGljIHVuc2lnbmVkIGxvbmcgY3Jhc2hfemVyb19ieXRlczsKPj4+PiAtCj4+Pj4g IHN0YXRpYyBpbnQgZ2V0X25yX3JhbV9yYW5nZXNfY2FsbGJhY2soc3RydWN0IHJlc291cmNlICpy ZXMsIHZvaWQgKmFyZykKPj4+PiAgewo+Pj4+ICAJdW5zaWduZWQgaW50ICpucl9yYW5nZXMgPSBh cmc7Cj4+Pj4gQEAgLTIzNCw5ICsyMzIsMTUgQEAgc3RhdGljIGludCBwcmVwYXJlX2VsZjY0X3Jh bV9oZWFkZXJzX2NhbGxiYWNrKHN0cnVjdCByZXNvdXJjZSAqcmVzLCB2b2lkICphcmcpCj4+Pj4g IHsKPj4+PiAgCXN0cnVjdCBjcmFzaF9tZW0gKmNtZW0gPSBhcmc7Cj4+Pj4gIAo+Pj4+IC0JY21l bS0+cmFuZ2VzW2NtZW0tPm5yX3Jhbmdlc10uc3RhcnQgPSByZXMtPnN0YXJ0Owo+Pj4+IC0JY21l bS0+cmFuZ2VzW2NtZW0tPm5yX3Jhbmdlc10uZW5kID0gcmVzLT5lbmQ7Cj4+Pj4gLQljbWVtLT5u cl9yYW5nZXMrKzsKPj4+PiArCWlmIChyZXMtPnN0YXJ0ID49IFNaXzFNKSB7Cj4+Pj4gKwkJY21l bS0+cmFuZ2VzW2NtZW0tPm5yX3Jhbmdlc10uc3RhcnQgPSByZXMtPnN0YXJ0Owo+Pj4+ICsJCWNt ZW0tPnJhbmdlc1tjbWVtLT5ucl9yYW5nZXNdLmVuZCA9IHJlcy0+ZW5kOwo+Pj4+ICsJCWNtZW0t Pm5yX3JhbmdlcysrOwo+Pj4+ICsJfSBlbHNlIGlmIChyZXMtPmVuZCA+IFNaXzFNKSB7Cj4+Pj4g KwkJY21lbS0+cmFuZ2VzW2NtZW0tPm5yX3Jhbmdlc10uc3RhcnQgPSBTWl8xTTsKPj4+PiArCQlj bWVtLT5yYW5nZXNbY21lbS0+bnJfcmFuZ2VzXS5lbmQgPSByZXMtPmVuZDsKPj4+PiArCQljbWVt LT5ucl9yYW5nZXMrKzsKPj4+PiArCX0KPj4+Cj4+PiBXaGF0IGlzIGdvaW5nIG9uIHdpdGggdGhp cyBjaHVuaz8gIEkgY2FuIGd1ZXNzIGJ1dCB0aGlzIG5lZWRzIGEgY2xlYXIKPj4+IGNvbW1lbnQu Cj4+IAo+PiBJbmRlZWQgaXQgbmVlZHMgc29tZSBjb2RlIGNvbW1lbnQsIHRoaXMgaXMgYmFzZWQg b24gc29tZSBvZmZsaW5lCj4+IGRpc2N1c3Npb24uICBjYXQgL3Byb2Mvdm1jb3JlIHdpbGwgZ2l2 ZSBhIHdhcm5pbmcgYmVjYXVzZSBpb3JlbWFwIGlzCj4+IG1hcHBpbmcgdGhlIHN5c3RlbSByYW0u Cj4+IAo+PiBXZSBwYXNzIHRoZSBmaXJzdCAxTSB0byBrZHVtcCBrZXJuZWwgaW4gZTgyMCBhcyBz eXN0ZW0gcmFtIHNvIHRoYXQgMm5kCj4+IGtlcm5lbCBjYW4gdXNlIHRoZSBsb3cgMU0gbWVtb3J5 IGJlY2F1c2UgZm9yIGV4YW1wbGUgdGhlIHRyYW1wb2xpbmUKPj4gY29kZS4KPj4gCj4gVGhhbmsg eW91LCBFcmljIGFuZCBEYXZlLiBJIHdpbGwgYWRkIHRoZSBjb2RlIGNvbW1lbnQgYXMgYmVsb3cg aWYgaXQgd291bGQgYmUgT0suCj4KPiBAQCAtMjM0LDkgKzIzMiwyMCBAQCBzdGF0aWMgaW50IHBy ZXBhcmVfZWxmNjRfcmFtX2hlYWRlcnNfY2FsbGJhY2soc3RydWN0IHJlc291cmNlICpyZXMsIHZv aWQgKmFyZykKPiAgewo+ICAgICAgICAgc3RydWN0IGNyYXNoX21lbSAqY21lbSA9IGFyZzsKPiAg Cj4gLSAgICAgICBjbWVtLT5yYW5nZXNbY21lbS0+bnJfcmFuZ2VzXS5zdGFydCA9IHJlcy0+c3Rh cnQ7Cj4gLSAgICAgICBjbWVtLT5yYW5nZXNbY21lbS0+bnJfcmFuZ2VzXS5lbmQgPSByZXMtPmVu ZDsKPiAtICAgICAgIGNtZW0tPm5yX3JhbmdlcysrOwo+ICsgICAgICAgLyoKPiArICAgICAgICAq IEN1cnJlbnRseSwgcGFzcyB0aGUgbG93IDFNaUIgcmFuZ2UgdG8ga2R1bXAga2VybmVsIGluIGU4 MjAKPiArICAgICAgICAqIGFzIHN5c3RlbSByYW0gc28gdGhhdCBrZHVtcCBrZXJuZWwgY2FuIGFs c28gdXNlIHRoZSBsb3cgMU1pQgo+ICsgICAgICAgICogbWVtb3J5IGR1ZSB0byB0aGUgcmVhbCBt b2RlIHRyYW1wb2xpbmUgY29kZS4KPiArICAgICAgICAqIEFuZCBsYXRlciwgdGhlIGxvdyAxTWlC IHJhbmdlIHdpbGwgYmUgZXhjbHVlZCBmcm9tIGVsZiBoZWFkZXIsCj4gKyAgICAgICAgKiB3aGlj aCB3aWxsIGF2b2lkIHJlbWFwcGluZyB0aGUgMU1pQiBzeXN0ZW0gcmFtIHdoZW4gZHVtcGluZwo+ ICsgICAgICAgICogdm1jb3JlLgo+ICsgICAgICAgICovCj4gKyAgICAgICBpZiAocmVzLT5zdGFy dCA+PSBTWl8xTSkgewo+ICsgICAgICAgICAgICAgICBjbWVtLT5yYW5nZXNbY21lbS0+bnJfcmFu Z2VzXS5zdGFydCA9IHJlcy0+c3RhcnQ7Cj4gKyAgICAgICAgICAgICAgIGNtZW0tPnJhbmdlc1tj bWVtLT5ucl9yYW5nZXNdLmVuZCA9IHJlcy0+ZW5kOwo+ICsgICAgICAgICAgICAgICBjbWVtLT5u cl9yYW5nZXMrKzsKPiArICAgICAgIH0gZWxzZSBpZiAocmVzLT5lbmQgPiBTWl8xTSkgewo+ICsg ICAgICAgICAgICAgICBjbWVtLT5yYW5nZXNbY21lbS0+bnJfcmFuZ2VzXS5zdGFydCA9IFNaXzFN Owo+ICsgICAgICAgICAgICAgICBjbWVtLT5yYW5nZXNbY21lbS0+bnJfcmFuZ2VzXS5lbmQgPSBy ZXMtPmVuZDsKPiArICAgICAgICAgICAgICAgY21lbS0+bnJfcmFuZ2VzKys7Cj4gKyAgICAgICB9 Cj4gIAo+ICAgICAgICAgcmV0dXJuIDA7Cj4gIH0KCkkganVzdCByZWFkIHRocm91Z2ggdGhlIGFw cHJvcHJpYXRlIHNlY3Rpb24gb2YgY3Jhc2guYyBhbmQgdGhlIHdheQp0aGluZ3MgYXJlIHN0cnVj dHVyZWQgZG9pbmcgdGhpcyB3b3JrIGluCnByZXBhcmVfZWxmNjRfcmFtX2hlYWRlcnNfY2FsbGJh Y2sgaXMgd3JvbmcuCgpUaGlzIGNhbiBiZSBkb25lIGluIGEgc2ltcGxlciBtYW5uZXIgaW4gZWxm X2hlYWRlcl9leGNsdWRlX3Jhbmdlcy4KU29tZXRoaW5nIGxpa2U6CgoJLyogVGhlIGxvdyAxTWlC IGlzIGFsd2F5cyByZXNlcnZlZCAqLwoJcmV0ID0gY3Jhc2hfZXhjbHVkZV9tZW1fcmFuZ2UoY21l bSwgMCwgMTAyNCoxMDI0KTsKCWlmIChyZXQpCgkJcmV0dXJuIHJldDsKCkVyaWMKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmtleGVjIG1haWxpbmcgbGlz dAprZXhlY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8va2V4ZWMK