From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5] helo=mx0a-001b2d01.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i0F09-0002Qd-GJ for kexec@lists.infradead.org; Wed, 21 Aug 2019 01:01:26 +0000 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x7L0v9P0101259 for ; Tue, 20 Aug 2019 21:01:22 -0400 Received: from e32.co.us.ibm.com (e32.co.us.ibm.com [32.97.110.150]) by mx0b-001b2d01.pphosted.com with ESMTP id 2ugu9cs9vt-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 20 Aug 2019 21:01:22 -0400 Received: from localhost by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 21 Aug 2019 02:01:21 +0100 References: <20190715082702.27308-1-svens@stackframe.org> <20190715082702.27308-6-svens@stackframe.org> From: Thiago Jung Bauermann Subject: Re: [PATCH v4 5/7] kexec_elf: remove Elf_Rel macro In-reply-to: <20190715082702.27308-6-svens@stackframe.org> Date: Tue, 20 Aug 2019 22:01:11 -0300 MIME-Version: 1.0 Message-Id: <87tvabmiw8.fsf@morokweng.localdomain> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: kexec@lists.infradead.org Cc: Christophe Leroy , linuxppc-dev@lists.ozlabs.org, deller@gmx.de, Sven Schnelle Sven Schnelle writes: > It wasn't used anywhere, so lets drop it. > > Reviewed-by: Christophe Leroy > Signed-off-by: Sven Schnelle > --- > kernel/kexec_elf.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/kernel/kexec_elf.c b/kernel/kexec_elf.c > index 70d31b8feeae..e346659af324 100644 > --- a/kernel/kexec_elf.c > +++ b/kernel/kexec_elf.c > @@ -10,10 +10,6 @@ > > #define elf_addr_to_cpu elf64_to_cpu > > -#ifndef Elf_Rel > -#define Elf_Rel Elf64_Rel > -#endif /* Elf_Rel */ > - > static inline bool elf_is_elf_file(const struct elfhdr *ehdr) > { > return memcmp(ehdr->e_ident, ELFMAG, SELFMAG) == 0; Could you remove this one from the file in arch/powerpc as well? Perhaps this and the previous patch could be placed before patch 1, so that this change can be done only once. In any case: Reviewed-by: Thiago Jung Bauermann -- Thiago Jung Bauermann IBM Linux Technology Center _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec