Re: [PATCH 2/2 v2] kexec: Export PG_hwpoison flag into vmcoreinfo

Mitsuhiro Tanino
2013-02-12T13:29:48Z

Hello Andrew,

I proposed following patch set to support hwpoison flag at kdump second kernel.
These patch set includes fixes of both kernel side and makedumpfile side, and
both pathes have been acked by maintainers who are Eric and Kumagai-san.

[PATCH 0/2 v2] Exclude hwpoison page from vmcore dump
https://lkml.org/lkml/2012/10/31/805

[PATCH 1/2 v2] makedumpfile: Add a default action to exclude hwpoison page from vmcore
https://lkml.org/lkml/2012/10/31/376

[PATCH 2/2 v2] kexec: Export PG_hwpoison flag into vmcoreinfo
https://lkml.org/lkml/2012/10/31/359

Could you please push the kernel side patch to export PG_hwpoison flag into 3.9 during
next merge window?

This patch exports a PG_hwpoison into vmcoreinfo when
CONFIG_MEMORY_FAILURE is defined.
"makedumpfile" needs to read information of memory, such as
'mem_section', 'zone', 'pageflags' from vmcore.

We introduce a function into "makedumpfile" to exclude
hwpoison page from vmcore dump.
In order to introduce this function, PG_hwpoison flag have
to export into vmcoreinfo.

Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Mitsuhiro Tanino <mitsuhiro.tanino.gm@hitachi.com>
---
kernel/kexec.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/kernel/kexec.c b/kernel/kexec.c
index 0668d58..0d5d6bc 100644
--- a/kernel/kexec.c
+++ b/kernel/kexec.c
@@ -1513,6 +1513,9 @@ static int __init crash_save_vmcoreinfo_init(void)
VMCOREINFO_NUMBER(PG_lru);
VMCOREINFO_NUMBER(PG_private);
VMCOREINFO_NUMBER(PG_swapcache);
+#ifdef CONFIG_MEMORY_FAILURE
+ VMCOREINFO_NUMBER(PG_hwpoison);
+#endif

arch_crash_save_vmcoreinfo();
update_vmcoreinfo_note();
--
1.7.10.1