Re: [PATCH] /proc/kcore: Update physical address for kcore ram and text

From: Pratyush Anand <panand@redhat.com>
To: Kees Cook <keescook@chromium.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Baoquan He <bhe@redhat.com>,
	Atsushi Kumagai <ats-kumagai@wm.jp.nec.com>,
	Kexec Mailing List <kexec@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>,
	Dave Anderson <anderson@redhat.com>,
	Dave Young <dyoung@redhat.com>
Subject: Re: [PATCH] /proc/kcore: Update physical address for kcore ram and text
Date: Fri, 24 Feb 2017 12:50:50 +0530	[thread overview]
Message-ID: <905c2861-11bf-0449-31ab-596d9347e7cc@redhat.com> (raw)
In-Reply-To: <5b28ea05-24ab-b8db-e3d1-216399734297@redhat.com>

Hi Andrew/Kees,

On Tuesday 14 February 2017 07:16 AM, Pratyush Anand wrote:
>>
>> Well, CONFIG_PROC_KCORE is a generalized root KASLR exposure (though
>> there are lots of such exposures). Why is the actual physical address
>> needed? Can this just report the virtual address instead? Then the
>> tool can build a map, but it looks like an identity map, rather than
>> creating a new physical/virtual memory ASLR offset exposure?
>
> Well, having an ASLR offset information can help to translate an
> identity mapped virtual address to a physical address. But that would be
> an additional field in PT_LOAD header structure and an arch dependent
> value.
>
> Moreover, sending a valid physical address like 0 does not seem right.
> So, IMHO it is better to fix that and send valid physical address when
> available (identity mapped).
>
> Thanks for the review.

So, whats the decision on this patch? I see that patch is lying in 
next/master. Should I expect this patch in v4.11-rc1?

Couple of user-space makedumpfile modification will depend on this 
patch. So, we can not get those makedumpfile patches merged until this 
patch hits upstream.

~Pratyush

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec