From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: MIME-Version: 1.0 Date: Tue, 23 Oct 2018 10:18:26 +0530 From: Arun KS Subject: Re: [PATCH] mm: convert totalram_pages, totalhigh_pages and managed_pages to atomic. In-Reply-To: References: <1540229092-25207-1-git-send-email-arunks@codeaurora.org> Message-ID: <92d3523427e45124c71e16baabceb8c5@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Joe Perches Cc: Mike Snitzer , Benjamin Herrenschmidt , Kemi Wang , dri-devel@lists.freedesktop.org, "J. Bruce Fields" , linux-sctp@vger.kernel.org, Paul Mackerras , Pavel Machek , Christoph Lameter , "K. Y. Srinivasan" , Sumit Semwal , "David (ChunMing) Zhou" , Petr Tesarik , Michael Ellerman , ceph-devel@vger.kernel.org, "James E.J. Bottomley" , kasan-dev@googlegroups.com, Marcos Paulo de Souza , "Steven J. Hill" , David Rientjes , Anthony Yznaga , Daniel Vacek , Roman Gushchin , Len Brown , linux-pm@vger.kernel.org, Vlastimil Babka , linux-um@lists.infradead.org, Mike Rapoport , Alexander Viro , Thomas Gleixner , Trond Myklebust , Anton Altaparmakov , linux-parisc@vger.kernel.org, Mathieu Malaterre , Greg Kroah-Hartman , Randy Dunlap , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Cyril Bur , =?UTF-8?Q?Arve_Hj=C3=B8nnev=C3=A5g?= , netfilter-devel@vger.kernel.org, Souptick Joarder , Dmitry Kasatkin , Alex Deucher , Andrew Morton , Andrew-CT Chen , "Gustavo A. R. Silva" , David Airlie , dm-devel@redhat.com, Nadav Amit , Omar Sandoval , Alasdair Kergon , linux-s390@vger.kernel.org, Stephen Hemminger , intel-gfx@lists.freedesktop.org, Helge Deller , Hugh Dickins , "Luis R. Rodriguez" , coreteam@netfilter.org, Jozsef Kadlecsik , Andrey Ryabinin , linux-media@vger.kernel.org, YueHaibing , Todd Kjos , Philippe Ombredanne , Jani Nikula , Jia He , Tejun Heo , Shakeel Butt , Houlong Wei , Boris Ostrovsky , Martijn Coenen , linux-arm-kernel@lists.infradead.org, Khalid Aziz , Oded Gabbay , linaro-mm-sig@lists.linaro.org, linux-ntfs-dev@lists.sourceforge.net, Jonathan Corbet , Florian Westphal , Anna Schumaker , Pekka Enberg , Minchan Kim , Eric Biederman , "Aneesh Kumar K.V" , Martin Schwidefsky , Joonsoo Kim , Kate Stewart , Marcelo Ricardo Leitner , linux-fsdevel@vger.kernel.org, Tetsuo Handa , Joonas Lahtinen , Heiko Carstens , Stefan Agner , James Morris , netdev@vger.kernel.org, amd-gfx@lists.freedesktop.org, Jan Kara , Alexander Duyck , Gerrit Renker , Andy Shevchenko , Miklos Szeredi , David Hildenbrand , Matthew Wilcox , Konstantin Khlebnikov , Matthew Auld , Guo Ren , Huang Ying , Alexey Kuznetsov , Ilya Dryomov , Alexey Dobriyan , Pablo Neira Ayuso , "Serge E. Hallyn" , Kees Cook , Arnd Bergmann , Haiyang Zhang , Mark Brown , Borislav Petkov , Rodrigo Vivi , Dan Williams , Mauro Carvalho Chehab , Dan Streetman , Oscar Salvador , linux-nfs@vger.kernel.org, Neil Horman , Tvrtko Ursulin , Jeff Layton , Eric Dumazet , Jessica Yu , devel@linuxdriverproject.org, "David S. Miller" , "Kirill A. Shutemov" , Michal Hocko , Minghsiu Tsai , =?UTF-8?Q?Christian_K=C3=B6nig?= , "VMware, Inc." , Sebastian Andrzej Siewior , Russell Currey , Chris Wilson , linux-mm@kvack.org, Alexander Potapenko , "H. Peter Anvin" , getarunks@gmail.com, Chintan Pandya , devel@driverdev.osuosl.org, "Yan, Zheng" , xen-devel@lists.xenproject.org, Sage Weil , dccp@vger.kernel.org, Richard Weinberger , Seth Jennings , x86@kernel.org, Ingo Molnar , Laura Abbott , Mimi Zohar , Jeff Dike , Pavel Tatashin , Jann Horn , Xavier Deguillard , Johannes Weiner , =?UTF-8?Q?J=C3=A9r?= =?UTF-8?Q?=C3=B4me_Glisse?= , Kirill Tkhai , linux-mediatek@lists.infradead.org, Matthias Brugger , Tiffany Lin , linux-integrity@vger.kernel.org, Dmitry Vyukov , Juergen Gross , Yang Shi , Hideaki YOSHIFUJI , linuxppc-dev@lists.ozlabs.org, Vlad Yasevich , linux-decnet-user@lists.sourceforge.net, kexec@lists.infradead.org, linux-security-module@vger.kernel.org, Thomas Zimmermann , Mika Kuoppala , Mel Gorman On 2018-10-23 09:45, Joe Perches wrote: > On Mon, 2018-10-22 at 22:53 +0530, Arun KS wrote: >> Remove managed_page_count_lock spinlock and instead use atomic >> variables. > Hello Joe, > Perhaps better to define and use macros for the accesses > instead of specific uses of atomic_long_ > > Something like: > > #define totalram_pages() (unsigned > long)atomic_long_read(&_totalram_pages) > #define totalram_pages_inc() (unsigned > long)atomic_long_inc(&_totalram_pages) > #define totalram_pages_dec() (unsigned > long)atomic_long_dec(&_totalram_pages) That sounds like a nice idea. Regards, Arun _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec