From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-bl2nam02on062b.outbound.protection.outlook.com ([2a01:111:f400:fe46::62b] helo=NAM02-BL2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gPJ6H-0004u0-Do for kexec@lists.infradead.org; Wed, 21 Nov 2018 03:22:51 +0000 From: Nadav Amit Subject: Re: [PATCH v1 6/8] vmw_balloon: mark inflated pages PG_offline Date: Wed, 21 Nov 2018 03:22:26 +0000 Message-ID: <9F78496F-EBAE-4248-80F0-0CB55CEFA238@vmware.com> References: <20181119101616.8901-1-david@redhat.com> <20181119101616.8901-7-david@redhat.com> In-Reply-To: <20181119101616.8901-7-david@redhat.com> Content-Language: en-US Content-ID: <12E088AA76269B4A994B7F7315294D9A@namprd05.prod.outlook.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: David Hildenbrand Cc: Michal Hocko , "Michael S. Tsirkin" , Arnd Bergmann , "linux-pm@vger.kernel.org" , pv-drivers , Greg Kroah-Hartman , "open list:DOCUMENTATION" , kexec-ml , Linux Kernel Mailing List , Matthew Wilcox , linux-mm , Julien Freche , Xavier Deguillard , xen-devel , linux-fsdevel , "devel@linuxdriverproject.org" , Andrew Morton Thanks for this patch! > On Nov 19, 2018, at 2:16 AM, David Hildenbrand wrote: > > Mark inflated and never onlined pages PG_offline, to tell the world that > the content is stale and should not be dumped. > > Cc: Xavier Deguillard > Cc: Nadav Amit > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman > Cc: Julien Freche > Cc: Andrew Morton > Cc: Matthew Wilcox > Cc: Michal Hocko > Cc: "Michael S. Tsirkin" > Signed-off-by: David Hildenbrand > --- > drivers/misc/vmw_balloon.c | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c > index e6126a4b95d3..8cc8bd9a4e32 100644 > --- a/drivers/misc/vmw_balloon.c > +++ b/drivers/misc/vmw_balloon.c > @@ -544,6 +544,36 @@ unsigned int vmballoon_page_order(enum vmballoon_page_size_type page_size) > return page_size == VMW_BALLOON_2M_PAGE ? VMW_BALLOON_2M_ORDER : 0; > } > > +/** > + * vmballoon_mark_page_offline() - mark a page as offline > + * @page: pointer for the page If possible, please add a period at the end of the sentence (yes, I know I got it wrong in some places too). > + * @page_size: the size of the page. > + */ > +static void > +vmballoon_mark_page_offline(struct page *page, > + enum vmballoon_page_size_type page_size) > +{ > + int i; > + > + for (i = 0; i < 1ULL << vmballoon_page_order(page_size); i++) Can you please do instead: unsigned int; for (i = 0; i < vmballoon_page_in_frames(page_size); i++) > + __SetPageOffline(page + i); > +} > + > +/** > + * vmballoon_mark_page_online() - mark a page as online > + * @page: pointer for the page > + * @page_size: the size of the page. > + */ > +static void > +vmballoon_mark_page_online(struct page *page, > + enum vmballoon_page_size_type page_size) > +{ > + int i; > + > + for (i = 0; i < 1ULL << vmballoon_page_order(page_size); i++) > + __ClearPageOffline(page + i); Same here (use vmballoon_page_in_frames). > +} > + > /** > * vmballoon_page_in_frames() - returns the number of frames in a page. > * @page_size: the size of the page. > @@ -612,6 +642,7 @@ static int vmballoon_alloc_page_list(struct vmballoon *b, > ctl->page_size); > > if (page) { > + vmballoon_mark_page_offline(page, ctl->page_size); > /* Success. Add the page to the list and continue. */ > list_add(&page->lru, &ctl->pages); > continue; > @@ -850,6 +881,7 @@ static void vmballoon_release_page_list(struct list_head *page_list, > > list_for_each_entry_safe(page, tmp, page_list, lru) { > list_del(&page->lru); > + vmballoon_mark_page_online(page, page_size); > __free_pages(page, vmballoon_page_order(page_size)); > } We would like to test it in the next few days, but in the meanwhile, after you address these minor issues: Acked-by: Nadav Amit Thanks again, Nadav _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec