From: "YAMAZAKI MASAMITSU(山崎 真光)" <yamazaki-msmt@nec.com>
To: Coiby Xu <coxu@redhat.com>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>
Subject: Re: [PATCH makedumpfile] Make sbindir configurable
Date: Fri, 24 May 2024 08:34:40 +0000 [thread overview]
Message-ID: <9d160cb4-bb4f-4132-8800-ff681d5c3b87@nec.com> (raw)
In-Reply-To: <20240424022047.13325-1-coxu@redhat.com>
On 2024/04/24 11:20, Coiby Xu wrote:
> Fedora is going unify bin and sbin and /usr/sbin directory will become a
> symlink to bin [1]. So make sbindir configurable to support this case.
>
> [1] https://fedoraproject.org/wiki/Changes/Unify_bin_and_sbin
>
> Signed-off-by: Coiby Xu <coxu@redhat.com>
> ---
> Makefile | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 55c9c7a..0cd2b03 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -101,6 +101,8 @@ LINK_TEST_PROG="int main() { return 0; }"
> LIBS := $(LIBS) $(call try-run,\
> echo $(LINK_TEST_PROG) | $(CC) -o "$$TMP" -x c - -lebl,-lebl,)
>
> +sbindir ?= /usr/sbin
> +
> all: makedumpfile
>
> $(OBJ_PART): $(SRC_PART)
> @@ -126,8 +128,8 @@ clean:
> rm -f $(OBJ) $(OBJ_PART) $(OBJ_ARCH) makedumpfile makedumpfile.8 makedumpfile.conf.5
>
> install:
> - install -m 755 -d ${DESTDIR}/usr/sbin ${DESTDIR}/usr/share/man/man5 ${DESTDIR}/usr/share/man/man8
> - install -m 755 -t ${DESTDIR}/usr/sbin makedumpfile $(VPATH)makedumpfile-R.pl
> + install -m 755 -d ${DESTDIR}/${sbindir} ${DESTDIR}/usr/share/man/man5 ${DESTDIR}/usr/share/man/man8
> + install -m 755 -t ${DESTDIR}/${sbindir} makedumpfile $(VPATH)makedumpfile-R.pl
> install -m 644 -t ${DESTDIR}/usr/share/man/man8 makedumpfile.8
> install -m 644 -t ${DESTDIR}/usr/share/man/man5 makedumpfile.conf.5
> mkdir -p ${DESTDIR}/usr/share/makedumpfile/eppic_scripts
Thank you, Coiby, for the patch. Sorry for the late apply the patch.
The sbindir variable should be all capital letter, such as SBINDIR.
So, the patch is fixed as below.
https://github.com/makedumpfile/makedumpfile/commit/354fbdd01ccb15e405093f9a631ab8b2bd084830
Thanks,
Masa
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2024-05-24 8:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 2:20 [PATCH makedumpfile] Make sbindir configurable Coiby Xu
2024-04-26 8:01 ` HAGIO KAZUHITO(萩尾 一仁)
2024-05-24 8:34 ` YAMAZAKI MASAMITSU(山崎 真光) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d160cb4-bb4f-4132-8800-ff681d5c3b87@nec.com \
--to=yamazaki-msmt@nec.com \
--cc=coxu@redhat.com \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox