From: Simon Horman <horms@verge.net.au>
To: kexec@lists.infradead.org
Subject: [PATCH] kexec-xen: Allow xen_kexec_exec() to return in case of Live Update
Date: Wed, 23 Mar 2022 15:43:41 +0100 [thread overview]
Message-ID: <YjsyHWtQArHXVZYJ@vergenet.net> (raw)
In-Reply-To: <b1aea785-1631-2afc-2d8c-c21067903978@gmail.com>
On Wed, Mar 23, 2022 at 02:20:52PM +0000, Raphael Ning wrote:
>
> On 23/03/2022 14:08, Simon Horman wrote:
> > Hi Raphael,
> > thanks for your patch. Overall I think this is good.
> >
> > Unfortunately I am seeing a build failure with this patch applied.
> >
> > ../../kexec/kexec-xen.c:292:6: error: conflicting types for ?xen_kexec_exec?
> > 292 | void xen_kexec_exec(uint64_t kexec_flags)
> > | ^~~~~~~~~~~~~~
> > In file included from ../../kexec/kexec-xen.c:6:
> > ../../kexec/kexec.h:327:5: note: previous declaration of ?xen_kexec_exec? was here
> > 327 | int xen_kexec_exec(uint64_t kexec_flags);
> > | ^~~~~~~~~~~~~~
> > make[1]: *** [Makefile:124: kexec/kexec-xen.o] Error 1
> > make[1]: *** Waiting for unfinished jobs....
> >
> > See: https://github.com/horms/kexec-tools/runs/5661629877?check_suite_focus=true
>
>
> Hi Simon,
>
>
> Thanks for the review.? The conflicting declaration is for the --without-xen build, which I didn't test.? Let me fix that and post a new revision.
Thanks Raphael,
much appreciated.
prev parent reply other threads:[~2022-03-23 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 9:21 [PATCH] kexec-xen: Allow xen_kexec_exec() to return in case of Live Update Raphael Ning
2022-03-23 14:08 ` Simon Horman
2022-03-23 14:20 ` Raphael Ning
2022-03-23 14:43 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjsyHWtQArHXVZYJ@vergenet.net \
--to=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox