Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: kexec@lists.infradead.org
Subject: [PATCH] arm64/crashdump-arm64: increase CRASH_MAX_MEMORY_RANGES to 32k
Date: Tue, 26 Apr 2022 08:14:15 +0800	[thread overview]
Message-ID: <Ymc5VxBOQgyrrN+y@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20220419172327.11288-1-abuehaze@amazon.com>

On 04/19/22 at 05:23pm, abuehaze14 wrote:
> On ARM64 based VMs hotplugging more than 31GB of memory will cause
> kdump to fail loading as it's hitting the CRASH_MAX_MEMORY_RANGES
> limit which is currently 32 on ARM64 given that the  memory block size
> is 1GB. This patch is raising CRASH_MAX_MEMORY_RANGES
> to 32K similar to what we have on x86, this should allow
> kdump to work until the VM has 32TB which should be
> enough for a long time.
> 
> Signed-off-by: Hazem Mohamed Abuelfotoh <abuehaze@amazon.com>

Sounds reasonable.

Acked-by: Baoquan He <bhe@redhat.com>

By the way, Simon usually collects kexec-tools patches every one to two
weeks, no need to always ping in a short time.

> ---
>  kexec/arch/arm64/crashdump-arm64.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kexec/arch/arm64/crashdump-arm64.h b/kexec/arch/arm64/crashdump-arm64.h
> index 12f4308..82fa69b 100644
> --- a/kexec/arch/arm64/crashdump-arm64.h
> +++ b/kexec/arch/arm64/crashdump-arm64.h
> @@ -14,7 +14,7 @@
>  
>  #include "kexec.h"
>  
> -#define CRASH_MAX_MEMORY_RANGES	32
> +#define CRASH_MAX_MEMORY_RANGES	32768
>  
>  /* crash dump kernel support at most two regions, low_region and high region. */
>  #define CRASH_MAX_RESERVED_RANGES	2
> -- 
> 2.32.0
> 
> 
> _______________________________________________
> kexec mailing list
> kexec at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
> 



  parent reply	other threads:[~2022-04-26  0:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19 17:23 [PATCH] arm64/crashdump-arm64: increase CRASH_MAX_MEMORY_RANGES to 32k abuehaze14
2022-04-19 17:36 ` Mohamed
2022-04-19 17:48   ` Mohamed
2022-04-25 20:49     ` Mohamed
2022-04-26  0:14 ` Baoquan He [this message]
2022-04-28 12:15   ` Mohamed
2022-04-29  9:58   ` Simon Horman
2022-05-02 12:43     ` Mohamed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ymc5VxBOQgyrrN+y@MiWiFi-R3L-srv \
    --to=bhe@redhat.com \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox