From: Simon Horman <horms@kernel.org>
To: Pingfan Liu <piliu@redhat.com>
Cc: kexec@lists.infradead.org, Jeremy Linton <jeremy.linton@arm.com>,
horms@verge.net.au, ardb@kernel.org
Subject: Re: [PATCHv6 3/5] kexec/zboot: Add arch independent zboot support
Date: Wed, 2 Aug 2023 14:17:54 +0200 [thread overview]
Message-ID: <ZMpJcgeGeYhcuGfe@kernel.org> (raw)
In-Reply-To: <ZMpJIZ18ynQLln8W@kernel.org>
On Wed, Aug 02, 2023 at 02:16:33PM +0200, Simon Horman wrote:
> On Wed, Aug 02, 2023 at 05:53:59PM +0800, Pingfan Liu wrote:
> > Hi Simon,
> >
> > Thanks for the try. Please see the comment below.
> >
> > On Tue, Aug 1, 2023 at 3:00 PM Simon Horman <horms@kernel.org> wrote:
> > >
> > > On Mon, Jul 24, 2023 at 10:21:40AM +0800, Pingfan Liu wrote:
> > > > From: Jeremy Linton <jeremy.linton@arm.com>
> > > >
> > > > The linux kernel CONFIG_ZBOOT option creates
> > > > self decompressing PE kernel images. So this means
> > > > that kexec should have a generic understanding of
> > > > the format which may be used by multiple arches.
> > > >
> > > > So lets add an arch independent validation
> > > > and decompression routine.
> > > >
> > > > Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> > > > [Modified by Pingfan to export kernel fd]
> > > > Signed-off-by: Pingfan Liu <piliu@redhat.com>
> > >
> > > Hi Pingfan,
> > >
> > > unfortunately this causes a build failure on hppa.
> > >
> > > ../../kexec/kexec-pe-zboot.c:31:10: fatal error: kexec-pe-zboot.h: No such file or directory
> > > 31 | #include <kexec-pe-zboot.h>
> > > | ^~~~~~~~~~~~~~~~~~
> > >
> > > Link: https://github.com/horms/kexec-tools/actions/runs/5723580523/job/15508425790
> > >
> >
> > It is not related to cross-compiling. Actually, I have tried to
> > simplify the test matrix, which limits the compilation only on x86_64.
> > And I got the similar error [1]
> >
> > The workflow control file is [2], which clips out all arches except
> > x86_64. But I can successfully build it on the Fedora system with the
> > following bash script, which is based on the github's build log. So
> > maybe it is a bug with the compiling tools?
> >
> > kexec_tools_dir="./"
> >
> > mkdir $kexec_tools_dir/_build \
> > $kexec_tools_dir/_build/sub \
> > $kexec_tools_dir/_inst \
> > $kexec_tools_dir/_dest
> > chmod a-w $kexec_tools_dir
> > test -d $kexec_tools_dir/_build
> > INSTALL_BASE=$(cd $kexec_tools_dir/_inst && pwd | sed -e
> > 's,^[^:\\/]:[\\/],/,') &&\
> > DESTDIR="$kexec_tools_dir/_dest" && \
> > cd $kexec_tools_dir/_build/sub && \
> > ../../configure \
> > \
> > --srcdir=../.. --prefix="$INSTALL_BASE" && \
> > make -j8
> >
> >
> > [1]: https://github.com/pfliu/kexec-tools/actions/runs/5737254109/job/15548520863
> > [2]: https://github.com/pfliu/kexec-tools/blob/zbootV6/.github/workflows/main.yml
>
> Thanks,
>
> I guess that kexec-pe-zboot.h is missing in the build environment for the
> GitHub actions, but present in your Fedora environment.
>
> Could you take a look and see where your copy of kexec-pe-zboot.h
> came from?
Actually it seems to be added by this patch (sorry for not noticing)!
So I guess it is an include path problem.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2023-08-02 12:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 2:21 [PATCHv6 0/5] arm64: zboot support Pingfan Liu
2023-07-24 2:21 ` [PATCHv6 1/5] kexec/arm64: Simplify the code for zImage Pingfan Liu
2023-07-24 2:21 ` [PATCHv6 2/5] kexec: Introduce a member kernel_fd in kexec_info Pingfan Liu
2023-07-24 2:21 ` [PATCHv6 3/5] kexec/zboot: Add arch independent zboot support Pingfan Liu
2023-08-01 7:00 ` Simon Horman
2023-08-02 9:53 ` Pingfan Liu
2023-08-02 12:16 ` Simon Horman
2023-08-02 12:17 ` Simon Horman [this message]
2023-08-02 12:33 ` Simon Horman
2023-08-03 2:37 ` Pingfan Liu
2023-08-03 8:04 ` Simon Horman
2023-07-24 2:21 ` [PATCHv6 4/5] arm64: Add ZBOOT PE containing compressed image support Pingfan Liu
2023-07-24 2:21 ` [PATCHv6 5/5] arm64: Hook up the ZBOOT support as vmlinuz Pingfan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMpJcgeGeYhcuGfe@kernel.org \
--to=horms@kernel.org \
--cc=ardb@kernel.org \
--cc=horms@verge.net.au \
--cc=jeremy.linton@arm.com \
--cc=kexec@lists.infradead.org \
--cc=piliu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox