From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 611E1D2FFFA for ; Fri, 18 Oct 2024 15:40:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wOuQ39n8K4yQx1Ui77S0NAEWGxEMNkvWcKSd8DAA/bw=; b=4VYLMjM0rZs9TO liZpjIC2twvVBmnfQbXEP97Abg4SOVAATeOdGbdIP+kp2e1jVevXjHbW6l0+4yW9qMlHhNxOegS52 mcF6hUTOlec/uhOdqFiy8CEFyeUfyUNfZSWeG7sC34DbGXP6U1w9LxTWUqkQiGfwXS0HzLCiPZzdd Sgf4i3an7wLvZrRGrD34IEaP1D2kIsVbTcp8S0rVVikct9kmSDzMTBjF6o2PWHtOJEDPUQDF0b91J LCajrH5Nhkutk0ktPssmkGScCyuhuV+MAArRXw3oWZdXlSA+pYKEK9BNNHLcNnjLGf1m/8TCYJ7mv OQaG5+rBdApd2HeS82tw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1p5V-00000001E6V-3W91; Fri, 18 Oct 2024 15:40:25 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1p5K-00000001E5D-1uPe for kexec@lists.infradead.org; Fri, 18 Oct 2024 15:40:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729266012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L7sF+ux8tQB6rtv2OQ9q9fbX718Icj+2tzphppaDZ3A=; b=PxH8PXi0eVYhzTd5whrXowxwlkEu23oSukwRZEbExcu8N14AGDo3FwXR4dlKkA1QJ9XoTa yzqbJdro9iDg/vc4wVK0HGC5i197whSLFFqvvbAzhC9a6ZyNL48qH+V2cyA6wxvcV8wbuf kSO7NCi5YDaoWEZfclrJ2mVaWF0uUCA= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-9VZDhXIJN6-ai3qN3pH6Fg-1; Fri, 18 Oct 2024 11:40:10 -0400 X-MC-Unique: 9VZDhXIJN6-ai3qN3pH6Fg-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E8B231964CF3; Fri, 18 Oct 2024 15:40:06 +0000 (UTC) Received: from localhost (unknown [10.72.112.28]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 39A1F1955D5A; Fri, 18 Oct 2024 15:39:10 +0000 (UTC) Date: Fri, 18 Oct 2024 23:39:00 +0800 From: Baoquan He To: Andy Shevchenko Cc: Gregory Price , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, bhelgaas@google.com, ilpo.jarvinen@linux.intel.com, mika.westerberg@linux.intel.com, ying.huang@intel.com, tglx@linutronix.de, takahiro.akashi@linaro.org, stable@vger.kernel.org Subject: Re: [PATCH] resource,kexec: walk_system_ram_res_rev must retain resource flags Message-ID: References: <20241017190347.5578-1-gourry@gourry.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241018_084014_594593_7ED46E2A X-CRM114-Status: GOOD ( 25.34 ) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org On 10/18/24 at 05:52pm, Andy Shevchenko wrote: > On Fri, Oct 18, 2024 at 05:51:09PM +0300, Andy Shevchenko wrote: > > On Fri, Oct 18, 2024 at 09:52:47PM +0800, Baoquan He wrote: > > > On 10/18/24 at 03:22pm, Andy Shevchenko wrote: > > > > On Fri, Oct 18, 2024 at 10:18:42AM +0800, Baoquan He wrote: > > > > > On 10/17/24 at 03:03pm, Gregory Price wrote: > > > > > > walk_system_ram_res_rev() erroneously discards resource flags when > > > > > > passing the information to the callback. > > > > > > > > > > > > This causes systems with IORESOURCE_SYSRAM_DRIVER_MANAGED memory to > > > > > > have these resources selected during kexec to store kexec buffers > > > > > > if that memory happens to be at placed above normal system ram. > > > > > > > > > > Sorry about that. I haven't checked IORESOURCE_SYSRAM_DRIVER_MANAGED > > > > > memory carefully, wondering if res could be set as > > > > > 'IORESOURCE_SYSTEM_RAM | IORESOURCE_BUSY' plus > > > > > IORESOURCE_SYSRAM_DRIVER_MANAGED in iomem_resource tree. > > > > > > > > > > Anyway, the change in this patch is certainly better. Thanks. > > > > > > > > Can we get more test cases in the respective module, please? > > > > > > Do you mean testing CXL memory in kexec/kdump? No, we can't. Kexec/kdump > > > test cases basically is system testing, not unit test or module test. It > > > needs run system and then jump to 2nd kernel, vm can be used but it > > > can't cover many cases existing only on baremetal. Currenly, Redhat's > > > CKI is heavily relied on to test them, however I am not sure if system > > > with CXL support is available in our LAB. > > > > > > Not sure if I got you right. > > > > I meant since we touch resource.c, we should really touch resource_kunit.c > > *in addition to*. > > And to be more clear, there is no best time to add test cases than > as early as possible. So, can we add the test cases to the (new) APIs, > so we want have an issue like the one this patch fixes? I will have a look at kernel/resource_kunit.c to see if I can add something for walk_system_ram_res_rev(). Thanks. _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec