From: lijiang <lijiang@redhat.com>
To: Dave Young <dyoung@redhat.com>
Cc: thomas.lendacky@amd.com, linux-efi <linux-efi@vger.kernel.org>,
bhe@redhat.com, Ard Biesheuvel <ard.biesheuvel@linaro.org>,
joro@8bytes.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
mingo@redhat.com, ebiederm@xmission.com, hpa@zytor.com,
tglx@linutronix.de
Subject: Re: [PATCH 2/5 V6] x86/ioremap: strengthen the logic in early_memremap_pgprot_adjust() to adjust encryption mask
Date: Wed, 5 Sep 2018 22:04:49 +0800 [thread overview]
Message-ID: <a09a3a21-9156-ce96-b7ef-9f7e7cda12b3@redhat.com> (raw)
In-Reply-To: <20180905064658.GA10310@dhcp-128-65.nay.redhat.com>
在 2018年09月05日 14:46, Dave Young 写道:
> [snip]
>>
>> As previously mentioned, there are also many differences between kexec and kdump. In general,
>> kexec needs to look at all of available physical memory, but kdump doesn't need.
>>
>> For kexec, kexec-tools will read /sys/firmware/memmap and recreate the e820 ranges for the 2nd
>> kernel. If it fails, will use /proc/iomem.
>>
>> For kdump, kexec-tools will read /proc/iomem and recreate the e820 ranges for kdump kernel.
>> BTW: we can not get the range of persistent memory from /proc/iomem. So e820 ranges don't contain
>> the persistent memory in kdump kernel, this is the real reason why i need to strengthen the logic
>> of adjusting memory encryption mask.
>
> "persistent memory" is different, I think you meant about some reserved
> memory instead
>
>>
>> If kexec-tools also use /sys/firmware/memmap for kdump(like kexec), kdump kernel can also work
>> without a fix, but the kexec-tools will have to be modified. Are you sure that you want me to
>> fix kexec-tools instead of kernel?
>
> Yes, please fix kexec-tools to pass reserved ranges in e820, you will
> not need this patch then.
>
This might be a kexec-tools bug, i have posted a patch for kexec-tools(please check kexec@lists.infradead.org).
Thanks.
> Thanks
> Dave
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2018-09-05 14:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 8:19 [PATCH 0/5 V6] Support kdump for AMD secure memory encryption(SME) Lianbo Jiang
2018-08-31 8:19 ` [PATCH 1/5 V6] x86/ioremap: add a function ioremap_encrypted() to remap kdump old memroy Lianbo Jiang
2018-08-31 8:19 ` [PATCH 2/5 V6] x86/ioremap: strengthen the logic in early_memremap_pgprot_adjust() to adjust encryption mask Lianbo Jiang
2018-09-03 2:45 ` Dave Young
2018-09-03 14:06 ` lijiang
2018-09-04 0:44 ` Dave Young
2018-09-04 1:29 ` Dave Young
2018-09-04 1:51 ` Dave Young
2018-09-05 6:35 ` lijiang
2018-09-05 6:46 ` Dave Young
2018-09-05 14:04 ` lijiang [this message]
2018-09-04 1:44 ` lijiang
2018-08-31 8:19 ` [PATCH 3/5 V6] kexec: allocate unencrypted control pages for kdump in case SME is enabled Lianbo Jiang
2018-08-31 8:19 ` [PATCH 4/5 V6] iommu/amd_iommu: remap the device table of IOMMU with the memory encryption mask for kdump Lianbo Jiang
2018-08-31 8:19 ` [PATCH 5/5 V6] kdump/vmcore: support encrypted old memory with SME enabled Lianbo Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a09a3a21-9156-ce96-b7ef-9f7e7cda12b3@redhat.com \
--to=lijiang@redhat.com \
--cc=ard.biesheuvel@linaro.org \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kexec@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox