From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-bn3nam01on0059.outbound.protection.outlook.com ([104.47.33.59] helo=NAM01-BN3-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dLUkX-0000fu-Gh for kexec@lists.infradead.org; Thu, 15 Jun 2017 13:23:51 +0000 Subject: Re: [PATCH v6 25/34] swiotlb: Add warnings for use of bounce buffers with SME References: <20170607191309.28645.15241.stgit@tlendack-t1.amdoffice.net> <20170607191732.28645.42876.stgit@tlendack-t1.amdoffice.net> <20170614165052.fyn5t4gkq5leczcc@pd.tnic> <33d1debc-c684-cba1-7d95-493678f086d0@amd.com> <20170615090832.ncmq2kgom32cchhw@pd.tnic> From: Tom Lendacky Message-ID: Date: Thu, 15 Jun 2017 08:23:17 -0500 MIME-Version: 1.0 In-Reply-To: <20170615090832.ncmq2kgom32cchhw@pd.tnic> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Borislav Petkov Cc: linux-efi@vger.kernel.org, Brijesh Singh , Toshimitsu Kani , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Matt Fleming , x86@kernel.org, linux-mm@kvack.org, Alexander Potapenko , "H. Peter Anvin" , Larry Woodman , linux-arch@vger.kernel.org, kvm@vger.kernel.org, Jonathan Corbet , Joerg Roedel , linux-doc@vger.kernel.org, kasan-dev@googlegroups.com, Ingo Molnar , Andrey Ryabinin , Dave Young , Rik van Riel , Arnd Bergmann , Konrad Rzeszutek Wilk , Andy Lutomirski , Thomas Gleixner , Dmitry Vyukov , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, "Michael S. Tsirkin" , Paolo Bonzini On 6/15/2017 4:08 AM, Borislav Petkov wrote: > On Wed, Jun 14, 2017 at 02:49:02PM -0500, Tom Lendacky wrote: >> I guess I don't need the sme_active() check since the second part of the >> if statement can only ever be true if SME is active (since mask is >> unsigned). > > ... and you can define sme_me_mask as an u64 directly (it is that already, > practically, as we don't do SME on 32-bit) and then get rid of the cast. Let me look into that. There are so many places that are expecting an unsigned long I'll have to see how that all works out from a build perspective. Thanks, Tom > _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec