From: Pratyush Anand <panand@redhat.com>
To: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>, horms@verge.net.au
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH v2] kexec/fs2dt: Check for NULL pointer in dt_copy_old_root_param()
Date: Thu, 29 Sep 2016 13:54:00 +0530 [thread overview]
Message-ID: <a9c0bc6c-c9df-0ed9-8774-20821a8edf26@redhat.com> (raw)
In-Reply-To: <1475135953-21729-1-git-send-email-maddy@linux.vnet.ibm.com>
On Thursday 29 September 2016 01:29 PM, Madhavan Srinivasan wrote:
> In dt_copy_old_root_param(), FILE * returned
> from fopen is not checked for NULL pointer
> before passinig to fclose(). This could trigger
> a segfault. Patch to fix the same.
>
> Reviewed-by: Dave Young <dyoung@redhat.com>
> Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Reviewed-by: Pratyush Anand <panand@redhat.com>
> ---
> Changelog v1:
> - Moved the check right after fopen
>
> kexec/fs2dt.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/kexec/fs2dt.c b/kexec/fs2dt.c
> index 6ed2399759cf..5ba3ec0fa65c 100644
> --- a/kexec/fs2dt.c
> +++ b/kexec/fs2dt.c
> @@ -524,6 +524,9 @@ static void dt_copy_old_root_param(void)
> strcpy(filename, pathname);
> strcat(filename, "bootargs");
> fp = fopen(filename, "r");
> + if (!fp)
> + return;
> +
> if (fp) {
> if (getline(&last_cmdline, &len, fp) == -1)
> die("unable to read %s\n", filename);
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2016-09-29 8:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 7:59 [PATCH v2] kexec/fs2dt: Check for NULL pointer in dt_copy_old_root_param() Madhavan Srinivasan
2016-09-29 8:20 ` Simon Horman
2016-09-29 8:29 ` Dave Young
2016-09-29 8:24 ` Pratyush Anand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9c0bc6c-c9df-0ed9-8774-20821a8edf26@redhat.com \
--to=panand@redhat.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=maddy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).