From: Simon Horman <horms@kernel.org>
To: Zhu Yanjun <yanjun.zhu@linux.dev>
Cc: kexec@lists.infradead.org, linux-mm@kvack.org, graf@amazon.com,
rppt@kernel.org, changyuanl@google.com,
akpm@linux-foundation.org, bhe@redhat.com
Subject: Re: [PATCH 1/1] kexec: Use %pe format specifier for error pointer printing
Date: Tue, 21 Oct 2025 10:41:31 +0100 [thread overview]
Message-ID: <aPdVSyLRKeRN3i6z@horms.kernel.org> (raw)
In-Reply-To: <20251016200320.4179702-1-yanjun.zhu@linux.dev>
On Thu, Oct 16, 2025 at 08:03:20PM +0000, Zhu Yanjun wrote:
> Make pr_xxx() call to use the %pe format specifier instead of %d.
> The %pe specifier prints a symbolic error string (e.g., -ENOMEM,
> -EINVAL) when given an error pointer created with ERR_PTR(err).
>
> This change enhances the clarity and diagnostic value of the error
> message by showing a descriptive error name rather than a numeric
> error code.
>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
Thanks,
This looks good to me, even though I note that this file
has moved in linux-next.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-10-21 9:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 20:03 [PATCH 1/1] kexec: Use %pe format specifier for error pointer printing Zhu Yanjun
2025-10-21 9:41 ` Simon Horman [this message]
2025-10-21 13:56 ` Zhu Yanjun
2025-10-21 22:42 ` yanjun.zhu
2025-11-01 13:49 ` Pasha Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPdVSyLRKeRN3i6z@horms.kernel.org \
--to=horms@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=changyuanl@google.com \
--cc=graf@amazon.com \
--cc=kexec@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox