Re: [PATCHv2 1/2] kernel/kexec: Change the prototype of kimage_map_segment()

Baoquan He
2025-12-03T08:06:49Z

On 12/03/25 at 12:22pm, Pingfan Liu wrote:
> Hi Baoquan,
>
> On Wed, Nov 26, 2025 at 9:10 AM Baoquan He <bhe@redhat.com> wrote:
> >
> > Hi Pingfan,
> >
> > On 11/06/25 at 02:59pm, Pingfan Liu wrote:
> > > The kexec segment index will be required to extract the corresponding
> > > information for that segment in kimage_map_segment(). Additionally,
> > > kexec_segment already holds the kexec relocation destination address and
> > > size. Therefore, the prototype of kimage_map_segment() can be changed.
> >
> > Because no cover letter, I just reply here.
> >
> > I am testing code of (tag: next-20251125, next/master) on arm64 system.
> > I saw your two patches are already in there. When I used kexec reboot
> > as below, I still got the warning message during ima_kexec_post_load()
> > invocation.
> >
> > ====================
> > kexec -d -l /boot/vmlinuz-6.18.0-rc7-next-20251125 --initrd /boot/initramfs-6.18.0-rc7-next-20251125.img --reuse-cmdline
> > ====================
> >
>
> "I have used the Fedora 42 server and its config file to reproduce the
> issue you reported here. However, I cannot reproduce it with my patch.
> Instead, if I revert my patch, I can see the warning again.
>
> I suspect that you observed the warning thrown by the original Fedora
> 42 kernel instead of mine.
>
> You need to kexec-reboot into vmlinuz-6.18.0-rc7-next-20251125, and at
> that point, try 'kexec -d -l /boot/vmlinuz-6.18.0-rc7-next-20251125
> --initrd /boot/initramfs-6.18.0-rc7-next-20251125.img
> --reuse-cmdline'.
>
> If this is a false alarm, I will rewrite the commit log and send out v3.

Thanks for checking, Pingfan. I am not quite sure if I did wrong
operation on the machine. Since you are testing the same machine and the
same linux-next code, and it still can'e be reproduced, it should be
from my mistake. Then please go ahead posting v3.

Thanks
Baoquan