public inbox for kexec@lists.infradead.org
 help / color / mirror / Atom feed
From: Dave Young <dyoung@redhat.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
	kexec@lists.infradead.org, x86@kernel.org
Subject: [PATCH] efi/x86-stub: store acpi_rsdp_addr in bootparams
Date: Tue, 17 Feb 2026 16:04:14 +0800	[thread overview]
Message-ID: <aZQg_tRQmdKNadCg@darkstar.users.ipa.redhat.com> (raw)

Kernel panic occurs during a kexec reboot when EFI runtime services
are not enabled in the first kernel. The issue is that the second
kernel cannot find the ACPI RSDP address during boot.

In legacy boot, the acpi_rsdp_addr is set in early x86 boot code.
However, kernel decompression has moved to the EFI stub for EFI boot.
Therefore, the x86 EFI stub must also be updated to store the
acpi_rsdp_addr in the boot parameters to ensure the kexec kernel
can find it.

(Note: If the pre-kexec kernel was itself a kexec boot, the later kexec
reboot will still utilize the legacy decompressor path, so the original
code remains functional though some cleanups can be done later.)

Signed-off-by: Dave Young <dyoung@redhat.com>
---
 drivers/firmware/efi/libstub/x86-stub.c |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

Index: linux-x86/drivers/firmware/efi/libstub/x86-stub.c
===================================================================
--- linux-x86.orig/drivers/firmware/efi/libstub/x86-stub.c
+++ linux-x86/drivers/firmware/efi/libstub/x86-stub.c
@@ -484,6 +484,22 @@ static void setup_quirks(struct boot_par
 	}
 }
 
+static void setup_acpi_rsdp(struct boot_params *boot_params)
+{
+	u64 rsdp_addr;
+
+	/*
+	 * Search EFI system tables for RSDP. Preferred is ACPI_20_TABLE_GUID to
+	 * ACPI_TABLE_GUID because it has more features.
+	 */
+	rsdp_addr = (u64)get_efi_config_table(ACPI_20_TABLE_GUID);
+	if (!rsdp_addr)
+		rsdp_addr = (u64)get_efi_config_table(ACPI_TABLE_GUID);
+
+	if (rsdp_addr)
+		boot_params->acpi_rsdp_addr = rsdp_addr;
+}
+
 static void setup_graphics(struct boot_params *boot_params)
 {
 	struct screen_info *si = memset(&boot_params->screen_info, 0, sizeof(*si));
@@ -1017,6 +1033,8 @@ void __noreturn efi_stub_entry(efi_handl
 
 	setup_graphics(boot_params);
 
+	setup_acpi_rsdp(boot_params);
+
 	setup_efi_pci(boot_params);
 
 	setup_quirks(boot_params);



             reply	other threads:[~2026-02-17  8:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-17  8:04 Dave Young [this message]
2026-02-17  8:10 ` [PATCH] efi/x86-stub: store acpi_rsdp_addr in bootparams Ard Biesheuvel
2026-02-17  8:19   ` Dave Young
2026-02-17  9:20     ` Ard Biesheuvel
2026-02-17 10:01       ` Dave Young
2026-02-17 10:26         ` Ard Biesheuvel
2026-02-17 10:29           ` Dave Young
2026-02-17 18:14             ` Ard Biesheuvel
2026-02-19  6:57               ` Dave Young
2026-02-19  7:21                 ` Ard Biesheuvel
2026-02-19  7:03         ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZQg_tRQmdKNadCg@darkstar.users.ipa.redhat.com \
    --to=dyoung@redhat.com \
    --cc=ardb@kernel.org \
    --cc=kexec@lists.infradead.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox