From: Bhupesh Sharma <bhsharma@redhat.com>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>,
catalin.marinas@arm.com, will.deacon@arm.com, robh+dt@kernel.org,
frowand.list@gmail.com
Cc: james.morse@arm.com, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] libfdt: define UINT32_MAX in libfdt_env.h
Date: Thu, 5 Dec 2019 02:03:27 +0530 [thread overview]
Message-ID: <aa35893d-fadc-be2a-1295-a986ced017fe@redhat.com> (raw)
In-Reply-To: <20191114051510.17037-2-takahiro.akashi@linaro.org>
Hi Akashi,
On 11/14/2019 10:45 AM, AKASHI Takahiro wrote:
> In the implementation of kexec_file_load-based kdump for arm64,
> fdt_appendprop_addrrange() will be used, but fdt_addresses.c
> will fail to compile due to missing UINT32_MAX.
>
> So just define it in libfdt_env.h.
>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Frank Rowand <frowand.list@gmail.com>
> ---
> include/linux/libfdt_env.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/libfdt_env.h b/include/linux/libfdt_env.h
> index edb0f0c30904..9ca00f11d9b1 100644
> --- a/include/linux/libfdt_env.h
> +++ b/include/linux/libfdt_env.h
> @@ -3,6 +3,7 @@
> #define LIBFDT_ENV_H
>
> #include <linux/kernel.h> /* For INT_MAX */
> +#include <linux/limits.h> /* For UINT32_MAX */
> #include <linux/string.h>
>
> #include <asm/byteorder.h>
> @@ -11,6 +12,8 @@ typedef __be16 fdt16_t;
> typedef __be32 fdt32_t;
> typedef __be64 fdt64_t;
>
> +#define UINT32_MAX U32_MAX
> +
> #define fdt32_to_cpu(x) be32_to_cpu(x)
> #define cpu_to_fdt32(x) cpu_to_be32(x)
> #define fdt64_to_cpu(x) be64_to_cpu(x)
>
With following upstream patches accepted already in Linus's tree (see
[0] and [1]), so we can drop this patch from the v3:
[0] 26ed19adbab1 ("libfdt: reduce the number of headers included from
libfdt_env.h")
[1] a8de1304b7df ("libfdt: define INT32_MAX and UINT32_MAX in libfdt_env.h")
Thanks,
Bhupesh
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2019-12-04 20:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 5:15 [PATCH v2 0/3] arm64: kexec_file: add kdump AKASHI Takahiro
2019-11-14 5:15 ` [PATCH v2 1/3] libfdt: define UINT32_MAX in libfdt_env.h AKASHI Takahiro
2019-12-04 20:33 ` Bhupesh Sharma [this message]
2019-11-14 5:15 ` [PATCH v2 2/3] libfdt: include fdt_addresses.c AKASHI Takahiro
2019-11-14 5:15 ` [PATCH v2 3/3] arm64: kexec_file: add crash dump support AKASHI Takahiro
2019-12-04 20:44 ` Bhupesh Sharma
2019-12-16 1:43 ` AKASHI Takahiro
2019-12-04 20:26 ` [PATCH v2 0/3] arm64: kexec_file: add kdump Bhupesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa35893d-fadc-be2a-1295-a986ced017fe@redhat.com \
--to=bhsharma@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=frowand.list@gmail.com \
--cc=james.morse@arm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=takahiro.akashi@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox