From: Chris Clayton <chris2553@googlemail.com>
To: Baoquan He <bhe@redhat.com>, Simon Horman <horms@verge.net.au>
Cc: kexec@lists.infradead.org
Subject: Re: kexec: fix for "Unhandled rela relocation: R_X86_64_PLT32" error
Date: Mon, 20 Aug 2018 16:12:02 +0100 [thread overview]
Message-ID: <aabec0ea-6611-dc95-3f12-391469790d53@googlemail.com> (raw)
In-Reply-To: <20180820122131.GB4113@MiWiFi-R3L-srv>
On 20/08/2018 13:21, Baoquan He wrote:
> Hi Chris,
>
> On 08/20/18 at 08:17pm, Baoquan He wrote:
>> In response to a change in binutils, commit b21ebf2fb4c
>> (x86: Treat R_X86_64_PLT32 as R_X86_64_PC32) was applied to
>> the linux kernel during the 4.16 development cycle and has
>> since been backported to earlier stable kernel series. The
>> change results in the failure message in $SUBJECT when
>> rebooting via kexec.
>>
>> Fix this by replicating the change in kexec.
>>
OK.
>> Signed-off-by: Chris Clayton <chris2553@googlemail.com>
>
> I adjusted the patch log a little bit, you have tested it on upstream
> kernel, right?
>
At the time of my original message (25 July 2018), 4.18.0-rc6+ was the latest upstream. I tested my change on that and
on the latest stable 4.14 series kernel, which was 4.14.57. I've just tested it with 4.18.3 and 4.14.65 and it works
fine. I don't have a 4.19 development kernel installed at the moment - I'm busy with other stuff.
Chris
> Thanks
> Baoquan
>
>> ---
>> kexec/arch/x86_64/kexec-elf-rel-x86_64.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/kexec/arch/x86_64/kexec-elf-rel-x86_64.c b/kexec/arch/x86_64/kexec-elf-rel-x86_64.c
>> index 7fdde73..db85b44 100644
>> --- a/kexec/arch/x86_64/kexec-elf-rel-x86_64.c
>> +++ b/kexec/arch/x86_64/kexec-elf-rel-x86_64.c
>> @@ -79,6 +79,7 @@ void machine_apply_elf_rel(struct mem_ehdr *UNUSED(ehdr),
>> goto overflow;
>> break;
>> case R_X86_64_PC32:
>> + case R_X86_64_PLT32:
>> *(uint32_t *)location = value - address;
>> break;
>> default:
>> --
>> 2.13.6
>>
>>
>> _______________________________________________
>> kexec mailing list
>> kexec@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/kexec
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2018-08-20 15:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 8:46 (Possible) fix for "Unhandled rela relocation: R_X86_64_PLT32" error Chris Clayton
2018-08-20 8:37 ` Baoquan He
2018-08-20 11:00 ` kexec: " Chris Clayton
2018-08-20 12:17 ` Baoquan He
2018-08-20 12:21 ` Baoquan He
2018-08-20 15:12 ` Chris Clayton [this message]
2018-08-20 22:38 ` Baoquan He
2018-08-21 11:21 ` Bhupesh Sharma
2018-08-24 7:56 ` Simon Horman
2018-08-24 14:57 ` Baoquan He
2018-08-24 15:08 ` Bhupesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aabec0ea-6611-dc95-3f12-391469790d53@googlemail.com \
--to=chris2553@googlemail.com \
--cc=bhe@redhat.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox