From: "chenhaixiang (A)" <chenhaixiang3@huawei.com>
To: Simon Horman <horms@kernel.org>
Cc: "kexec@lists.infradead.org" <kexec@lists.infradead.org>,
Louhongxiang <louhongxiang@huawei.com>,
"wangbin (A)" <wangbin224@huawei.com>,
"yangyanchao (C)" <yangyanchao6@huawei.com>
Subject: Re: [PATCH] Before adding to usablemem_rgns, check if the memory range is already included.
Date: Mon, 21 Oct 2024 11:57:44 +0000 [thread overview]
Message-ID: <abdfbc8ef5374d3897b5cd7a60341550@huawei.com> (raw)
> > When kexec_iomem_for_each_line() reads from /proc/iomem, concurrent
> > modifications to /proc/iomem may lead to usablemem_rgns recording
> > duplicate Crash kernel segments.
> > This can result in the number of retrieved Crash kernel segments
> > exceeding CRASH_MAX_RESERVED_RANGES, triggering a realloc of the
> > crash_reserved_mem in usablemem_rgns, which could crash the process.
> > We should ensure that each range added to usablemem_rgns is unique to
> > prevent these issues.
>
> Thanks Chen Haixiang,
>
> This looks reasonable to me, but, as per Kernel submissions, I will need an
> Signed-off-by line [1] in order to apply this patch.
>
> [1]
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign
> -your-work-the-developer-s-certificate-of-origin
Thank you for your feedback, and I apologize for missing the Signed-off-by line. I'll resend the patch v2 with the required Signed-off-by line shortly.
Best regards,
Chen Haixiang
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next reply other threads:[~2024-10-21 11:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 11:57 chenhaixiang (A) [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-10-17 12:38 [PATCH] Before adding to usablemem_rgns, check if the memory range is already included Chen Haixiang
2024-10-21 10:25 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abdfbc8ef5374d3897b5cd7a60341550@huawei.com \
--to=chenhaixiang3@huawei.com \
--cc=horms@kernel.org \
--cc=kexec@lists.infradead.org \
--cc=louhongxiang@huawei.com \
--cc=wangbin224@huawei.com \
--cc=yangyanchao6@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox