From: Mukesh Pilaniya <mpilaniy@redhat.com>
To: Andreas Kemnade <andreas@kemnade.info>,
kexec@lists.infradead.org,
Andrew Morton <akpm@linux-foundation.org>,
Baoquan He <baoquan.he@linux.dev>,
Mike Rapoport <rppt@kernel.org>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
Pratyush Yadav <pratyush@kernel.org>,
Simon Horman <horms@kernel.org>
Cc: Russell King <linux@armlinux.org.uk>, j.neuschaefer@gmx.net
Subject: Re: [PATCH kexec-tools] arm-zImage: prepare for more malloc requirements of zstd
Date: Mon, 31 Aug 2026 15:29:23 +0530 [thread overview]
Message-ID: <ac2029c5-1069-4e8b-9b09-29150f133055@redhat.com> (raw)
In-Reply-To: <20260829094607.689485-1-andreas@kemnade.info>
Hi Andreas,
On 29/08/26 3:16 pm, Andreas Kemnade wrote:
> As there are plans for zstd in zImage for ARM, which requires more malloc
> size fo, decompression, increase the space.
>
_size fo_ looks like a truncated _size for_ .
The high-level changes look good to me. Feel free to add:
Acked-by: Mukesh Pilaniya <mpilaniy@redhat.com>
> References:
> https://lore.kernel.org/lkml/ZFDMRst2O+RJUYuu@shell.armlinux.org.uk/#t
> https://lore.kernel.org/lkml/20260828-zstd2-v2-0-4d9ce7150877@kemnade.info/
>
> Suggested-by: Russell King (Oracle) <linux@armlinux.org.uk>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> kexec/arch/arm/kexec-zImage-arm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kexec/arch/arm/kexec-zImage-arm.c b/kexec/arch/arm/kexec-zImage-arm.c
> index 8b474dd..97db7f3 100644
> --- a/kexec/arch/arm/kexec-zImage-arm.c
> +++ b/kexec/arch/arm/kexec-zImage-arm.c
> @@ -663,9 +663,9 @@ int zImage_arm_load(int argc, char **argv, const char *buf, off_t len,
>
> /*
> * The zImage length does not include its stack (4k) or its
> - * malloc space (64k). Include this.
> + * malloc space (128k). Include this.
> */
> - len += 0x11000;
> + len += 0x21000;
>
> dbgprintf("zImage requires 0x%08llx bytes\n", (unsigned long long)len);
>
--
Regards,
Mukesh Pilaniya
next prev parent reply other threads:[~2026-08-31 9:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-29 9:46 [PATCH kexec-tools] arm-zImage: prepare for more malloc requirements of zstd Andreas Kemnade
2026-08-31 9:59 ` Mukesh Pilaniya [this message]
2026-08-31 10:31 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac2029c5-1069-4e8b-9b09-29150f133055@redhat.com \
--to=mpilaniy@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andreas@kemnade.info \
--cc=baoquan.he@linux.dev \
--cc=horms@kernel.org \
--cc=j.neuschaefer@gmx.net \
--cc=kexec@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox