From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@alien8.de>
Cc: "x86@kernel.org" <x86@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"'Peter Zijlstra'" <peterz@infradead.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Michal Hocko" <mhocko@kernel.org>,
"平松雅巳 / HIRAMATU，MASAMI" <masami.hiramatsu.pt@hitachi.com>,
"Ingo Molnar" <mingo@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"河合英宏 / KAWAI，HIDEHIRO" <hidehiro.kawai.ez@hitachi.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Vivek Goyal" <vgoyal@redhat.com>
Subject: Re: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option
Date: Tue, 13 Oct 2015 22:19:33 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1510132210590.25029@nanos> (raw)
In-Reply-To: <20151005082704.GA23259@nazgul.tnic>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1357 bytes --]
Borislav,
On Mon, 5 Oct 2015, Borislav Petkov wrote:
> On Mon, Oct 05, 2015 at 02:03:58AM +0000, 河合英宏 / KAWAI，HIDEHIRO wrote:
> > That's different from my point of view. I'm not going to pass
> > some data from the first kernel to the second kernel. I'm just going to
> > provide a configurable option for the second kernel to users.
>
> Dude, WTF?! You're adding a kernel command line which is supposed to
> be used *only* by the kdump kernel. But nooo, it is there in the open
> and visible to people. And anyone can type it in during boot. AND THAT
> SHOULDN'T BE POSSIBLE IN THE FIRST PLACE!
>
> This information is strictly for the kdump kernel - it shouldn't be a
> generic command line option. How hard it is to understand that simple
> fact?!
Calm down!
Disabling that NMI in the first kernel is not going to make the world
explode. We have enough command line options a user can type in, which
are way worse than that one. If some "expert" types nonsense on the
first kernel command line, then it's none of our problems, really.
If Kawai would have marked that option as a debug feature, this
discussion would have probably never happened.
Aside of that, the best way to hand in options for the kdump kernel is
the command line. We have an existing interface for that.
Let's move on. Nothing to see here.
Thanks,
tglx
[-- Attachment #2: Type: text/plain, Size: 143 bytes --]
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2015-10-13 20:21 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 11:28 [V4 PATCH 0/4] Fix race issues among panic, NMI and crash_kexec Hidehiro Kawai
2015-09-25 11:28 ` [V4 PATCH 1/4] panic/x86: Fix re-entrance problem due to panic on NMI Hidehiro Kawai
2015-09-25 12:13 ` 河合英宏 / KAWAI，HIDEHIRO
2015-09-30 11:26 ` Peter Zijlstra
2015-10-01 1:02 ` 河合英宏 / KAWAI，HIDEHIRO
2015-09-25 11:28 ` [V4 PATCH 2/4] panic/x86: Allow cpus to save registers even if they are looping in NMI context Hidehiro Kawai
2015-09-30 11:50 ` Peter Zijlstra
2015-10-01 1:43 ` 河合英宏 / KAWAI，HIDEHIRO
2015-09-25 11:28 ` [V4 PATCH 3/4] kexec: Fix race between panic() and crash_kexec() called directly Hidehiro Kawai
2015-09-28 3:53 ` kbuild test robot
2015-09-28 7:08 ` 河合英宏 / KAWAI，HIDEHIRO
2015-09-30 11:53 ` Peter Zijlstra
2015-10-01 2:04 ` 河合英宏 / KAWAI，HIDEHIRO
2015-09-28 4:02 ` kbuild test robot
2015-09-28 4:46 ` 河合英宏 / KAWAI，HIDEHIRO
2015-09-25 11:28 ` [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option Hidehiro Kawai
2015-09-30 11:55 ` Peter Zijlstra
2015-10-01 2:33 ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-01 6:27 ` Peter Zijlstra
2015-10-01 7:01 ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-01 8:43 ` Borislav Petkov
2015-10-01 10:24 ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-01 11:01 ` Borislav Petkov
2015-10-02 0:58 ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-02 7:47 ` Borislav Petkov
2015-10-05 2:03 ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-05 8:27 ` Borislav Petkov
2015-10-05 9:21 ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-05 10:14 ` Borislav Petkov
2015-10-13 11:55 ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-13 20:19 ` Thomas Gleixner [this message]
2015-10-14 13:54 ` Ingo Molnar
2015-10-16 1:58 ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-13 20:22 ` Thomas Gleixner
2015-10-14 3:39 ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-14 7:25 ` Thomas Gleixner
2015-10-16 2:02 ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-27 8:46 ` Baoquan He
2015-10-27 9:01 ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-27 9:06 ` 'Baoquan He'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1510132210590.25029@nanos \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=ebiederm@xmission.com \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mhocko@kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox