From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B73EC88E75 for ; Fri, 18 Sep 2026 08:04:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Qk5GBb8q71h0OTX0FejewQwnd8QBnXRYigWqP30wroM=; b=xe7lI1mStGsS2Ots5sD4hVl4LV Vq7v1du/DQwPZ3Llrfjzj23l2P33m67PZUh6OJxnPdAFpWM/DTx+yTWCNETX370vl55mEh2ttz/9o iJ5/yy+Bojll40u3tSZMH6zu6kSx0zlIYIEJ+UEXqwZb6EYvw4Czv7VzLGR1Sp/IOFq+de/I8J56p gtv3Wb/Qs1eESRglJA4kfnhdpJviabKPj566Sh3gMS9osL9H786B/xoVsvh6pAmh6vO6EJRqZ6AFd fT2HBtkDo9pUsEopAoQcKevDA6EBfaldimXWb8iL29CDFYPMlUBA+y8JOetdt9973OCAsfujGOl15 q6ciePyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7TaP-0000000DkuL-2CSX; Fri, 18 Sep 2026 08:04:45 +0000 Received: from out-89.mta0.migadu.com ([2001:41d0:1004:224b::59] helo=mta0.migadu.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7TaK-0000000DksE-2Eiv for kexec@lists.infradead.org; Fri, 18 Sep 2026 08:04:44 +0000 X-Envelope-To: kexec@lists.infradead.org DKIM-Signature: a=rsa-sha256; bh=aMbcna5jLWNAqx3Ry2+7V7gyF2U3dGtOqExnDesb2fI=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1789718677; v=1; x=1790323477; b=GM3c5EaoyflUF7CWwtfTtu5IXbmYDA4S9MecRd3maV8jL/5eBAPLJhtz+IIeC27Bg8YeXroG sGJ10OP8XciAgkKoXHv3C/Q9rbV6R0sQRw623xarvpsk0LTGkyrGtTbGwOkNou2kuzaoTXZarC3 ePWlB0u1vXPB9v/SPwZ13Bfk= X-Envelope-To: kexec@lists.infradead.org Received: by mta12.migadu.com with ESMTPS id e28637c2a9188785; Fri, 18 Sep 2026 08:04:36 +0000 X-Mizu-Trace-ID: e28637c2a9188785 X-Migadu-Flow: FLOW_OUT Date: Fri, 18 Sep 2026 16:04:33 +0800 From: Baoquan He To: Wandun Chen Cc: catalin.marinas@arm.com, will@kernel.org, chenhuacai@kernel.org, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, tglx@kernel.org, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, robh@kernel.org, saravanak@kernel.org, akpm@linux-foundation.org, rppt@kernel.org, pasha.tatashin@soleen.com, pratyush@kernel.org, m.szyprowski@samsung.com, mark.rutland@arm.com, kernel@xen0n.name, alex@ghiti.fr, hpa@zytor.com, ruirui.yang@linux.dev, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-mm@kvack.org, iommu@lists.linux.dev Subject: Re: [PATCH v6 05/10] crash_core: replace for_each_mem_range() with for_each_mem_region() Message-ID: References: <20260902073116.802752-1-chenwandun1@gmail.com> <20260902073116.802752-6-chenwandun1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260902073116.802752-6-chenwandun1@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260918_010442_187305_6618B18C X-CRM114-Status: GOOD ( 17.43 ) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org On 09/02/26 at 03:31pm, Wandun Chen wrote: > From: Wandun Chen > > for_each_mem_range() skips MEMBLOCK_NOMAP regions implicitly. Switch the > weak defaults to for_each_mem_region(), which exposes struct > memblock_region and per-region flags, and filter NOMAP regions explicitly > via the new crash_should_skip_region() helper. This prepares for a > subsequent patch to extend the skip filter. > > No functional change. > > Signed-off-by: Wandun Chen > Tested-by: Meijing Zhao > --- > kernel/crash_core.c | 25 +++++++++++++++++-------- > 1 file changed, 17 insertions(+), 8 deletions(-) Acked-by: Baoquan He > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > index 3adee1ae120c..bd64cf585795 100644 > --- a/kernel/crash_core.c > +++ b/kernel/crash_core.c > @@ -270,6 +270,12 @@ int crash_prepare_elf64_headers(struct crash_mem *mem, int need_kernel_map, > return 0; > } > > +/* Exclude NOMAP regions from the vmcore. */ > +static bool crash_should_skip_region(struct memblock_region *reg) > +{ > + return memblock_is_nomap(reg); > +} > + > static struct crash_mem *alloc_cmem(unsigned int nr_ranges) > { > struct crash_mem *cmem; > @@ -285,22 +291,25 @@ static struct crash_mem *alloc_cmem(unsigned int nr_ranges) > unsigned int __weak arch_get_system_nr_ranges(void) > { > unsigned int nr_ranges = 2 + crashk_cma_cnt; /* crashk_res + crashk_low_res, +CMA splits */ > - phys_addr_t start, end; > - u64 i; > + struct memblock_region *reg; > > - for_each_mem_range(i, &start, &end) > + for_each_mem_region(reg) { > + if (crash_should_skip_region(reg)) > + continue; > nr_ranges++; > + } > return nr_ranges; > } > > int __weak arch_crash_populate_cmem(struct crash_mem *cmem) > { > - phys_addr_t start, end; > - u64 i; > + struct memblock_region *reg; > > - for_each_mem_range(i, &start, &end) { > - cmem->ranges[cmem->nr_ranges].start = start; > - cmem->ranges[cmem->nr_ranges].end = end - 1; > + for_each_mem_region(reg) { > + if (crash_should_skip_region(reg)) > + continue; > + cmem->ranges[cmem->nr_ranges].start = reg->base; > + cmem->ranges[cmem->nr_ranges].end = reg->base + reg->size - 1; > cmem->nr_ranges++; > } > return 0; > -- > 2.43.0 >