From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE95C606A31D for ; Thu, 22 Oct 2026 02:57:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=qw5DLDC2; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=pyFKK/+4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9EhJunI31x30V5twb29p5JvXR/ZnOh8avGc16eTeBG0=; b=qw5DLDC2FLxYEBqqqkSZLTUeY/ YRUErQObN1BYU1U7BD6aZ3u+tDSD48nY/JlQEcA+mRhB+6Hy9+VNJ4QRrCisJWFb0saUFGDOPohP9 nkjQ/15LYMHfX7Hw/9R77DOLtHWBhyUeTfCaYpaI3mLdHKTrNWiQL+R0VdNM/RQTB+TonK9Ov1gU2 yQ8FFZ+GaF8Ys0gCrSFvpFBlfY4po+w1j40KCr8JuqFHA4p2jffJR/E/zG+8FUBCT6ONXp/trkiEp nFCI277doJzwcyOMiTeuJ10y/Uzy98w2DiJzETlzJlrCpj8SzLJq/7+koqmMR/5fPiHpig7JIwAAq Com6JZ0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xJj03-0000000DFFg-3L4f; Thu, 22 Oct 2026 02:57:51 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xJizz-0000000DFF0-1hXO for kexec@lists.infradead.org; Thu, 22 Oct 2026 02:57:48 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-2e915887d9dso8118805ad.1 for ; Wed, 21 Oct 2026 19:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1792637866; x=1793242666; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=9EhJunI31x30V5twb29p5JvXR/ZnOh8avGc16eTeBG0=; b=pyFKK/+4/ebrAtp3dbaTY+qsmEhwkNCEQ9b4yVpqwFg2ap5tZKpjujQroA+dpDqywI U6yv3MhUflSQPZ7/Tg9OQigOWobvd9VGqzZeO8GbwnMSDFjSyy/bT3/KfXBcyhZt1bFq 5M8Kum9Ty9+lA1eqZagfQaZoMsKmOqqzYlFiOb3oTuVzpJqwVflswa+njG6ae7f1fQX6 FE1SsG80goc+3PpqSLlJEB29Ni8NMVTlWc8c+RFYEE9a+RD7k/WYbhs9twOiPdDJYULx XZbdU8W6C25DTuLskCtKtIDr1J+wiT12lSYkBSwG6jxxE1QggAI1p8dnNkCz7tAHWlSJ Htew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792637866; x=1793242666; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=9EhJunI31x30V5twb29p5JvXR/ZnOh8avGc16eTeBG0=; b=xqAS47tRg/r6mutsYepyv02CzpLtMWj3liznZjNumk+x61grW+mb00EoeZKdrOWf11 gQkncjz3BYuPBLj46rkxibTsQ5BxkGlvMmrE3je10Rl0I/lNCxLj21xJy9qiqQqHcUGc I25TWmfLIIEF9jAw1Rvcyb/5L9oecXOoBRA9QH7bItAnzk+Rais2PlbeP3jEc71BOGrR 0OEHlmXtIPOhaMZGRtQr+1QDkVsep+pNB8i7pnIu3JFu4K/zpNKWRSTuSIZ8G+JSfJMq 6j0BExnfWNCN242F0ueFF0Yj39+YN+rXwpSylAIFl03bpKv1KUW9Vy2OiRwo79cO8yuy Rf9g== X-Forwarded-Encrypted: i=1; AKwUvBxEZ4r5TwljErWSXmrMUAC908qQq0mmqIGuYoUxUjV/BNglYW7i2XS4y2+7Xn/8n2Kl2GlutQ==@lists.infradead.org X-Gm-Message-State: AFq9FYLti9OeMt/aLmGqiL+6GJ4gpqCIxh+c6zVlcAQjy+sxlmZcV/za G2mD+ONT0SIFEBplT0KIfz9FgGojgOpG6q+f0IUflPsiqdOQEIW4k/sKScuLgtcC0Q== X-Gm-Gg: AYBFou2WAUqLSWZC5LdS2qxMDbphpPvgFS6iYyZ9PLsM6BiFzXjLiDvsEUNYX2+/w06 vFUtVNT/oC/nuF44KxwUy9MYyAR8fmoYpN0z+zUTgxmh1ab10iVntvmrdMgB621Zodqum58wSkI jKxjPjzzR1NMuMWE7Gu2KsgTWZpItT39VCk1JGdjScpJksgTGfxJCI4NvZU200egOiI9rk7r4WB OcB8tzDq81sFy2ukM4oiaBQ7T+J8GOvtFZR2HZkHRALmGv7RZx1LaTt9DOYb4tEC13ofF7wrXFu sDjzVZxCCPoK8p8jfd1CNB8BbNS9Gv+W4UL3Tns8TAkoa5ViDihGH7SY7/ci5GXgQayM4D66RFo tG4px5yrctuNnUzgUc82blda3JwAE/ZWhgq2EgbKrxrX7hp8LpGkgLPfhJ+ZLPp+uC/Pgwawo38 muN39KpJmW+zXLls6pXlXs9MAUBJiWRy+lnVJjOZm1zSKLGaBfX6MuwxHm1D2o7Q8QNaS6D0tb1 Vun52JcdYJmAE5Hpnh3ke9ct4f5kd/nc/RE/t9V7N5B2rYBiLmwF/oSd72bzxMk9qIhJqq35epW nj5+adPZP+CdIGNG X-Received: by 2002:a17:90b:3ec8:b0:3ac:adce:60ad with SMTP id 98e67ed59e1d1-3ad86e96c9emr2886416a91.22.1792637865925; Wed, 21 Oct 2026 19:57:45 -0700 (PDT) Received: from google.com (64.75.127.34.bc.googleusercontent.com. [34.127.75.64]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ada495315dsm2092370a91.15.2026.10.21.19.57.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Oct 2026 19:57:45 -0700 (PDT) Date: Thu, 22 Oct 2026 02:57:41 +0000 From: David Matlack To: Pasha Tatashin Cc: tarunsahu@google.com, Andrew Morton , joro@8bytes.org, Mike Rapoport , Pratyush Yadav , maz@kernel.org, arnd@arndb.de, jgg@nvidia.com, robin.murphy@arm.com, loganodell@google.com, oupton@kernel.org, kevin.tian@intel.com, alex@shazbot.org, dwmw2@infradead.org, pbonzini@redhat.com, seanjc@google.com, will@kernel.org, Alexander Graf , Bjorn Helgaas , baolu.lu@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, sagis@google.com, linux-mm@kvack.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, linux-pci@vger.kernel.org, kexec@lists.infradead.org, skhawaja@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 3/4] liveupdate: Replace compatibility string with a 2-bit pair feature header Message-ID: References: <20261021152527.375070-1-tarunsahu@google.com> <20261021152527.375070-4-tarunsahu@google.com> <9huzecdi6go0.fsf@tarunix.c.googlers.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261021_195747_442526_69EF55D9 X-CRM114-Status: GOOD ( 41.74 ) X-Spam-Score: -17.6 (-----------------) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" X-Spam-Status: No, score=-13.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 2026-10-21 09:26 PM, Pasha Tatashin wrote: > On Wed, Oct 21, 2026 at 7:28 PM David Matlack wrote: > > > > On 2026-10-21 02:50 PM, Pasha Tatashin wrote: > > > On Wed, Oct 21, 2026 at 2:47 PM David Matlack wrote: > > > > > > > > On Wed, Oct 21, 2026 at 11:40 AM wrote: > > > > > > > > > > Pasha Tatashin writes: > > > > > > > > > > > On Wed, Oct 21, 2026 at 11:25 AM Tarun Sahu wrote: > > > > > >> > > > > > >> LUO and its file handlers validate handed-over state with monolithic > > > > > >> compatibility strings ("luo-v5", "memfd-v2"). Any change to a serialized > > > > > >> structure, even an optional additive one, must bump the string, which > > > > > >> breaks live update between adjacent kernels. Replace the string in > > > > > >> struct luo_ser with a feature header, so that the target kernel can > > > > > >> accept or reject the source kernel state per feature. > > > > > >> > > > > > >> struct luo_feature_hdr is a fixed 128-byte header: the serialized > > > > > > > > > > > > This patch is all wrong; 128 bytes is far too large. For every _ser > > > > > > struct, we only need 8 bytes instead. > > > > > > > > > > NOO, It is not. It is intended to avoid complex mess with unnecessary > > > > > over-engineering. > > > > > > 128-byte per serialized struct is not starter. > > > > > > > > > > > > > > > > > > > > The first 4 bytes are the size, and the next 4 bytes are flags (i.e., > > > > > > 30 feature flags + 2 reserved bits for flags extension). The last two > > > > > > bits of the flags indicate whether an extended flags field is present. > > > > > > Each extended flags field is 8 bytes, and its last two bits indicate > > > > > > that yet another extended flags field follows. > > > > > > > > > > If we will have dynamic extension of flags, Think about this. > > > > > > > > To support dynamic extensions in a backward compatible way you want > > > > something like this: > > > > > > > > struct luo_feature_hdr { > > > > size > > > > flags > > > > > > __u32 size > > > __u32 flags > > > > > > > extensions // offset of first luo_feature_extensions (or 0) > > > > > > __u64 extensions[0] --> but the size should be specificed in > > > declaration macro that I showed in the next patch. > > > > I think you may have misunderstood what I meant. In my proposal, > > extensions is an offset to the first extension, not an array of > > extensions that immediately follow the header. > > > > If the extensions immediately follow the header, then the number of > > extensions is baked into the struct layout. Every field after them sits > > at an offset that depends on how many extensions there are. If we ever > > need one more extension, all the fields shift and old and new kernels > > can no longer read each other's struct. That is the problem Tarun > > We can structure it cleanly by nesting the payload: something like > struct { struct header {...}h; struct serialize_data { ... }p; }; > That way, the header can expand dynamically at the front, while all > fields inside `serialize_data` stay at fixed offsets relative to the > start > of the payload. > > Since the header size is self-describing via continuation bits (e.g., > the last two bits indicating whether another flag word follows), LUO > can > easily compute where the payload begins in the incoming blob. This > keeps the implementation simple, avoids linked lists of offsets. Oh interesting. I agree a dynamically sized header at the front can work and is simpler than a linked list. So the header and the payload need to be separate, and the payload is located with pointer arithmetic on the header. For example: struct luo_ser_hdr { u32 size; /* Size of the payload in bytes */ u32 flags; /* Bits [31:30] indicate an extension word follows */ /* u64 extension words follow while the continuation bits are set */ }; /* Size of the header, including any extension words. */ size_t luo_ser_hdr_size(const struct luo_ser_hdr *hdr); static inline void *luo_ser_payload(const struct luo_ser_hdr *hdr) { return (void *)hdr + luo_ser_hdr_size(hdr); } On preserve: hdr = kho_alloc_preserve(luo_ser_hdr_size_for(nr_ext) + sizeof(*ser)); luo_ser_hdr_init(hdr, sizeof(*ser), ...); ser = luo_ser_payload(hdr); ... args->serialized_data = virt_to_phys(hdr); On retrieve: hdr = phys_to_virt(args->serialized_data); err = luo_ser_hdr_validate(hdr, ...); if (err) return err; ser = luo_ser_payload(hdr); What would size mean in luo_ser_hdr? The size of the payload or the size of the combined luo_ser_hdr + payload. luo_ser_hdr is self describing so maybe it's just the size of the payload?