From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53ADB606A329 for ; Thu, 22 Oct 2026 17:57:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Li6mRM8S; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=DJJr1fwO DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=8EgRcbuDfKORZQpY0utOTTMffHlpWo5to8q3utLizKM=; b=Li6mRM8Sy/+4sJfKvo6qa4Kbm5 GsIwHz8AJujIv2Fj7mZy8aG0ztxk5tw/6O1EhJvz+iWsea4whxuiOv9o0vrUJfUv3un6sxiVIvrhb W4G4BWduJSbumdvKodKS+i6++mLLX5ESnTLlUZScbVKJ4KB0EWfCDlNzucPxBV8CJxdy8Edbqy4g7 GsLwcaeYij8F2z+mWbYANIzKMzWC0T0H7f5z+rYZY4YvT+RSGOLAaJThDQQ44/z/fKzFbUystQ86c E2Vm5y/5Mhfy01A0wq+fbaWQf3FOS53yAbkdaNvnRljjkxo49+1YxqZe7wN6y0gH0j7Q+cX7EK2rK GEkXhkKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xJx2Y-0000000EfNS-3Ccj; Thu, 22 Oct 2026 17:57:22 +0000 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xJx2W-0000000EfME-2ihl for kexec@lists.infradead.org; Thu, 22 Oct 2026 17:57:21 +0000 Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-cd5c9e52398so54641a12.1 for ; Thu, 22 Oct 2026 10:57:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1792691840; x=1793296640; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=8EgRcbuDfKORZQpY0utOTTMffHlpWo5to8q3utLizKM=; b=DJJr1fwOCaamsq2q4jgfPbYaguA5IR0Y4vkgyulG0hnynffRpvtjOJ1jJesstNXKRK ntmDffiCDhXJnpSCNnQInRGuwO+EthyEKXYeDXPPehecghx1MseyJ2ho+F4OYklGiBVG u51qSvqDD7JvAiMW+yP4QzosnYYJGRrT01IU3ysH+smd2dy56Tq++WRQi6XM8hy/LTsB t00mgbgTqvoLwZfXKXv4m3O6zwkc8NENjtynh2bs08ljim0bMNkpf6NUtwPkA0B4oVb5 TdPMA1Ku5WnGWWwR+vaUwIDHPzf/IMaKaToxORENCqJ4v29hwlHPZKYunslv/RtGYWcQ tgQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792691840; x=1793296640; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=8EgRcbuDfKORZQpY0utOTTMffHlpWo5to8q3utLizKM=; b=JuiE6sRSwFZTr8dFvINxKhKKj3W9w7yDdsVCYUo+rIolj4FAmljrKmvawnmEnJeC6o RTjUD98B+Q6FhMbTpjujaxWJ5phfEu2ZBrbIabCHvpsv9Vwcj874lZcDBi4y1pEIWIoD /OGwJ5obkiNjHnFGpe08pA8fCHqVAFU4kfSdGuFEijyoV8FmyvfaWfU6sYfo9ws63hks zoYDCIeUh1WHjGiX/N/VgFhOB2WaQZ8wgngdjB1W/N1uKaGczGlXxy8Hkmt1wXavdKOy DOj9ftrD5jIFwtUDVUEx3JYoxHZQAsX1Z5Cq/vgSd+ETV+W2r/JQuRM3PQuJ4ZSTRBAT UPWg== X-Forwarded-Encrypted: i=1; AKwUvBxuwMzFN/px7f09LtsqOewWLn/XZsn7rz/AqeVY6Ct6DYxYxXcaxkoGo5jmUy8PB1LbIUgXGw==@lists.infradead.org X-Gm-Message-State: AFq9FYJpgikl8vOgm4j5Rle5nUkdv/Snl6qpVLERpwVVNj+705n666Cl 6wdvcq9HpQN/5FQVpReFFwTY+B6ZjEHWi+4PsZ/ii7lcWsERr2wTYnCN6aAI+9ozrg== X-Gm-Gg: AYBFou0D7fUFECgqShRDuNcsADH9/8XGzQKI1DJwx/bRnF3T4iNC5l/gPOGc1USmNPP wVFGHerntLZyLdrlTeA8uurqCODrcWNgK/0UCRcuFhU/vXue3F+xIL+3utWOLHf36pfBB0vWqbM HRaXiDUuCoDHJGsqrg8z9RvCl57T3mIGHmnDOkicVYxkVk3DhElffWhyHrwZWSMCDBV+J9gjuz+ 50pvGpveMqPf0NwyEp91lwuPHMHEUdoD+WtWimHJHPH0VZTPDODYw4VxqiXE6EQGQBB+KnFoTnA 01qgy6a8snvJDVCGJU+/u6WEdSR+Y6hBBZGgyRYjlWhDeu8lDwDdmKwUD6qAcTDcvkaWlNsL+ik xb/SggcnT950pNVxJnQvhF3yq4S8q6mNG8f/+Ax6/B+VlISsbE7DOFBvtI2VXOfqXI8pasEv70p M7dsCOid0wxIp60iMnykc5Gzrghwd1TcO7IO85X7f8cLQ8ZtGRsyk7TEJujoxQS7xlUOPk7D8UF ISDhdqk33LC8mLhTLFuSjXs/J9vFeALMquBJHeo5uRe/5eUyUgOeOk8LZq3Pr6Tb5qOL1Id/8ZA YQxrNxEXDlaCK6lC8mBNHQ== X-Received: by 2002:a17:903:19ef:b0:2e9:61bf:6591 with SMTP id d9443c01a7336-2ea7c33be70mr1491705ad.45.1792691839016; Thu, 22 Oct 2026 10:57:19 -0700 (PDT) Received: from google.com (192.150.203.35.bc.googleusercontent.com. [35.203.150.192]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ea7b34dadbsm1687675ad.26.2026.10.22.10.57.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2026 10:57:18 -0700 (PDT) Date: Thu, 22 Oct 2026 17:57:15 +0000 From: David Matlack To: Pasha Tatashin Cc: Tarun Sahu , Andrew Morton , joro@8bytes.org, Mike Rapoport , Pratyush Yadav , maz@kernel.org, arnd@arndb.de, jgg@nvidia.com, robin.murphy@arm.com, loganodell@google.com, oupton@kernel.org, kevin.tian@intel.com, alex@shazbot.org, dwmw2@infradead.org, pbonzini@redhat.com, seanjc@google.com, will@kernel.org, Alexander Graf , Bjorn Helgaas , baolu.lu@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, sagis@google.com, linux-mm@kvack.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, linux-pci@vger.kernel.org, kexec@lists.infradead.org, skhawaja@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 2/4] liveupdate: Select file handler by name in the preserve ioctl Message-ID: References: <20261021152527.375070-1-tarunsahu@google.com> <20261021152527.375070-3-tarunsahu@google.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261022_105720_761804_1FC77C48 X-CRM114-Status: GOOD ( 38.28 ) X-Spam-Score: -17.6 (-----------------) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" X-Spam-Status: No, score=-13.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 2026-10-21 09:14 PM, Pasha Tatashin wrote: > On Wed, Oct 21, 2026 at 7:02 PM David Matlack wrote: > > > > On 2026-10-21 01:17 PM, Pasha Tatashin wrote: > > > On Wed, Oct 21, 2026 at 11:25 AM Tarun Sahu wrote: > > > > > > > > Currently luo_preserve_file() iterates over luo_file_handler_list and > > > > picks the first registered handler whose .can_preserve() callback > > > > returns true. When a subsystem introduces a new, backwards-incompatible > > > > file handler alongside an existing one for the same file type, userspace > > > > has no way to choose which handler preserves a file descriptor, nor can > > > > the kernel keep the existing rollback-safe handler as the default while > > > > allowing callers to opt into the new handler. > > > > > > That is not how it will work. If we are in the .can_preserve() call, > > > it means the user has already decided which file handlers to use. We > > > need to do that before any preservation happens; otherwise, we could > > > run into conflicts on FLBs i.e. FH of different version require > > > different FLBs. > > > > > > Therefore, there should be a luoctl call (i.e via a new ioctl to set > > > compatability) that provides the kernel with the specs file of the > > > target kernel we are updating to, allowing the kernel to select the > > > compatible file handlers. Since .can_preserve() is called when the > > > user is already preserving files, the specification must have already > > > been supplied, or the kernel should fall back to using the default > > > (i.e., latest) file handlers. > > > > I don't think that is the right direction. IMO the kernel should not be > > choosing which file handler to use, userspace should be. If userspace > > gets it wrong and chooses a file handler the next kernel does not > > support, that's on them. > > > > The problem with the kernel making a decision about file handlers is > > then userspace does not know what arguments to pass in. We are adding > > custom per-file handler arguments to PRESERVE_FD and RETRIEVE_FD. If the > > kernel is picking which file handler to use, say for a memfd, then > > userspace doesn't know which arguments to pass in. > > It is not the kernel deciding on its own which handler to use; it is > the system admin (or host orchestrator) that configures LUO before the > LU process starts, because the sysadmin knows what kernel we are > rebooting into and the LUO specs of that target kernel. Meanwhile, the > process calling PRESERVE_FD (e.g., a VMM) only knows about its own FDs > and should not have to track target kernel serialization versions. > > Also, the PRESERVE_FD and RETRIEVE_FD arguments are uABI tied to the > FD type, not to a specific internal handler version. They are stable, > and we can expand them the same way any ioctl argument is expanded > (via size and flags), without ever shrinking or breaking them. We > should not play the game of providing completely different uABI > argument structs for different versions of a file handler. If a caller > passes a new feature in the uABI args that the currently configured > file handler version does not support, PRESERVE_FD simply returns > -EOPNOTSUPP, just like any other extensible ioctl. If we require that PRESERVE_FD and RETRIEVE_FD uAPI is stable across different file handlers for the same file type, then my concern is resolved. > More generally, we are rebooting the host into a single target kernel, > so compatibility is a session-level property, not a per-FD property. > If we need an upfront global ioctl anyway, configuring the target > compatibility upfront in one place is much cleaner than exposing FLBs > to userspace and splitting version selection between a global ioctl > and per-FD PRESERVE_FD calls. That's a good point. Ok let's not do per-FD FH selection.