From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 976EA606D81A for ; Fri, 6 Nov 2026 22:35:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=vGuKOTOz; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=RZJKWD1U DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=BwjRA8ftZApzwOyImkXY8LHZEAElz+0AJdwAhV3strc=; b=vGuKOTOzHoIAlfqrmv05V6T3we 44kwfrFl25qSNWkyFjRKQCj0nQxokkNENYz410xT25oDBXFpqLy1fsEW/JCtBTNu9Vs66+KtFxBQq TUbj2EkISmOk6mmmtnli0cQtv8pT8H/w1NIB3d8s6UFH3+j3UJQ4hefGN8GkwJcvwkb+uI16uWIeu XwBeRo6H263JcFyOXY1Vf7+BUEIorxO/DfIw+MTc3/XY/mcCSg14Nty3UcEAe4e10qdqcawY2IxSK QObG5Quy74ZDeM+M1Sc2O+hyhC5fmhaguT03ukfXMhd0wST1fDd+Bk/hYfZhJSm49qvvMxMp7DB40 MIxijGUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPSX3-0000000DnWw-0DFw; Fri, 06 Nov 2026 22:35:37 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPSX0-0000000DnWA-1FbO for kexec@lists.infradead.org; Fri, 06 Nov 2026 22:35:35 +0000 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-2ed3f563739so12125ad.0 for ; Fri, 06 Nov 2026 14:35:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1794004533; x=1794609333; darn=lists.infradead.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=BwjRA8ftZApzwOyImkXY8LHZEAElz+0AJdwAhV3strc=; b=RZJKWD1UCPNirPtsDTnuJ1VO/S7bmm951ZrSBVqNzwBeB0o4+JKhAYgS9S6lcQgZN3 9ctwMQsypnTJjymrlZWSaTgECeqpLje8PhKB84Ex8xczNUrUf7X/CJ33YPy5Q0pzJqLn GnKMKn1rJhrPaHK3zCo6oYC2lJfd/6uqBfYy8arr6rVlPpZKohuFwD0Eobp0TAon0l42 i9g7Gjc0XvngDlU24mRbiCQyqfLxm2bFCZI3m6MWWe2NMcTR8FDE+ysq75UJQIdGSIo8 WE9i8BbQwKJt+00tVNkzNMLlR/6ph6hTBJgf/ufOSp+eWSzytWzL4q7BLkiJtTzSdlbH TUPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794004533; x=1794609333; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BwjRA8ftZApzwOyImkXY8LHZEAElz+0AJdwAhV3strc=; b=YbVHcxwVkh4J5LMCIU7hLruc+Mfo2sE8cb+HJMzH6f5tqRjeNRlk5gO8Gobg4Lg7pI NxtNz1ctj8QEu7g910QqopcYNRmFkB7kIhiwqt6dpATYpjy2VgYNctTf/1FRvqD7wFnD F3h12zaiR3lFh8MfJt/UJEJEPAvNWUi+mmkruKDZRclvKSlCO2jqqhfZTtnWq7Ku22qI xgr5XO902C4wak8kej9jtrlENKNXfkf7uch9Hf6KvuBUXYXSCWv/pXAd2rM26Qksxjnc 2eKcaUc1C0z+6Q8iqvMbx1BSHVc/b8KcKZ6vn68Uq745PyWZcWPGuCLF0dBCRo7C5kUc c5Kw== X-Gm-Message-State: APuU4Z9zVs1lFfQ/Y01lODkys6OkWMDklY/oXnWgp3gLcd4oBxP2rfr4 dEejDo+coQlg99P0B/7GYKr1MRU2060ci6fcENjtsVtgNZjMM+B7r+u8mPbSAwUtdw== X-Gm-Gg: AYBFou2276pAjL8kHzx19UUhdZ7TPMVzO+uoajXhbgctfc0VXCj0xkBaTIkdaLOW1sn CE8wn9m1T8YWAbvU7YLA+F17+KQAVEFT4q+lDNAq/FXnjIMm0ZrqC2TNUagANGijznzHKIYUfat qYI+XR4yi1hJQm34VJcAJ+8siMmCDqWPkk/81AbHx0yjvoYdj2YwcwOn+Xrlp7LfDIWSu2glptL BIu3qmoSrAHx4VLcHCW6gn91sJNiKd2mI0XfTRFFJXg5adhwCS9i513ZEnFBng2HFdIC50n1+HR y2tMTzRBhZ07am0+Xo8GAJljCOlYrkWGwxOEZD8n9SEJI2qADFEUiD1p5OALTvR9oU282+hvGY+ Gvgpp9VovTJrbY9qf5Wvv69PHr3PykcA1sZ7rYaBsBRX8fxfezGT376ecUWWJC8zNWPZtLAnHee DubWjGGCUqAouL06mPF3p64QvYqXxbTrXT1N7VKKV2zqAWQj9c7L5PIwiG6rjz0f4+SDLAMQ8o2 3LcXiCn1AecFpfk4setfJ9rmxcJP7yLy7dGjYn1nSh4Q+kRWWVQCv+FFJWTipm4d0TdoIOh7OJa 1XJX7i8n7rr7ovb1ZeIIjHAdQ74lnn0wa5Y1xWKvx7zw1YsdGJElvTcQKJbt3LcNWkbh3ARPK1W EDmoNfoVRWTcg++cLICal X-Received: by 2002:a17:902:e80e:b0:2ea:1079:e519 with SMTP id d9443c01a7336-2ed6a97c2c6mr202835ad.17.1794004532665; Fri, 06 Nov 2026 14:35:32 -0800 (PST) Received: from google.com (25.75.145.34.bc.googleusercontent.com. [34.145.75.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3b103435561sm482994a91.3.2026.11.06.14.35.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2026 14:35:31 -0800 (PST) Date: Fri, 6 Nov 2026 22:35:27 +0000 From: Samiullah Khawaja To: Vipin Sharma Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-pci@vger.kernel.org, ajayachandra@nvidia.com, alex@shazbot.org, amastro@fb.com, ankita@nvidia.com, apopple@nvidia.com, bhelgaas@google.com, chrisl@kernel.org, christian.koenig@amd.com, corbet@lwn.net, dmatlack@google.com, graf@amazon.com, jacob.pan@linux.microsoft.com, jgg@nvidia.com, jgg@ziepe.ca, jrhilke@google.com, julianr@linux.ibm.com, kees@kernel.org, kevin.tian@intel.com, leon@kernel.org, leonro@nvidia.com, lukas@wunner.de, mattev@meta.com, michal.winiarski@intel.com, parav@nvidia.com, pasha.tatashin@soleen.com, praan@google.com, pratyush@kernel.org, rananta@google.com, rdunlap@infradead.org, rientjes@google.com, rodrigo.vivi@intel.com, rppt@kernel.org, saeedm@nvidia.com, schnelle@linux.ibm.com, skhan@linuxfoundation.org, vivek.kasireddy@intel.com, witu@nvidia.com, yanjun.zhu@linux.dev, yi.l.liu@intel.com Subject: Re: [PATCH v6 07/27] vfio/pci: Preserve vfio-pci device files across Live Update Message-ID: References: <20261102153656.1431701-1-vipinsh@google.com> <20261102153656.1431701-8-vipinsh@google.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20261102153656.1431701-8-vipinsh@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261106_143534_378322_AAE07523 X-CRM114-Status: GOOD ( 26.65 ) X-Spam-Score: -17.6 (-----------------) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" X-Spam-Status: No, score=-23.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Mon, Nov 02, 2026 at 07:36:36AM -0800, Vipin Sharma wrote: >Implement the Live Update file handler callbacks to preserve a vfio-pci >device in noiommu mode across a Live Update while keeping it running >across kexec. Subsequent commits will enable userspace to retrieve and >take over this file after the Live Update. > >State about each device is serialized into struct vfio_pci_core_device_ser >using Kexec-Handover (KHO) to preserve the pages holding the struct and >the Live Update Orchestrator (LUO) to preserve the physical address of >the struct. > >Key design notes and constraints: > > * Noiommu-only policy and bound cdev requirement: can_preserve() verifies > that the preserved file is a bound vfio-pci cdev file descriptor via > vfio_file_is_bound_cdev(), and preserve() requires the device to be in > noiommu mode via vfio_device_is_noiommu() (returning -EOPNOTSUPP > otherwise). CONFIG_VFIO_PCI_LIVEUPDATE now depends on > CONFIG_VFIO_DEVICE_CDEV and CONFIG_VFIO_NOIOMMU. > > * Serialized state: During preserve(), serialize the PCI domain, BDF, > config space size, reset_works flag, and the initial pci_saved_state > captured when the device was first opened. During freeze(), snapshot > the virtualized PCI config space (vconfig) and capability map > (pci_config_map). > > * Keep-running freeze and unfreeze: Do not reset the device, clear > PCI_COMMAND_MASTER, zap BAR mappings, or revoke dma-bufs during > freeze(). Validate that VFIO interrupts are disabled, that the device > is in PCI_D0 (and not in VFIO runtime PM low-power mode), and that > SR-IOV is not enabled, as VFs are not preserved and the next kernel > disables SR-IOV on the running device. Then mask physical INTx > (recording the prior state) and mark the device frozen. If the > Live Update is aborted after freeze(), unfreeze() restores the physical > INTx state and clears liveupdate_frozen so the existing FD remains > usable. > > * TOCTOU synchronization: vfio_pci_dev_is_frozen() is checked locklessly > on entry to the ioctl, read/write and mmap paths, and re-checked under > a lock that freeze() holds before any operation that could change the > device or vconfig: under vdev->igate in vfio_pci_ioctl_set_irqs() and > around every config-space write in vfio_pci_config_rw_single(), under > vdev->memory_lock in vfio_pci_runtime_pm_entry(), > vfio_pci_ioctl_reset() and the SR-IOV enable path of > vfio_pci_core_sriov_configure(), and under dev_set->lock in > vfio_pci_dev_set_hot_reset(). A racing operation thus either completes > before freeze() takes its snapshot or fails, while existing BAR mmaps, > ioeventfds and dma-bufs keep working. Serializing config writes on > igate covers the PCI_COMMAND, INTx disable emulation, power state and > FLR paths at one point (the INTx disable emulation now uses the > igate-held __vfio_pci_intx_mask() and __vfio_pci_intx_unmask() > helpers), and also serializes the irq_type and virq_disabled accesses > of config writes with VFIO_DEVICE_SET_IRQS. > >Co-developed-by: David Matlack >Signed-off-by: David Matlack >Signed-off-by: Vipin Sharma >--- > drivers/vfio/pci/Kconfig | 2 +- > drivers/vfio/pci/vfio_pci_config.c | 19 +- > drivers/vfio/pci/vfio_pci_core.c | 49 +++- > drivers/vfio/pci/vfio_pci_intrs.c | 4 +- > drivers/vfio/pci/vfio_pci_liveupdate.c | 303 ++++++++++++++++++++++++- > drivers/vfio/pci/vfio_pci_priv.h | 13 ++ > include/linux/kho/abi/vfio_pci.h | 52 ++++- > include/linux/vfio_pci_core.h | 4 + > 8 files changed, 434 insertions(+), 12 deletions(-) > [snip] >diff --git a/include/linux/kho/abi/vfio_pci.h b/include/linux/kho/abi/vfio_pci.h >index 67e8199eec59..725043a44b55 100644 >--- a/include/linux/kho/abi/vfio_pci.h >+++ b/include/linux/kho/abi/vfio_pci.h >@@ -9,14 +9,19 @@ > #ifndef _LINUX_LIVEUPDATE_ABI_VFIO_PCI_H > #define _LINUX_LIVEUPDATE_ABI_VFIO_PCI_H > >+#include >+#include >+#include >+ > /** > * DOC: VFIO PCI Live Update ABI > * > * VFIO uses the ABI defined below for preserving device files across a kexec > * reboot using LUO. > * >- * Device metadata is serialized into memory which is then handed to the next >- * kernel via KHO. >+ * Device metadata, virtualized PCI configuration space, VFIO's capability map, >+ * and the initial PCI saved state captured when the device was first opened are >+ * serialized into memory which is then handed to the next kernel via KHO. > * > * This interface is a contract. Any modification to any of the serialization > * structs defined here constitutes a breaking change. Such changes require >@@ -25,4 +30,47 @@ > > #define VFIO_PCI_LUO_FH_COMPATIBLE "vfio-pci-v1" > >+/** >+ * define VFIO_PCI_SER_RESET_WORKS - Device supports function reset. >+ * >+ * Set in &vfio_pci_core_device_ser.flags when the preserved device had >+ * ``vdev->reset_works == true`` prior to kexec. >+ */ >+#define VFIO_PCI_SER_RESET_WORKS BIT(0) >+ >+#define VFIO_PCI_SER_KNOWN_FLAGS VFIO_PCI_SER_RESET_WORKS >+ >+/** >+ * struct vfio_pci_core_device_ser - Serialized state of a single VFIO PCI >+ * device. >+ * >+ * @domain: The device's PCI domain number (segment). >+ * @bdf: The device's PCI bus, device, and function number. >+ * @cfg_size: Size in bytes of the device's PCI configuration space >+ * (``PCI_CFG_SPACE_SIZE`` or ``PCI_CFG_SPACE_EXP_SIZE``). >+ * @size: Total size in bytes of this serialized buffer, equal to >+ * ``sizeof(struct vfio_pci_core_device_ser) + 2 * @cfg_size + @saved_state_size``. >+ * @flags: Bitmask of ``VFIO_PCI_SER_*`` flags; unknown bits are rejected. >+ * @saved_state_size: Size in bytes of the serialized &struct pci_saved_state_ser >+ * blob stored in @data after ``config_map``, or 0 if none. >+ * @reserved: Reserved for future use; must be 0. >+ * @data: Variable-length payload containing, in order: >+ * 1. ``u8 vconfig[@cfg_size]`` - VFIO virtualized config space snapshot >+ * captured during ``freeze()``. >+ * 2. ``u8 config_map[@cfg_size]`` - VFIO capability map snapshot >+ * captured during ``freeze()``. >+ * 3. ``u8 saved_state[@saved_state_size]`` - serialized >+ * &struct pci_saved_state_ser captured during ``preserve()``. >+ */ >+struct vfio_pci_core_device_ser { >+ u32 domain; >+ u16 bdf; >+ u16 cfg_size; >+ u32 size; >+ u32 flags; >+ u32 saved_state_size; We will need space for iommufd_token when we preserve that, we should probably add it now as otherwise the compatibility would be broken when we add it? Is the reserved here for that? >+ u32 reserved; >+ u8 data[]; >+} __packed; >+ > #endif /* _LINUX_LIVEUPDATE_ABI_VFIO_PCI_H */ >diff --git a/include/linux/vfio_pci_core.h b/include/linux/vfio_pci_core.h >index 9a1674c152aa..6bae7581f4f4 100644 >--- a/include/linux/vfio_pci_core.h >+++ b/include/linux/vfio_pci_core.h >@@ -149,6 +149,10 @@ struct vfio_pci_core_device { > struct notifier_block nb; > struct rw_semaphore memory_lock; > struct list_head dmabufs; >+#ifdef CONFIG_VFIO_PCI_LIVEUPDATE >+ bool liveupdate_frozen; >+ bool liveupdate_intx_disabled; >+#endif > }; > > enum vfio_pci_io_width { >-- >2.56.0.317.g454f8302e1-goog > Thanks, Sami