From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EC48606A31B for ; Tue, 27 Oct 2026 16:40:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=mQfbtu8F; dkim=pass (2048-bit key, unprotected) header.d=soleen.com header.i=@soleen.com header.a=rsa-sha256 header.s=google header.b=cnzisrvb DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=gbXuStreYRF1M4k9Su5zd2++RJBOLVmoBCN1Uwl3TZ0=; b=mQfbtu8FzWZAhH+uETZfNw+Utv nbay9X9SyF4SBhpVvEdOe98KiUS4CKZWpl0eZpTStDgVv0O2FtLOyDGOVxuZorgqk5n1ZhbOCmKEZ YERx/VQ8JvB6Qgl+ehskZJ6j5Nb4QbphKelbpf3fT3dHTtQzZh16VVRZR2WI0EQiPxoCpZPmzoWf9 BgRQceZTOJ1Xl1XM3FYfWurfJdYLQkmsw58ukCXTJVAvwSuNC/J26e5NzzY48tz/IKvBQHoAmKibv A5RowEeIobSNOxG4A72WA3WjqL5uRR8/yeHZjNCpGoOidDE1oPQ8gLK/hZB+2TrPiI03+Q7qJMbF0 HdscNRKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLkDZ-00000005ONg-2d88; Tue, 27 Oct 2026 16:40:09 +0000 Received: from mail-ua1-x936.google.com ([2607:f8b0:4864:20::936]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLkDX-00000005OMo-1Ni3 for kexec@lists.infradead.org; Tue, 27 Oct 2026 16:40:08 +0000 Received: by mail-ua1-x936.google.com with SMTP id a1e0cc1a2514c-988c7371716so55160241.1 for ; Tue, 27 Oct 2026 09:40:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1793119206; x=1793724006; darn=lists.infradead.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=gbXuStreYRF1M4k9Su5zd2++RJBOLVmoBCN1Uwl3TZ0=; b=cnzisrvbKbW0pFuDaz+kHMmxXiIezPBvVCc91p55CF1D2bHf1Db3F09sdK7bWgGt34 5ov5IgJ5BMQZmj0DqZm6oDX+jWwCxnY0VQbp3qHWAn0/pRNIv9/28eULp4D1s4NutGZt OsVzZzrpGosEwuZLRteiWiauEvebDx9oHrVSDtzSsjctdYHwt/8WvThKOR+b0BT9Vz8d m2fpqgylo1WVDHW3cIg13ONLoqd3d5rXc896ZGhiC5bFg5Op+AQ2oILumVD3ztFrGO1a 0mG4xZPzG3KzmSdEwVxPHmlmOZdGK/2ZIhdruWhXgbkZr4f32pDMCuOFI2n+ExibQKyL BcQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793119206; x=1793724006; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gbXuStreYRF1M4k9Su5zd2++RJBOLVmoBCN1Uwl3TZ0=; b=M0ZtYYKUX8X4SslUgH+47mAwgsCK0NtuSR1U8mfMI2xJWZG2pBbFp2bRu9vvlPRSju svzNSDtlleRq2ULURj7hwxr40Yo1yvKLA0p0TQNrfdezbPsQYWgaZTsoLDD7iexV4Ox1 mw9RcGVVCQWzjkaDmQlf5G1r2FAd/mBgSbJZ46IJonl2IVAzKLrCWqy3EYQWkwVWXxWe QrJWv0/TknwPemBQwmZeHNVy7+SyNxYjk1i9m5xE41CCkurTT9XYF3wi0dv+1gXbGKMH vJa/A3PGlG3t2NOlTYGBzsxwsVe6kLwcE4x18oi8oMrIeYIpicRNqr3f8TxuAXtizgGf 97rw== X-Forwarded-Encrypted: i=1; AKwUvBx27t/jcVsxErSn90HjuLy7nXC717fBePKEeVr4baHGKPn1m4YKR7dsdBikrvDkDHyDYSA+Og==@lists.infradead.org X-Gm-Message-State: AFq9FYJobaQkg9SxF6pdIoJp6PDywbMrRchuVEhE43zhAOYqW/sZYPio kajnE8MTmWFYUps2rzvwG0kXqtMuhW4ODSyejz1wpiIeEJ4I56wzUKoeddlh80oFues= X-Gm-Gg: AYBFou1uOgT0T1vE0WaEiaL4ds1ctL6Ao8++GIWmccAZdsllJuHmfy+rl1zii/X8DRM UeA7iMsUxZLchYKGzh0+cgYtCijDlwQ9je0EyyfzVeigtmI3Yx7PifR70XvYw8d8rq26ADBVkIE AXmqkLVgE68aL8byiY3Rg6itd1dBN0AhkkKNlHIAvg28uscRv73SKWuwTj5a/N/9JkGb0/CBO1r gL1EJGIa57jRCALF2RwdUEb4P/3gbE36sP3EKZjhmVvfj5ZphlZv5qbPnBBV65mQw/HTHGGdWwh gPTrYWetpmGddKIVE+md84PLyOguVH01NpaNSSkM22as09ke34m6osQhmU1mDpDpIh24Hg+Ff8K 3i0d1LNYO/S41yE7UrA4PjhcxkWAD8m5tyIe5zr7dUKr/4txFn2SGxbx8TbUOK1u08RowVY0anF ro6xiyJvtXUIcR8DRQeQWp3B8lWSw4q9DrVzAEEZVklDCVoE0oHVEXV1H/2cdbdIHcTUqLTqENC VpsB3QEZf2yw9Aop+PhPWe3rzmOx/F6W1yQ2ClC7Ev1D/fqfIMnMlTD9ewZyEWjkTkfrAGb9ygx tuEYde83NhxVqaWceGqANpk1cHPgaTJpleSw1loM8a8reL/ySTGubnoYThbwGKtUSRwzMFLnVDL kJCf91Sy5+yCjgpa/ql/f57Xk8aiYTAMxiew8SRjmZw3xxE7Utcs= X-Received: by 2002:a05:6102:5048:b0:7bf:74c1:b606 with SMTP id ada2fe7eead31-7ce5ce4227dmr3243460137.34.1793119205875; Tue, 27 Oct 2026 09:40:05 -0700 (PDT) Received: from google.com (16.49.199.35.bc.googleusercontent.com. [35.199.49.16]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-9912da2d9d1sm442866241.7.2026.10.27.09.40.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2026 09:40:05 -0700 (PDT) Date: Tue, 27 Oct 2026 12:40:04 -0400 From: Pasha Tatashin To: David Matlack Cc: tarunsahu@google.com, Andrew Morton , joro@8bytes.org, Mike Rapoport , Pratyush Yadav , maz@kernel.org, arnd@arndb.de, jgg@nvidia.com, robin.murphy@arm.com, loganodell@google.com, oupton@kernel.org, kevin.tian@intel.com, alex@shazbot.org, dwmw2@infradead.org, pbonzini@redhat.com, seanjc@google.com, will@kernel.org, Pasha Tatashin , Alexander Graf , Bjorn Helgaas , baolu.lu@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, sagis@google.com, linux-mm@kvack.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, linux-pci@vger.kernel.org, kexec@lists.infradead.org, skhawaja@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 3/4] liveupdate: Replace compatibility string with a 2-bit pair feature header Message-ID: References: <20261021152527.375070-1-tarunsahu@google.com> <20261021152527.375070-4-tarunsahu@google.com> <9huzzew0el59.fsf@tarunix.c.googlers.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261027_094007_381726_89CFF246 X-CRM114-Status: GOOD ( 29.71 ) X-Spam-Score: -2.1 (--) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 10-26 21:14, David Matlack wrote: > On 2026-10-26 11:50 AM, tarunsahu@google.com wrote: > > Right, Required bit should be source kernel payload property to tell > > target kernel that the payload must be handled to correctly deserialize > > the data. It should be source kernel (userspace) responsiblity to make > > sure it understand the target kernel before doing liveupdate. > > > > Saying this, During deserialization, target kernel's required bit is not > > necessary. So I propose the following truth table. > > > > Source hdr Target supported[i] Action > > ---------- ------------------- ---------------------------------- > > 00 0 or 1 Accept: feature absent in payload > > 01 0 Accept: ignore the feature data > > 01 1 Accept: use the feature data > > 11 0 Reject: -EOPNOTSUPP > > 11 1 Accept: use the feature data > > 10 0 or 1 Reject: -EINVAL (invalid encoding) > > Yes, this matches what I had in mind for the semantics. > > To be explicit: the source kernel should set the bits for each Live > Update based on what is actually preserved, rather than generating the > header from a static per-kernel array. E.g. memfd would only mark a > feature present for memfds that actually use it. That's what allows > rollback to an older kernel as long as nothing being preserved depends > on the new feature. > > But looking at this again, I think the required bit is redundant. Whether > a feature can be safely ignored is a property of the feature itself, not > of any particular file. Every file that has a feature present will have > the same required bit for it. The only thing that actually varies per > file is whether the feature is present. > > The required bit still has to be conveyed to the target somehow, since > the kernel that needs it is the one that doesn't know about the feature. > But it can be conveyed by the feature's number rather than an extra bit: > split the flag space into required features and optional features, and > assign each feature to one of them when it is defined. This is similar > to the required_flags and optional_flags approach in struct pci_ser [1]. > > Keeping the same header shape as discussed with Pasha: > > struct kho_ser_hdr { > __u32 size; /* Size of header + payload in bytes */ > __u16 nr_required; /* Number of required feature bits */ > __u16 nr_optional; /* Number of optional feature bits */ > __u64 flags[]; /* Required bits, followed by optional bits */ > }; > > Required feature N is bit N of flags[], and optional feature N is bit > nr_required + N (using nr_required from the incoming header). The length > of flags[] is DIV_ROUND_UP(nr_required + nr_optional, 64). Both spaces > are numbered contiguously, so there are no gaps, and up to 64 features > still fit in a 16-byte header. > > Each bit just means the feature is present, so the truth table becomes: > > Source bit Target supports Action > --------------- --------------- ------------------------------ > Not set - Accept: feature absent > Optional set No Accept: ignore the feature data > Optional set Yes Accept: use the feature data > Required set No Reject: -EOPNOTSUPP > Required set Yes Accept: use the feature data > I like this proposal. I bet most features are going to be either optional or required, and even if we ever have a magical sometimes-optional feature, it can have its own required flag. So, no need to pay double the cost on every flag. Just need to make sure that optional features always start from 0, in their own enum, so the offset can be computed correctly in the incoming kernel. Pasha