From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3599606A323 for ; Wed, 28 Oct 2026 09:10:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=VrSIrRys; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=IQLvv5Vy DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=bLZSl7G53VjRTMzaR+4ybREso2p4MLSxqwNzQhyf3As=; b=VrSIrRysdV9u70aqug5inUGzAg MZZcBFH4VXcLbm4p8yQqJ6fd7g+hCLl+NuAjeGM28o2+hTJQbNP7rA2flUyQyBpXdR6SJ0jgNzbD7 pnzBnA1RDbJROemOTlDFVpOdAPUO7w33JInDHRzRlJ1s1AOUe9r/bTM9fbU0ZQocC7p5OsaqiCHsw q3A+2P+iJWN2y+egVzig5DlnvWb6L74yuPi2XG/4oSjjP4NEL6fHWwJUUnxiNLoXP1tYkBoiv5//X hhd2YVB94DKjyBu0FCoCt8sTVmuHtZiWUxde95L7WzXj2RheFwKsrHBNQRpZL7qrbc2b+s4aw85A3 iVain3Rg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLzfU-00000006cze-2Oax; Wed, 28 Oct 2026 09:10:00 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLzfT-00000006cyu-1SQ3 for kexec@lists.infradead.org; Wed, 28 Oct 2026 09:09:59 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 7A5B1416AD; Wed, 28 Oct 2026 09:09:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61CEF1F01825; Wed, 28 Oct 2026 09:09:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793178598; bh=bLZSl7G53VjRTMzaR+4ybREso2p4MLSxqwNzQhyf3As=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=IQLvv5VyEW9W822k4mht+xeLq3S4XizAu+yULPQZsw/IVShZGFw4v2DipYDdBsIDM ZuO9nCZm9CpX8w5ml0a91JdjeCai4IiV9QbHxDf8RJ5flGZR1CGm3IoGtSym8UApk4 Csg/F36qW6LxKG3+BIRu5428gBcRYr7WkphITq9nSu15oEzQk7PBodVhHzdvwyKAsU L0DDpJRkU7kCsCA8XIudNovrwViAworRTX8BBm8mzz3lW+kK0r+b10tnjOyJB2Z4jA ml2WMykb/ecw+qvzqKMXuJLLemM/U4ijkpfsw/rwxPj03zXiSs2jn466I+8Fyr4hbl WjWlEy8zwut6w== Date: Wed, 28 Oct 2026 09:09:42 +0000 From: "Lorenzo Stoakes (ARM)" To: "David Hildenbrand (Arm)" Cc: Dev Jain , Andrew Morton , Johannes Weiner , Michal Hocko , Qi Zheng , Shakeel Butt , Kairui Song , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Baoquan He , Baolin Wang , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Kees Cook , Peter Zijlstra , Jann Horn , Pedro Falcato , Hugh Dickins , Pasha Tatashin , Pratyush Yadav , "Matthew Wilcox (Oracle)" , Jan Kara , Zi Yan , Lance Yang , Rik van Riel , Harry Yoo , Alistair Popple , Nico Pache , Ryan Roberts , Usama Arif , Kiryl Shutsemau , Matthew Brost , John Hubbard , Peter Xu , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Oscar Salvador , Minchan Kim , Muchun Song , Xu Xin , Chengming Zhou , Chris Li , Kemeng Shi , Nhat Pham , Youngjun Park , Gregory Price , Joshua Hahn , Rakie Kim , Ying Huang , Jason Gunthorpe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-cxl@vger.kernel.org, stable@vger.kernel.org, Josef Bacik Subject: Re: [PATCH 09/46] mm/rmap: handle device-exclusive entries in folio_referenced_one() Message-ID: References: <20261027-fixes_core-v1-0-6f74bec9a5bb@kernel.org> <20261027-fixes_core-v1-9-6f74bec9a5bb@kernel.org> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Wed, Oct 28, 2026 at 09:08:04AM +0100, David Hildenbrand (Arm) wrote: > >> - if (lru_gen_enabled() && !lru_gen_switching() && pvmw.pte) { > >> + if (lru_gen_enabled() && !lru_gen_switching() && pvmw.pte && > >> + pte_present(pteval)) { > >> if (lru_gen_look_around(&pvmw, nr)) > >> referenced++; > >> } else if (pvmw.pte) { > >> - if (clear_flush_young_ptes_notify(vma, address, pvmw.pte, nr)) > >> + bool young = false; > >> + > >> + /* > >> + * PFN swap PTEs, such as device-exclusive ones, that > > > > You mean "PFN softleaf PTEs"? Better expressed as "softleaf PTEs embedding a PFN" ... > > Lorenzo raised this off-list as well; I'm using the existing text we use > elsewhere for consistency. > > This needs a cleanup that adjusts all of them :) *like a proud dad of his softleaf name :P* Yeah, agreed, not a big deal, and easier for me to just do a bigger pass finishing off what I started :P -- Cheers, Lorenzo