Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <baoquan.he@linux.dev>
To: Bradley Morgan <bradley.morgan@linux.dev>
Cc: Ajay Kaher <ajay.kaher@broadcom.com>, Kees Cook <kees@kernel.org>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Dave Young <ruirui.yang@linux.dev>,
	Stephen Brennan <stephen.s.brennan@oracle.com>,
	Bo Gan <bo.gan@broadcom.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Zack Rusin <zack.rusin@broadcom.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Brennan Lamoreaux <brennan.lamoreaux@broadcom.com>,
	x86@kernel.org, sashiko@lists.linux.dev,
	Joel Granados <joel.granados@kernel.org>,
	Alexey Makhalov <alexey.makhalov@broadcom.com>,
	Eugenio Perez <eperezma@redhat.com>,
	Ingo Molnar <mingo@redhat.com>,
	bcm-kernel-feedback-list@broadcom.com,
	Thomas Gleixner <tglx@kernel.org>, Petr Mladek <pmladek@suse.com>,
	Pasha Tatashin <pasha.tatashin@soleen.com>,
	John Ogness <john.ogness@linutronix.de>,
	virtualization@lists.linux.dev,
	Steven Rostedt <rostedt@goodmis.org>,
	Maaz Mombasawala <maaz.mombasawala@broadcom.com>,
	Borislav Petkov <bp@alien8.de>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Michael Kelley <mhklinux@outlook.com>,
	sashiko-reviews@lists.linux.dev,
	Randy Dunlap <rdunlap@infradead.org>,
	kexec@lists.infradead.org, Ian Forbes <ian.forbes@broadcom.com>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Mike Rapoport <rppt@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Pratyush Yadav <pratyush@kernel.org>
Subject: Re: [PATCH v4 3/4] x86/vmware: Add the vmware_record_panic_msg sysctl
Date: Wed, 18 Nov 2026 16:09:35 +0800	[thread overview]
Message-ID: <av1dP8iq13h-t5P6@MiWiFi-R3L-srv> (raw)
In-Reply-To: <AAB2E512-6577-4AA9-82E3-F8297A4CBDD8@linux.dev>

On 11/18/26 at 07:53am, Bradley Morgan wrote:
> On 18 November 2026 07:51:35 GMT, Baoquan He <baoquan.he@linux.dev> wrote:
> >On 11/17/26 at 11:02pm, Andrew Morton wrote:
> >> On Wed, 18 Nov 2026 14:42:00 +0800 Baoquan He <baoquan.he@linux.dev>
> >wrote:
> >> 
> >> > On 11/18/26 at 06:14am, sashiko-bot@kernel.org wrote:
> >> > > > Allow administrators to disable host log transfer on ordinary
> >guests or
> >> > > > opt in on encrypted guests. Expose the boolean recording policy
> >through
> >> > > > kernel.vmware_record_panic_msg using proc_dobool(), as Joel
> >suggested.
> >> > > > Zero disables recording, nonzero integers enable it, and reads
> >return
> >> > > > 0 or 1.
> >> > > > 
> >> > > > Register the sysctl only after the logger is ready. A registration
> >failure
> >> > > > leaves the internal default in force. Document that the log is
> >sent
> >> > > > before kdump, and that disable_panic_notifiers_platform_list also
> >skips
> >> > > > it.
> >> > > > 
> >> > > > Link:
> >https://lore.kernel.org/r/4e73yd2ofpdzl6rptzvd74no3hnyfblknoq7wzxlw7f3zjbz7c@srfabx6lsusj
> >> > > > Signed-off-by: Zack Rusin <zack.rusin@broadcom.com>
> >> > > 
> >> > > Sashiko has reviewed this patch and found no issues.
> >> > 
> >> > It might be better to turn off this message if not issues found, just
> >> > like what LKP bot has been doing.
> >> 
> >> (+sashiko@lists.linux.dev)
> >> 
> >> Yes please.
> >> 
> >> These emails do have a little bit of value: they tell you that Sashiko
> >> was able to apply the patch and to review it.  I guess.  Or something.
> >
> >In that case a message saying Sashiko can't apply the entire patchset
> >is better.
> 
> yes my sashiko emails go to spam automatically (not cuz I set it, but 
> cuz I get so much "no issues!" Emails, that it clogs up my inbox. 
> 
> What even is the need to have the no issues emails? If one was THAT
> interested in sashiko, they could search for it?

Yeah, searching for it is one good way. Not sure if it's convenient for
people like Andrew and Mike who need pick patch. They may need check
patchset one by one if Sashiko can't apply patch while keep silent. And
some patch authors could be new, they could mistake sashiko being silent
as no issue. I did that before until Andrew told me in a private message.

If there's a document telling people where and how to search, that's
also good.

> 
> >
> >> 
> >> Me:
> >> 
> >> :0 D:
> >> * ^From:[ 	]*sashiko-bot@kernel\.org[ 	]*$
> >> * B ?? ^Sashiko has reviewed this patch and found no issues\.$
> >> /home/akpm/.nsmail-zip/Trash
> >> 
> >> hp2:/home/akpm> grep "From:.*sashiko-bot" .nsmail-zip/Trash | wc -l
> >> 1140
> >> hp2:/home/akpm> 
> >> 
> 
> --- Thanks!


  reply	other threads:[~2026-11-18  8:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  6:01 [PATCH v4 0/4] panic, x86/vmware: Preserve crash logs before kdump Zack Rusin
2026-11-18  6:01 ` [PATCH v4 1/4] panic: Add a platform panic notifier list Zack Rusin
2026-11-18  6:16   ` sashiko-bot
2026-11-18  6:01 ` [PATCH v4 2/4] x86/vmware: Add a bounded panic log sender Zack Rusin
2026-11-18  6:18   ` sashiko-bot
2026-11-18  6:01 ` [PATCH v4 3/4] x86/vmware: Add the vmware_record_panic_msg sysctl Zack Rusin
2026-11-18  6:14   ` sashiko-bot
2026-11-18  6:42     ` Baoquan He
2026-11-18  7:02       ` Andrew Morton
2026-11-18  7:51         ` Baoquan He
2026-11-18  7:53           ` Bradley Morgan
2026-11-18  8:09             ` Baoquan He [this message]
2026-11-18  6:01 ` [PATCH v4 4/4] x86/vmware: Report guest crashes after kmsg dumpers Zack Rusin
2026-11-18  6:12   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av1dP8iq13h-t5P6@MiWiFi-R3L-srv \
    --to=baoquan.he@linux.dev \
    --cc=ajay.kaher@broadcom.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexey.makhalov@broadcom.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bo.gan@broadcom.com \
    --cc=bp@alien8.de \
    --cc=bradley.morgan@linux.dev \
    --cc=brennan.lamoreaux@broadcom.com \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=eperezma@redhat.com \
    --cc=hpa@zytor.com \
    --cc=ian.forbes@broadcom.com \
    --cc=joel.granados@kernel.org \
    --cc=john.ogness@linutronix.de \
    --cc=kees@kernel.org \
    --cc=kexec@lists.infradead.org \
    --cc=maaz.mombasawala@broadcom.com \
    --cc=mhklinux@outlook.com \
    --cc=mingo@redhat.com \
    --cc=mst@redhat.com \
    --cc=pasha.tatashin@soleen.com \
    --cc=pmladek@suse.com \
    --cc=pratyush@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=rppt@kernel.org \
    --cc=ruirui.yang@linux.dev \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sashiko@lists.linux.dev \
    --cc=senozhatsky@chromium.org \
    --cc=skhan@linuxfoundation.org \
    --cc=stephen.s.brennan@oracle.com \
    --cc=tglx@kernel.org \
    --cc=virtualization@lists.linux.dev \
    --cc=x86@kernel.org \
    --cc=zack.rusin@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox