From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2365C606A329 for ; Tue, 17 Nov 2026 10:21:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=kUqwUNc5; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=D4vzbT3s DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=UXZ+gJIG1gP+CKxMaNvlafcmbL7c2harfJRX7gxsgMw=; b=kUqwUNc5Ml6tkBk9afXAYgXuM3 TyAn/y69OCeXLj+TGMe7bCHKPTHjPXLavqiBVBTLyTSPT3HoefHl0iXpgw8ns3/yiqManL2HAWpsL mo52w0/ncQdzFPw+Y0w+EO83AeTyFqCS6gxULtUDfFCAM6xeCnh1dO26AFj0plbeKYh8a/ZAetEpv p6yGshN7kn5X7yvgXiKRkRXpZzZnkr20cb2xNYrRUpmoB0R1mgNT5+aJABoCl/GlPTxDUXqZjxj4u Y6ORg9bch1s78cQqxlFTiELYx48lUyuHGNvTsw8OuQKk8MUmH0uFF4BWhI/7dCc70rlBqzc0Y1KvK YpZwsyaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTGJj-00000005Ffh-1jvh; Tue, 17 Nov 2026 10:21:35 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTGJi-00000005FfU-0szk; Tue, 17 Nov 2026 10:21:34 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 43A6562D00; Tue, 17 Nov 2026 10:21:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E50EE1F000C7; Tue, 17 Nov 2026 10:21:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794910893; bh=UXZ+gJIG1gP+CKxMaNvlafcmbL7c2harfJRX7gxsgMw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=D4vzbT3sw6LKGRN1Fg0eToodi7N2R3UHzlrzyKZcneYi5J/U0DmDi89zjIaNP7pyS o26kzC7X/Z7O6vkZCrPxe6Y2s1wjY/PAqZDwbbMBnRCtUl8eMqa0urT7Loya0Rn0lo z1KLoBuF19/bJ9Vgm/5uGC9cPGVtz4KGniyfFwyzW3XwRCzRDA39L2lWGYcWbUVUVo 0Y1WxFNqDlcvdOEk8AKLlIiP2HaIqPWGjnokZeRZgiYWbhCf+xAPAX6JGK7cyWH8vY ljTYNlayqp0pdAmVEPtObScMCePJssRfTggh1ZV9DHp5hInv8hoKtVIBfM41sJ7YA+ j/OEM5rAPdiDQ== Date: Tue, 17 Nov 2026 10:21:18 +0000 From: "Lorenzo Stoakes (ARM)" To: Jeff Xu Cc: Andrew Morton , David Hildenbrand , Vlastimil Babka , Johannes Weiner , Andrey Ryabinin , "Liam R . Howlett" , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Zi Yan , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , Boris Brezillon , Catalin Marinas , Chia-I Wu , Dev Jain , Evgenii Stepanov , Ian Rickards , Jann Horn , Jeff Vander Stoep , Jeff Xu , Kees Cook , Mark Rutland , Peter Collingbourne , =?utf-8?Q?Pierre-Cl=C3=A9ment?= Tosi , Ryan Roberts , Tomasz Figa , Will Deacon , Alexander Viro , Christian Brauner , Jan Kara , Miklos Szeredi , Baoquan He , Pasha Tatashin , Pratyush Yadav , Allison Henderson , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , linux-mm@kvack.org, kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, fuse-devel@lists.linux.dev, kexec@lists.infradead.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 5/7] mm: kasan: skip KASAN for GFP_HIGHUSER Message-ID: References: <20261116230627.3537051-1-jeffxu@chromium.org> <20261116230627.3537051-6-jeffxu@chromium.org> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261116230627.3537051-6-jeffxu@chromium.org> X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Mon, Nov 16, 2026 at 03:06:25PM -0800, Jeff Xu wrote: > Move __GFP_SKIP_KASAN from GFP_HIGHUSER_MOVABLE to GFP_HIGHUSER so that > both GFP_HIGHUSER and GFP_HIGHUSER_MOVABLE allocations skip KASAN > unpoisoning on allocation and poisoning on free in HW_TAGS mode. > > Previously, commit c275c5c6d50a ("kasan: disable freed user page > poisoning with HW tags"), commit 70c248aca9e7 ("mm: kasan: Skip > unpoisoning of user pages"), and commit 0a54864f8dfb ("kasan: remove > PG_skip_kasan_poison flag") added __GFP_SKIP_KASAN to > GFP_HIGHUSER_MOVABLE because user pages are not intended to be used as > directly addressable kernel data structures, and the lower likelihood of > catching a kernel linear-map bug on user payload pages does not justify > tagging all 256 16-byte MTE granules per 4 KB page on every allocation > and free. > > GFP_HIGHUSER shares the same kernel-accessibility contract in > include/linux/gfp_types.h ("for userspace allocations that may be mapped > to userspace, do not need to be directly accessible by the kernel but > that cannot move once in use"). The only semantic difference between > GFP_HIGHUSER and GFP_HIGHUSER_MOVABLE is __GFP_MOVABLE. > > For every 4 KB page without __GFP_SKIP_KASAN under CONFIG_KASAN_HW_TAGS, > mte_set_mem_tag_range() tags all 256 16-byte MTE granules (via STG/STZG > and DC GVA/GZVA) on allocation (__kasan_unpoison_pages) and again on > free (__kasan_poison_pages). For users of GFP_HIGHUSER, this can > significantly impact performance when allocating and freeing large > buffers. For example, in graphics and interactive UI workloads, large > DMA-BUF and DRM/GPU buffers are allocated with GFP_HIGHUSER: while > steady-state rendering reuses swapchain buffers, UI window resizes, > surface creation/teardown, and app or scene launches synchronously > allocate and release tens to hundreds of megabytes of DMA-BUF > framebuffers (~32 MB per 4K RGBA frame, or ~96 MB for a triple-buffered > surface) and GPU shmem pools directly on UI, compositor, and render > threads. Touching millions of 16-byte granules stalls these critical > threads for milliseconds per buffer, a significant share of the 8.3 ms > (120 Hz) / 16.7 ms (60 Hz) frame budget, while polluting CPU L1/L2 data > and MTE tag caches, evicting hot working-set cachelines, and saturating > DRAM bandwidth (especially on free when DMA pages are cold in the CPU > cache). > > GFP_HIGHUSER is used by subsystems such as the DMA-BUF system heap, DRM > GEM shmem/TTM and non-movable HugeTLB. They use it instead of > GFP_HIGHUSER_MOVABLE only because their pages are pinned for DMA or > cannot migrate. > > What skipping KASAN means for the kernel's own accesses to these pages: > > - Through vmap(): nothing changes. With CONFIG_KASAN_HW_TAGS those > pointers already carry the match-all tag, so the page tags never > protected these accesses. > - Through kmap_local_page() or page_address() (for example ramfs): > post_alloc_hook() now gives the pages the match-all tag, so these > accesses are no longer checked. GFP_HIGHUSER_MOVABLE pages already > behave this way. Callers that want to keep the checks use > GFP_HIGHUSER_KASAN: the previous patches in this series converted > pipe, FUSE, kexec and RDS, and backports of this patch should > include them. > > Slab allocations cannot use GFP_HIGHUSER, because they do not accept > __GFP_HIGHMEM. GFP_KERNEL, GFP_USER and vmalloc() allocations are not > affected. > > This patch does not address the false-positive KASAN report after shmem > swap-in readahead with MTE that was reported on drm/panthor [1, 2]. > There, swap_cluster_readahead() allocates swap-cache folios for > neighboring swap slots with the gfp mask of the shmem mapping being > swapped in. If such a slot holds a page that userspace maps with > PROT_MTE, the folio keeps a KASAN tag in page->flags that does not > match the userspace tags restored by arch_swap_restore(). > > This patch only removes one way to hit it: shmem mappings that use > GFP_HIGHUSER (such as drm_gem_shmem_helper or panthor) now pass > __GFP_SKIP_KASAN to readahead, so the neighboring folios no longer get > a KASAN tag. The readahead path itself is unchanged, and shmem mappings > with other gfp masks that lack __GFP_SKIP_KASAN can still trigger the > report. That issue should be followed up separately, for example in > [1]. > > On an Armv9.2-A device running a 6.12-based kernel with kasan.mode=sync, > this reduces the allocation + release time of a ~32 MB buffer from > /dev/dma_heap/system by ~80%: allocation is ~59% faster and release ~98% > faster. Poisoning on free accounted for ~55% of the total before. In an > application loading benchmark, the OpenGL score improves by 15-23%, > recovering 60-80% of the regression that enabling MTE causes. > This commit message is just inscrutable. It's like reading Finnegan's Wake :) LLMs are obscenely terrible at this stuff unfortunately. You seem to have rewritten commit messages for the other patches, could you do the same for this one? Thanks. > Link: https://lore.kernel.org/r/20260519-panthor-kasan-v2-1-b7384458f076@gmail.com/ [1] > Link: https://lore.kernel.org/r/20260521105148.5497c281@fedora/ [2] > Assisted-by: LLM This tag isn't used any longer! Thanks for acking LLM usage though, we prefer you disclose it but in the commit message or the cover letter etc. > Signed-off-by: Jeff Xu > --- > include/linux/gfp_types.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/gfp_types.h b/include/linux/gfp_types.h > index 567c93fc1cfb..bcc4827deb4c 100644 > --- a/include/linux/gfp_types.h > +++ b/include/linux/gfp_types.h > @@ -386,9 +386,9 @@ enum { > #define GFP_USER (__GFP_RECLAIM | __GFP_IO | __GFP_FS | __GFP_HARDWALL) > #define GFP_DMA __GFP_DMA > #define GFP_DMA32 __GFP_DMA32 > -#define GFP_HIGHUSER (GFP_USER | __GFP_HIGHMEM) > +#define GFP_HIGHUSER (GFP_USER | __GFP_HIGHMEM | __GFP_SKIP_KASAN) > #define GFP_HIGHUSER_KASAN (GFP_USER | __GFP_HIGHMEM) > -#define GFP_HIGHUSER_MOVABLE (GFP_HIGHUSER | __GFP_MOVABLE | __GFP_SKIP_KASAN) > +#define GFP_HIGHUSER_MOVABLE (GFP_HIGHUSER | __GFP_MOVABLE) > #define GFP_TRANSHUGE_LIGHT ((GFP_HIGHUSER_MOVABLE | __GFP_COMP | \ > __GFP_NOMEMALLOC | __GFP_NOWARN) & ~__GFP_RECLAIM) > #define GFP_TRANSHUGE (GFP_TRANSHUGE_LIGHT | __GFP_DIRECT_RECLAIM) > -- > 2.56.0.611.g1030f0b940-goog > -- Cheers, Lorenzo