Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: yingelin <yingelin@huawei.com>
To: kexec@lists.infradead.org
Subject: [PATCH sysctl-next] kernel/kexec_core: move kexec_core sysctls into its own file
Date: Mon, 28 Feb 2022 09:43:49 +0800	[thread overview]
Message-ID: <b07af605-ab74-a313-f8e4-da794dcde111@huawei.com> (raw)
In-Reply-To: <YhqLnIjopfoBEBcV@bombadil.infradead.org>


? 2022/2/27 4:20, Luis Chamberlain ??:
> On Thu, Feb 24, 2022 at 10:35:21AM +0800, Baoquan He wrote:
>> That seems to be an issue everything related to sysctl are all added to
>> kernel/sysctl.c. Do you have a pointer that someone complained about it
>> and people agree to scatter them into their own component code?
> https://lkml.kernel.org/r/20220226031054.47DF8C340E7 at smtp.kernel.org
>
>> I understand your concern now, I am personally not confused by that
>> maybe because I haven't got stuff adding or changing into sysctls. My
>> concern is if we only care and move kexec knob, or we have plan to try
>> to move all of them. If there's some background information or
>> discussion with a link, that would be helpful.
> We're moving them all out. Sorry, yingelin's commit log message sucks
> and it needs to be fixed to account for the justification. All the
> filesystem sysctls are already moved out. Slowly we are moving the other
> ones out and also doing minor optimizations along the way.
I'm sorry I didn't express it clearly. I'll fix it in v2 patch.
>
>    Luis
> .


  reply	other threads:[~2022-02-28  1:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-23  3:03 [PATCH sysctl-next] kernel/kexec_core: move kexec_core sysctls into its own file yingelin
2022-02-23  8:30 ` Baoquan He
2022-02-24  1:04   ` yingelin
2022-02-24  2:35     ` Baoquan He
2022-02-26 20:20       ` Luis Chamberlain
2022-02-28  1:43         ` yingelin [this message]
2022-02-28  3:18           ` Baoquan He
2022-04-15 22:59             ` Luis Chamberlain
2022-02-28  1:41       ` yingelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b07af605-ab74-a313-f8e4-da794dcde111@huawei.com \
    --to=yingelin@huawei.com \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox