From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from us-smtp-1.mimecast.com ([207.211.31.81] helo=us-smtp-delivery-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ikBjF-0006xG-Qt for kexec@lists.infradead.org; Wed, 25 Dec 2019 18:49:55 +0000 Received: by mail-pj1-f70.google.com with SMTP id n89so3987279pji.6 for ; Wed, 25 Dec 2019 10:49:47 -0800 (PST) Subject: Re: [RESEND PATCH v5 5/5] Documentation/vmcoreinfo: Add documentation for 'TCR_EL1.T1SZ' References: <1575057559-25496-1-git-send-email-bhsharma@redhat.com> <1575057559-25496-6-git-send-email-bhsharma@redhat.com> <8a982138-f1fa-34e8-18fd-49a79cea3652@arm.com> From: Bhupesh Sharma Message-ID: Date: Thu, 26 Dec 2019 00:19:35 +0530 MIME-Version: 1.0 In-Reply-To: <8a982138-f1fa-34e8-18fd-49a79cea3652@arm.com> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: James Morse , linux-kernel@vger.kernel.org Cc: Mark Rutland , Ard Biesheuvel , linux-doc@vger.kernel.org, Will Deacon , x86@kernel.org, kexec@lists.infradead.org, Kazuhito Hagio , Dave Anderson , Catalin Marinas , bhupesh.linux@gmail.com, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Steve Capper Hi James, On 12/12/2019 04:02 PM, James Morse wrote: > Hi Bhupesh, I am sorry this review mail skipped my attention due to holidays and focus on other urgent issues. > On 29/11/2019 19:59, Bhupesh Sharma wrote: >> Add documentation for TCR_EL1.T1SZ variable being added to >> vmcoreinfo. >> >> It indicates the size offset of the memory region addressed by TTBR1_EL1 > >> and hence can be used for determining the vabits_actual value. > > used for determining random-internal-kernel-variable, that might not exist tomorrow. > > Could you describe how this is useful/necessary if a debugger wants to walk the page > tables from the core file? I think this is a better argument. > > Wouldn't the documentation be better as part of the patch that adds the export? > (... unless these have to go via different trees? ..) Ok, will fix the same in v6 version. >> diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump/vmcoreinfo.rst >> index 447b64314f56..f9349f9d3345 100644 >> --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst >> +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst >> @@ -398,6 +398,12 @@ KERNELOFFSET >> The kernel randomization offset. Used to compute the page offset. If >> KASLR is disabled, this value is zero. >> >> +TCR_EL1.T1SZ >> +------------ >> + >> +Indicates the size offset of the memory region addressed by TTBR1_EL1 > >> +and hence can be used for determining the vabits_actual value. > > 'vabits_actual' may not exist when the next person comes to read this documentation (its > going to rot really quickly). > > I think the first half of this text is enough to say what this is for. You should include > words to the effect that its the hardware value that goes with swapper_pg_dir. You may > want to point readers to the arm-arm for more details on what the value means. Ok, got it. Fixed this in v6, which should be on its way shortly. Thanks, Bhupesh _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec