From: lijiang <lijiang@redhat.com>
To: Dave Young <dyoung@redhat.com>
Cc: horms@verge.net.au, kexec@lists.infradead.org
Subject: Re: [PATCH] kdump: fix an error that can not parse the e820 reserved region
Date: Thu, 6 Sep 2018 13:20:49 +0800 [thread overview]
Message-ID: <baa1671b-aff0-0fbf-1a04-ecbec8f6f2f5@redhat.com> (raw)
In-Reply-To: <20180906023009.GA12218@dhcp-128-65.nay.redhat.com>
在 2018年09月06日 10:30, Dave Young 写道:
> Hi Lianbo,
>
> On 09/05/18 at 09:41pm, Lianbo Jiang wrote:
>> When kexec-tools load the kernel and initramfs for kdump, kexec-tools will
>> read /proc/iomem and recreate the e820 ranges for kdump kernel. But it fails
>> to parse the e820 reserved region, because the memcmp() is case sensitive
>> when comparing the string. In fact, it may be "Reserved" or "reserved" in
>> the /proc/iomem, so we use the strncasecmp() instead of the memcmp() to fix
>> it.
>>
>> Signed-off-by: Lianbo Jiang <lijiang@redhat.com>
>> ---
>> kexec/arch/i386/crashdump-x86.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kexec/arch/i386/crashdump-x86.c b/kexec/arch/i386/crashdump-x86.c
>> index 437e8a8..6669c1a 100644
>> --- a/kexec/arch/i386/crashdump-x86.c
>> +++ b/kexec/arch/i386/crashdump-x86.c
>> @@ -287,7 +287,7 @@ static int get_crash_memory_ranges(struct memory_range **range, int *ranges,
>> type = RANGE_PRAM;
>> } else if(memcmp(str,"Persistent Memory\n",18) == 0 ) {
>> type = RANGE_PMEM;
>> - } else if(memcmp(str,"reserved\n",9) == 0 ) {
>> + } else if(strncasecmp(str,"reserved\n",9) == 0 ) {
>> type = RANGE_RESERVED;
>
> It would be better to use two memcmp in two "else if" for "reserved" and "Reserved"
>
Ok, i will post v2 again later.
Thanks.
> BTW, add one whitespace before the function arguments.
>
>> } else if (memcmp(str, "GART\n", 5) == 0) {
>> gart_start = start;
>> --
>> 2.17.1
>>
>>
>> _______________________________________________
>> kexec mailing list
>> kexec@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/kexec
>
> Thanks
> Dave
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2018-09-06 5:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 13:41 [PATCH] kdump: fix an error that can not parse the e820 reserved region Lianbo Jiang
2018-09-06 2:30 ` Dave Young
2018-09-06 5:20 ` lijiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baa1671b-aff0-0fbf-1a04-ecbec8f6f2f5@redhat.com \
--to=lijiang@redhat.com \
--cc=dyoung@redhat.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox