From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD9F1C46CD8 for ; Fri, 22 Dec 2023 11:38:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ej8h/F7QuCnKe4h7+vzbJFwQUV9v6ZQPCBwkeiOB3U8=; b=wFNTdFzcKxA+Os DT9LPn+5DdTDg7nqr2doFF461NIRi0b+7o+jzx/PaRXDMCppAhTaaQQE/Y0z79aDiB30ER1EYHewg Yq7PlWBvKpULbNuX6KZZL25EX2VTVKNwHt+Ho2i7g1ZIdnVz7ajqQyApl2Ukn5iWuh/4LOfpH8pLt QaWKAhSdbxdsOnYkoQ6lLrnIxEKLQLCy8sZFzL9UoisnxN7dMoBJgUzNVf9Qi/cS/9AxrAII0v9cM NWIp0797EHBz215d2NpsocSFcLWLOJwAZUB1gr6bpbUYxGvIG7dSS2oHGnTM2o56Iy0LYlbxggo7l xanXQgOo30FVXC7hw7xw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rGdrI-005iX6-1r; Fri, 22 Dec 2023 11:38:28 +0000 Received: from mgamail.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rGdrG-005iSa-0s for kexec@lists.infradead.org; Fri, 22 Dec 2023 11:38:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703245106; x=1734781106; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=KsrO1+cO3lvwJOJSUN3IvbHK+rcuE7NjoZRmTpOr16w=; b=Gg5x5u0v/c9T4eX+HO2eLLTP8/pvZBKgJK52Y5kgELNvtnTi0i51wYSS TyJCacREbw+GxhA2uxg4vxhtkgFw1VvGpV1uJYHzLWJA6vY35kBY0C3L5 hySwKkMflVO9TAPU5SY2m8K8w7vNlW8NTNES5qV3sXxFPtbA8TDVAbGbG Y3NHqOYCr71vsdsV3C8sp7bYFueuJ3G5ALK+RFZPK4mnY+T0A1wVphXW+ C/3fRHG/gTGUxAOW3cNqs2uRgAIyVQM+kSCAYsIVyjIi7hwJyvqMZWMUE tw4lvXjhDc2KxT2EKb9IsuZnsxxettXExiAY7PZ4f95JimuILM4e+Fcbn Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10931"; a="427265720" X-IronPort-AV: E=Sophos;i="6.04,296,1695711600"; d="scan'208";a="427265720" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2023 03:38:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10931"; a="867615182" X-IronPort-AV: E=Sophos;i="6.04,296,1695711600"; d="scan'208";a="867615182" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Dec 2023 03:38:18 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 22 Dec 2023 03:38:17 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 22 Dec 2023 03:38:17 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 22 Dec 2023 03:38:17 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 22 Dec 2023 03:38:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QL9m7lsO4f3/3lsvs3YqS9G0i6DA6pAjIBcw0rTMnaRkIiwgTgruKPFl1EA90HMWkX0g4YL3hhUWX+F4+HUpOt1R4bPnqtoKm4iBC0uHqFUgpvw8xwq+TC7ayxp/8cCfeWpoy9PcuOsiKEiUPmHWxx4sGETeK/uBLEUhOYu36BM9gDwvaitPm4PO6srrPastLpw3O6+Uwx/n5NAgAyDU5rqkK9W355Pl14zV4UES9igsUau90okkmaUsTaznhM4ceDLF5yV+nfNAwZd+MudraaiUo7eS7WJSAw/qUy6rXoy6GvG9dz5mSCDnkKcm0PP5es1QJyh5y8MzLSY26Vsw1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KsrO1+cO3lvwJOJSUN3IvbHK+rcuE7NjoZRmTpOr16w=; b=hLAE/lq1YOdS31vCYKLgk3Y/bF1B5TtNkaVKfeUecWEdL814i05F8/HsPFKnj3/NRK/mRfyJ/BmgR5m3fuZcTd1iSFC9PPoAWHYbdQh36V+1QIbZ3nHIX4mIUcJdLrYh5t8PLNXO1UR/gQUhapsPnCE0cP3Z5utJzE5+0I+wTsQ0azmwF/cTLsmZPA2yK+9zL0bcjLA0qN4PNnG401VMmmyJCAvBfepxovltasq7aDgHhf67nsNpjwDpD/dXCSvZsMrJnIiak+vD+Ch0rqJYLboLLJG22c+VHNsN3fP/wSIQODkqofBBiiOrFs4lOalF4bEALDdeh7KlwCory/hdBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BL1PR11MB5978.namprd11.prod.outlook.com (2603:10b6:208:385::18) by LV8PR11MB8509.namprd11.prod.outlook.com (2603:10b6:408:1e6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.21; Fri, 22 Dec 2023 11:38:15 +0000 Received: from BL1PR11MB5978.namprd11.prod.outlook.com ([fe80::5d1:aa22:7c98:f3c6]) by BL1PR11MB5978.namprd11.prod.outlook.com ([fe80::5d1:aa22:7c98:f3c6%7]) with mapi id 15.20.7113.019; Fri, 22 Dec 2023 11:38:15 +0000 From: "Huang, Kai" To: "kirill.shutemov@linux.intel.com" CC: "kexec@lists.infradead.org" , "linux-coco@lists.linux.dev" , "ashish.kalra@amd.com" , "dave.hansen@linux.intel.com" , "thomas.lendacky@amd.com" , "Hunter, Adrian" , "Reshetova, Elena" , "linux-kernel@vger.kernel.org" , "mingo@redhat.com" , "seanjc@google.com" , "tglx@linutronix.de" , "bhe@redhat.com" , "Nakajima, Jun" , "peterz@infradead.org" , "bp@alien8.de" , "Edgecombe, Rick P" , "rafael@kernel.org" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "x86@kernel.org" Subject: Re: [PATCHv4 14/14] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method Thread-Topic: [PATCHv4 14/14] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method Thread-Index: AQHaJxRg2LJJnT2of0eK3PTgcDCh0LCbWa0AgBnpsoCAAAUoAA== Date: Fri, 22 Dec 2023 11:38:14 +0000 Message-ID: References: <20231205004510.27164-1-kirill.shutemov@linux.intel.com> <20231205004510.27164-15-kirill.shutemov@linux.intel.com> <3a080962fea97efbb8e102c1de34bc766d7a53b6.camel@intel.com> <20231222111945.mqzacijpqnzbgxbp@box> In-Reply-To: <20231222111945.mqzacijpqnzbgxbp@box> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.50.2 (3.50.2-1.fc39) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL1PR11MB5978:EE_|LV8PR11MB8509:EE_ x-ms-office365-filtering-correlation-id: 41cf3d83-af3c-4b50-3157-08dc02e27c40 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2AHjFAXojN3p6rs8EFw5ugdrZimwFpH09Lw8uqwHAAlOodtpyYR27EBogF41p5mWVD2X5Zx8xXfMt7Zwd9boPxvD6+aIFE8Uyfhm3KomSlTmlzQ228A8aHBcME9bqQ4hzt2hSTWSyhBQqJESxnNgqKiYe1eriZvJDUlGucCnXL5rL4V5uPrjmwsp195fdOmfIPYfQiwUkSZSprIHOmk0IsuZ/vjDUILN/d5chUugRHUkyMto34ej3d7833Yf5mnP27aQk+8bAM10RlP1JHH5N5G75PphH2SleaHugqU06CN4cgJ2qFRHggzrrcM/yobTD581kr6cfpC3U3FIygJGvJ8dWxRTENdjT2epS9b0LeamQab6NEhyZXCUZcbgOs+4iykET/BG4w01McvdVSvHNKMsQi9aH1XAQn2M6nEgXkfiZowPEMQ8rzOp7JtFmHb1AljNRMZUZLhiwbM+LuFONFRfsUoe593qBv9hMosFgdrKDA+If9XY3SCL88tHxns+/EaHOncY14lbCmbmTKFOfJbhIP2edDZ4DIPFeOF6lXDOy+e1SI08h1ATfrs71/9PeB9L2uRqo1bhnfbb8RF3lzg2wuoXOFgrxLrs/CDqRPkPfSkQp9Dk8iWBuEWuqhch x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR11MB5978.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(396003)(39860400002)(136003)(346002)(376002)(230922051799003)(64100799003)(451199024)(1800799012)(186009)(4326008)(8676002)(8936002)(122000001)(66446008)(66556008)(66476007)(91956017)(66946007)(76116006)(64756008)(54906003)(6916009)(316002)(4744005)(82960400001)(7416002)(4001150100001)(2906002)(41300700001)(86362001)(36756003)(38070700009)(38100700002)(5660300002)(2616005)(26005)(83380400001)(6486002)(478600001)(6506007)(6512007)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Y1h6LzRUYlF2SXhZSFo3Q2s4QU5lV0hXRk5DUjRsS3ZPazEvQWNFYnRlRnBR?= =?utf-8?B?YW53QWNNVno2MDVYV1pDbUIyd2ZsMVhtRmRkOUVINkxjRURGRnB2NkozMFhG?= =?utf-8?B?bkhQRmU2NFYzakRCdFZiSzZGOWdUTm53TU9IYzV1bWlKMVRPK1ZpbzBnaktB?= =?utf-8?B?VXA3NDQvUGFIODBXM1h3enh0ejJpTWJPZ2hPUkJQODE2YXl3cCtYS3JkU0h5?= =?utf-8?B?ZTQ2bGh0M0d4cVhleW90SXdxaHlVNUZqSFpxcTJqV29yZnFyR0QwWSt1ZkZt?= =?utf-8?B?aFpvdVViTHRkKzZIQ3h1SlhlNGJNR25MTjlFaVBjMEl0UHhSYWVJSnhUNW1k?= =?utf-8?B?WTdrWFRGdDgrWjI3T3ZCWDFveVlURG9ReHpBMlFhUW5meGFXRkJtQTkzN3Uw?= =?utf-8?B?cjZMb2pEczRTQTBNYlI5akpGb0daRmRPMGt4RVY5RndEdm1OSjIrQnBQSVNq?= =?utf-8?B?ZjNkZFA3dWNLMU5tSVlkb3o4dFk2STVld2MrUEhqczh6OFF0bW1pYUo1cDE4?= =?utf-8?B?RXB0T20xTi8yS1NoK25TRWltdHJtZWI5aVVpUkk2VUJsU1RGQmd5NkRJQU92?= =?utf-8?B?bnlXOUZkRTlEc0graHZRZStJZkRDUVNHd3RiWFppdjIrcFlpdXFNWmgyelpS?= =?utf-8?B?OHlOYkxYUUpjMTZXb2E1bG50OWhLTDUzNHk3cjU4WHFOY3IySGJ2SjVqNmpP?= =?utf-8?B?Q0EySno0bnBUWTh0akVyVWVxYnNqMkV1QzFJNVhYY01Vb0VYTmlmRVlqRm1M?= =?utf-8?B?NUpOaVNFdXdtUEI5dExSTEl2S0RWcXIrcjZDSXRHZHBmRnVFa21wT01vQ3JW?= =?utf-8?B?WW50UXVjK1VPSFh4d1ZrMmdpcmJnYkZGNTk4MXMveVZzK05tQVJvajJvUkdT?= =?utf-8?B?bVlNaktxZ1dneVRFSURsTExHczRSWlZkRXZTRWUyUXlpaVFPL3YwNnkwWm1E?= =?utf-8?B?V1FadTFkZW95bUlWVkNOSE1RWXBSNy94NEZSWXdGZmtieCsvZ0hOMVc1d2xK?= =?utf-8?B?UHcvUzlJOGZZSlhxWjQ5RmFUa3UvQWpibTBXeFgvRnZXTDFuQ0h0VE1LWHhE?= =?utf-8?B?WXZ2SktmUkhGNTJKZGhTaTd1ZXREZUlMQW1RTWR2MmdrRW1EZndHbUYwSlpK?= =?utf-8?B?UlFRSk9UdGF0TVV5aGNUcGRJbi81OVpJSWNhMWMxYkJaOGg4c0FZMlJGbjRr?= =?utf-8?B?aWorWDZuYVpSeUd3ajhNbk5ncC9xVmgvaThwY2ZQN0JaaUN2MGdXMDFJSlRt?= =?utf-8?B?TmIwcm92QVlkSUlZZ2F6VUpQQnlCdzY4L1ZwbUVPZEgzU2xNa0ZiUDF5S2ph?= =?utf-8?B?RC9keHQxc2hKU3liUmNFLzh3SmF5SEVGQTlXYStsNjlIQk11RVZsVGU2ZVBM?= =?utf-8?B?bmxQMzQvS0lTeDFLT0VYMGZNYmJXOU1WNWpHc3E5ZzNObS9ydW5EaXNQd2Vq?= =?utf-8?B?aHZjQUNMRkx3WUdaNTlLWmdUcVBPc3ppVnc5WTdOSTVUT3BvMzZFV3o3STZ1?= =?utf-8?B?SXhmcXBrT1NEWkVhcXFIWkptYjlzSUp0WGtUY2VhMnU5MnB2ZWs5NlQxY1d0?= =?utf-8?B?M3FoT3loTHpobXhUSGlMRGFGUUZrc21KRTlRMUNNSHpaZ3hEcGtKUUZlazFZ?= =?utf-8?B?OW96UFMwTW9wYVZXcG1Zc1VnTlF0Y00wV1JZZ0NyMDRTaDd4Wm5FQWFRbnF4?= =?utf-8?B?MWJNUlJoM0UzbWZ1VFBBcUJWcHhvVEtkZWR4Mi9CWmdaL1ZsVnNyTDRDRVhH?= =?utf-8?B?TXI0OGR5eUtMWm40L0ZKNFJmeUJ5MFlQWTYvNVNLaDl1Sm1IaVF3OGJFWE56?= =?utf-8?B?VzV0UTRxQWpQTlJMaE44czJnTG12c2w4S1E5eHlCQS93c3paNWdWRUdYbGE4?= =?utf-8?B?VjZZQm53cFBwQmlWRkR6UzdvZTBVY3FxT0Y0c0djVEIxTm00V1lHOHhxVllH?= =?utf-8?B?emZjOVd1SHNNNDFQdVBacUZmYjFGUTQrWjV5bHhrMG9yQW5BSzVvVEdFenVD?= =?utf-8?B?V0FTSS9pMktLbkxER04yM2M3VnNkK0lGRXdaZmRmUlc2WmFCRU9lQTJCNHNK?= =?utf-8?B?Y0FKT1AvOW1NakIxd0RVdXM5ZG9hS0RDQ1dmNEVvaTVHSGo0MGxBNTUzb0t0?= =?utf-8?B?THRtNkhSV3RqbysxMlV0M3FSeUhub1R6bkxHUVdndGpRODIwd0c5UzlIdi9D?= =?utf-8?B?Ync9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41cf3d83-af3c-4b50-3157-08dc02e27c40 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Dec 2023 11:38:14.9906 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: l6SQJTdJ/VR5H93iorsMgXLu3cI5qSgxTSyIxz3r62cCHSwIDBBM9hnq53oRb84xL1ARZdq+mqdsikXZfjWg8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8509 X-OriginatorOrg: intel.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231222_033826_327635_AD4939B4 X-CRM114-Status: GOOD ( 18.73 ) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org On Fri, 2023-12-22 at 14:19 +0300, kirill.shutemov@linux.intel.com wrote: > On Tue, Dec 05, 2023 at 11:36:55PM +0000, Huang, Kai wrote: > > > > > + > > > +static void acpi_mp_stop_other_cpus(int wait) > > > +{ > > > + smp_shutdown_nonboot_cpus(smp_processor_id()); > > > +} > > > > Is this and ... > > > > + smp_ops.stop_other_cpus = acpi_mp_stop_other_cpus; > > > > ... this below still needed? > > > > I think the current native_stop_other_cpus() should just work given you have set > > up ... > > > > + smp_ops.crash_play_dead = crash_acpi_mp_play_dead; > > > > ... for TDX guest? > > To make it work stop_this_cpu() would need to be modified to use > smp_ops.crash_play_dead() instead of native_halt(). But name of the > callback doesn't match the function, so I renamed it to > smp_ops.stop_this_cpu(). Seems reasonable to me. Thanks. _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec