From: Julien Thierry <jthierry@redhat.com>
To: lijiang <lijiang@redhat.com>,
"HAGIO KAZUHITO(萩尾 一仁)" <k-hagio-ab@nec.com>,
"Bhupesh Sharma" <bhsharma@redhat.com>
Cc: kexec mailing list <kexec@lists.infradead.org>
Subject: Re: [MAKDUMPFILE PATCH] Add option to estimate the size of vmcore dump files
Date: Wed, 18 Nov 2020 07:33:17 +0000 [thread overview]
Message-ID: <c065d8b2-68dc-8a1f-fe68-7b8882ec28f9@redhat.com> (raw)
In-Reply-To: <f0c14722-1563-de64-433d-33ea0429a332@redhat.com>
Hi,
On 11/18/20 3:57 AM, lijiang wrote:
> Hi, Kazu, Julien and Bhupesh
>
> 在 2020年10月28日 16:32, HAGIO KAZUHITO(萩尾 一仁) 写道:
>> I'm rethinking about what command options makedumpfile should have.
>> If once we add an option to makedumpfile, we cannot change it easily,
>> so I'd like to think carefully.
>>
>> The calculated size might be useful if it's printed so that it can be
>> easily post-processed by scripts, e.g. for automated tests. If so,
>> makedumpfile already prints its statistics with "--message-level 16",
>> and it might be useful to also print them by an option like "--show-stats".
>>
>> # makedumpfile --show-stats -l -d 31 vmcore dump.ld31
>> total_pages xxx
>> excluded_pages yyy
>> ...
>> write_bytes zzz
>>
>> Also, if we also have "--dry-run" option to not write actually, it's
>> explicit and meets Bhupesh's use case. What do you think?
>>
>
> It seems that adding a statistical option could be better than nothing.
>
> Do you have any decisions on this issue? Or any thoughts?
>
On my end this makes sense, I'll try to add the --dry-run and
--show-stats options as Kazu suggested and post a new version.
--
Julien Thierry
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2020-11-18 7:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 7:09 [MAKDUMPFILE PATCH] Add option to estimate the size of vmcore dump files Julien Thierry
2020-10-13 9:27 ` Bhupesh Sharma
2020-10-13 9:53 ` Julien Thierry
2020-10-13 19:45 ` Bhupesh Sharma
2020-10-16 6:45 ` HAGIO KAZUHITO(萩尾 一仁)
2020-10-20 11:36 ` Julien Thierry
2020-10-28 8:32 ` HAGIO KAZUHITO(萩尾 一仁)
2020-10-29 12:43 ` lijiang
2020-10-30 6:29 ` HAGIO KAZUHITO(萩尾 一仁)
2020-11-02 8:07 ` lijiang
2020-11-18 3:57 ` lijiang
2020-11-18 7:33 ` Julien Thierry [this message]
2020-10-14 4:31 ` lijiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c065d8b2-68dc-8a1f-fe68-7b8882ec28f9@redhat.com \
--to=jthierry@redhat.com \
--cc=bhsharma@redhat.com \
--cc=k-hagio-ab@nec.com \
--cc=kexec@lists.infradead.org \
--cc=lijiang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox