Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sgoel@codeaurora.org
To: Pratyush Anand <panand@redhat.com>
Cc: Timur Tabi <timur@codeaurora.org>,
	Azriel Samson <asamson@codeaurora.org>,
	kexec@lists.infradead.org, sgoel@codeaurora.org,
	virajm@codeaurora.org, ats-kumagai@wm.jp.nec.com
Subject: Re: [PATCH] makedumpfile: Support ARM64
Date: Wed, 19 Aug 2015 23:16:07 -0000	[thread overview]
Message-ID: <d0d13b96c02d5b54afcda30723667dab.squirrel@www.codeaurora.org> (raw)
In-Reply-To: <c0ce0a0ea4482e9fca97b5c811f4693b.squirrel@www.codeaurora.org>

Hi Pratyush,

I made the following changes to the code:

KVBASE was being mapped to page_offset, so the mem_map that I saw using
the kmem command in crash did not seem to audit with the data generated by
make dumpfile. I changed this to vmalloc_start.

After making the above change the mem_map was getting generated fine. But
still I am always failing in:
================================
ptea = pte_offset(&pmdv, vaddr);
		/* 64k page */
		if (!readmem(VADDR, (unsigned long long)ptea, &ptev, sizeof(ptev))) {
			ERRMSG("Can't read pte\n");
			return NOT_PADDR;
		}
=================================


The KERN_STRUCT_PAGE_SIZE evaluates to 56 and not 64. I changed the
required value and the arch info is now valid.

I am still failing in the page translation. I will highly appreciate any
help with this.

Thanks,
Sameer

> Adding Sameer as he has a few questions on kvbase.
>
>> Hi Pratyush,
>>
>> I was able to run makedumpfile with "-d 31" but the dumpfile was
>> approximately the same size as that of vmcore (~16GB).
>>
>> Answers inline.
>>
>>> Hi Azriel,
>>>
>>> On 01/07/2015:06:42:46 PM, Azriel Samson wrote:
>>>> Hi Pratyush,
>>>>
>>>> I am working with Timur and we are testing your version of
>>>> makedumpfile.
>>>
>>> Thanks for testing.
>>>
>>>> The tool is unable to get the kernel version and quits from
>>>> check_release().
>>>
>>> Couple of questions:
>>>
>>> 1. Can you please let me know VA_BITS configured in your case?
>> VA_BITS=39
>>> 2. Do you expect any regions other than vmalloc, vmemmap or modules,
>>> which are not directly mapped and their physical address need to be
>>> found from swapper_pg_dir?
>> No
>>> In my vmcore, I did not had any address where
>>> is_vtop_from_page_table_arm64 would be true. So, vtop_arm64 function
>>> has been only cross checked logically. So,
>>> a) Please put a print in vtop_arm64 and check if control goes there?
>>> b) if yes, then please print vaddr and paddr at the end of vtop_arm64
>>> and see if that is correct. If not we need to debug vtop_arm64.
>> I still need to try this. Will get back when I do.
>>> ~Pratyush
>>>
>>>>
>>>> I tried to debug the vmcore file with gdb but the file looks corrupt.
>>>>
>>>> Let me know if you have any ideas on what could be wrong?
>>>>
>>>> > Hi Timur,
>>>> >
>>>> > On 23/06/2015:10:36:03 PM, Timur Tabi wrote:
>>>> >> Pratyush Anand wrote:
>>>> >> >I can try to find out some time in weekend to refactor arm64 code
>>>> >> >and then add 3 level, 4K support. May be I will need a Tested-by.
>>>> >>
>>>> >> We'd be more than happy to test any code from you promptly.  We're
>>>> eager
>>>> >> to
>>>> >> get this to work.
>>>> >
>>>> > I have done the changes, hopefully it should work, but have not
>>>> > tested. Let me know, if it works will send them as formal patches
>>>> > to upstream.
>>>> >
>>>> > https://github.com/pratyushanand/makedumpfile.git : arm64_support
>>>> > (9b95423bcea0)
>>>> >
>>>> > ~Pratyush
>>>> >
>>>>
>>>> --
>>>> Thanks,
>>>> Azriel Samson
>>>> Qualcomm Innovation Center, Inc.
>>>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>>>> Forum, 
>>>> a Linux Foundation Collaborative Project
>>>
>>
>>
>> --
>> Thanks,
>> Azriel Samson
>> Qualcomm Innovation Center, Inc.
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum, 
>> a Linux Foundation Collaborative Project
>>
>
>
> --
> Thanks,
> Azriel Samson
> Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
> Forum, 
> a Linux Foundation Collaborative Project
>
>



_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2015-08-19 23:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-15 18:30 [PATCH] makedumpfile: Support ARM64 Pratyush Anand
2015-05-19  7:26 ` Atsushi Kumagai
2015-06-23 23:19 ` Timur Tabi
2015-06-24  3:32   ` Pratyush Anand
2015-06-24  3:36     ` Timur Tabi
2015-06-27  8:22       ` Pratyush Anand
2015-07-01 18:42         ` Azriel Samson
2015-07-03  4:32           ` Pratyush Anand
2015-07-08 23:03             ` Azriel Samson
2015-08-18 17:18               ` Azriel Samson
2015-08-19 23:16                 ` sgoel [this message]
2015-08-20 11:21                   ` Pratyush Anand
2015-08-20 16:11                     ` sgoel
2015-08-21  3:44                       ` Pratyush Anand
2015-08-21  7:25                         ` Atsushi Kumagai
2015-08-21 20:37                         ` sgoel
2015-08-22  3:54                           ` Pratyush Anand
2015-08-24 18:17                             ` sgoel
2015-08-25  0:21                               ` sgoel
2015-09-08 22:32                                 ` sgoel
2015-09-11 16:52                                   ` Pratyush Anand
2015-09-14 16:02                                     ` sgoel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0d13b96c02d5b54afcda30723667dab.squirrel@www.codeaurora.org \
    --to=sgoel@codeaurora.org \
    --cc=asamson@codeaurora.org \
    --cc=ats-kumagai@wm.jp.nec.com \
    --cc=kexec@lists.infradead.org \
    --cc=panand@redhat.com \
    --cc=timur@codeaurora.org \
    --cc=virajm@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox