From: Pratyush Anand <panand@redhat.com>
To: Atsushi Kumagai <ats-kumagai@wm.jp.nec.com>
Cc: "kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"dyoung@redhat.com" <dyoung@redhat.com>,
"bhe@redhat.com" <bhe@redhat.com>
Subject: Re: [Makedumpfile Patch 0/6] Fix --mem-usage /proc/kcore
Date: Mon, 13 Feb 2017 13:04:16 +0530 [thread overview]
Message-ID: <db956357-414f-0efc-10b8-7864b88f5e00@redhat.com> (raw)
In-Reply-To: <0910DD04CBD6DE4193FCF86B9C00BE9701EA4B89@BPXM01GP.gisp.nec.co.jp>
On Monday 13 February 2017 11:56 AM, Atsushi Kumagai wrote:
> Hello Pratyush,
>
>> `makedumpfile --mem-usage /proc/kcore` has been broken after kaslr specific
>> modifications. I have proposed a kernel patch [0] which has been ACKed by
>> Andrew Morton and is available in next-2017020 now. Hopefully, it should be
>> part of upstream in v4.10 release. This kernel patch helps to fix this
>> issue for both the case of kaslr enabled and disabled.
>>
>> To seek other's feedback, I am sending makedumpfile patches before kernel
>> patch hits upstream.
>
> Thanks for taking care of this feature.
> I understand that the problem is:
>
> - phys_base is necessary for VtoP, but:
> - SYMBOL(phys_base) is unavailable since /proc/kcore doesn't export VMCOREINFO.
> - get_phys_base() doesn't work well since current PT_LOAD doesn't have valid p_paddr.
Yes, this is what the problem is.
>
> The new makedumpfile with this patches can show unexpected behavior since it
> will refer to invalid p_paddr(always 0). Of course, also current makedumpfile cannot
> work if phys_base isn't 0.
>
> If we don't have any way to get phys_base in 1st kernel environment,
> I think we should disable this feature in older kernel (e.g. by checking kernel version).
Hummm..I had thought that distros with old kernel will backport kernel
patch and then can use this feature. If we disable it for older kernel,
then they will not be able to do it.
would it be fine if I cc kernel patch to stable mailing list? It seems
that patch can be easily applied all older kernel.
~Pratyush
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2017-02-13 7:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 12:01 [Makedumpfile Patch 0/6] Fix --mem-usage /proc/kcore Pratyush Anand
2017-02-06 12:01 ` [Makedumpfile Patch 1/6] show_mem_usage(): calculate page offset after elf load Pratyush Anand
2017-02-06 12:01 ` [Makedumpfile Patch 2/6] initial(): call cach_init() a bit early Pratyush Anand
2017-02-06 12:01 ` [Makedumpfile Patch 3/6] x86_64: check physical address in PT_LOAD for none direct mapped regions Pratyush Anand
2017-02-06 12:01 ` [Makedumpfile Patch 4/6] elf_info: kcore: check for invalid physical address Pratyush Anand
2017-02-06 12:01 ` [Makedumpfile Patch 5/6] makedumpfile: Correct the calculation of kvaddr in set_kcore_vmcoreinfo Pratyush Anand
2017-02-06 12:01 ` [Makedumpfile Patch 6/6] makedumpfile: Discard process_dump_load Pratyush Anand
2017-02-13 6:26 ` [Makedumpfile Patch 0/6] Fix --mem-usage /proc/kcore Atsushi Kumagai
2017-02-13 7:34 ` Pratyush Anand [this message]
2017-02-13 8:28 ` Atsushi Kumagai
2017-02-14 4:43 ` Pratyush Anand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db956357-414f-0efc-10b8-7864b88f5e00@redhat.com \
--to=panand@redhat.com \
--cc=ats-kumagai@wm.jp.nec.com \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox