From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFC3AC43458 for ; Tue, 30 Jun 2026 12:00:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rQJzhkIkVPlkRxcrVSAS1/qxSmuU/Saa7J0AIvXGGuk=; b=I/XCOteUtaE3smZgJtMW7i4jTK Eqmn3UwZDG717UqbQ2o0BvDMfHvL689zf5i94MhvMfQRi6/0bzxAbfABhdaiK1ldjPwHk/nMlu7Pz W6TIFzMtdW7nmXLxqa5My2bnoBF6ofP41J/RX2kdANYBIC5QXRxadNqMnk5L5pDISx4I7PQ8l/9iH 7ItlSFmkjAPfKD6T39jZtJd8nalg1mUw4tK25BsOHiFnMPKQWRsGPE5qZbCSTYWV/7giMQcKl5A9t Qq0oN2PqC+4CHcQePvB5N5hRMcaga2+fxXrXeE7ee9N2qZ2BMf7k6k27+N5IHZYcXI5LfGxc1rCYM j24cE4yA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1weX8g-0000000GuNR-3y0B; Tue, 30 Jun 2026 12:00:30 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1weX8e-0000000GuM9-39Qs for kexec@lists.infradead.org; Tue, 30 Jun 2026 12:00:30 +0000 Received: by mail-pf1-x441.google.com with SMTP id d2e1a72fcca58-847921eed4aso1407337b3a.3 for ; Tue, 30 Jun 2026 05:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782820828; x=1783425628; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rQJzhkIkVPlkRxcrVSAS1/qxSmuU/Saa7J0AIvXGGuk=; b=Bj1LapwFxR1TnBUo1E/O03bWfzspCNxY6Mt+kzdR+2iqoaGgAw7gpWY9ohvuX/WpWb sLINU/rHbLcPYExwXfTyNjfGTIfsSf+QJW+Sbt35OG+deLWBdIkcMrN4i+MnHHMtocCo 00APTfl/IUJ2T0YVejBoSpZMDXra1FcNK2/ec+lqewx/L6StAULqdaoXFG7icoby130v 24DxUzqpBwZ9s+rBw6JUSrd5Ge2WxmdXt2OAVXmOsRnkNwFmKIbTkY6aM5Aou41iTvBJ zA/q4ncMKkDoxfu47Rda8F9Q9QOMl5yAB2d7uVvkBg1v2qCHbVizLhHzTRIRNAx35dPb lw9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782820828; x=1783425628; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rQJzhkIkVPlkRxcrVSAS1/qxSmuU/Saa7J0AIvXGGuk=; b=j5hkBqehcxsfVD0aPyw3/RHXSnV6UoZEnNCpg/oF9U+ffKaRyUMlPTLi+mAkMN17Zj B9u9ipmyTX/l3neUTgsxcJw5hnr4/gOaWs2PVF+pH9jlltIf1ONux9u4sww6VwSi0M3d ArRvOhtJ7Y9J+hOnaST1xyY8usAWETiFvo77Cg7pDd43FReDdVVxFLdZXjoA16FIPrhn +JK1VzQAHXMsnKKjDNJP3CqzU6GTYmBzWDbok0CT6DYFEXicpmME43dIosGCuKEVe/Ct z0RUmTW2PFitZXUwpAufRTM8rztLxKxv/mUbQt4Xml7ppZMAaTFbzERjEVsZUmwKTwna OmQA== X-Forwarded-Encrypted: i=1; AHgh+Rph2eb0dCJvWvkKhswiQOlxE6r4CRUvDDrbnMrZ+BT4QMjFaYoxTAWxMM7FVpB+GfFxaeSKoQ==@lists.infradead.org X-Gm-Message-State: AOJu0YwHaAxnEEA54wG+Xg32gjc+bVvmsFsqwFidCYhNCxpN0R9NAXjr LFzrin9fKoP8iY5ds1FUbAXkBDWciszdA8gfMCaoMTjnweVg2ilWPEz0 X-Gm-Gg: AfdE7ckvDIjR/EXv0Qxq8qQav/9A9OezX81yFYztjhZ4glHrcEAu9q37omRe/OV3HeS HZS8kdAbKM3Fc35tUePtt4U03/dbb0m0HsNbgvivElKlMLxXwBzN76np/GzCMtrnurLklkUzJLF /bW3LiQiWqLBiyLgq+Gh0vw8k2kZmYllQeRxhVOXaXyUnkoRdzmvwuKu/mk9p9o0QG8gHP+xpK+ 9Vzn6Jj5hn8RBnFzmUUQ+TwAGc1N17NUGm1tYrRTioEn3WzfGSzXmhzJOMiT8DQRhecYzmy2XXF WY6DSEczfyTj8vsSvZ/0KUHXZaN8OxIa2FHZJMRcBRjZs38MTgb+xQSomoBikqdoJYEQZ49pDDC fX8Aix3i2mmkXHObVpLUw7qEBiILt3upZiH7ab/OV8T1oW/BRvwebL1M+d0x7G3cBNrkgV7CCgl cps9eyANdlqZ2oWD6TeDNE X-Received: by 2002:a05:6a00:1ca1:b0:847:902a:57b5 with SMTP id d2e1a72fcca58-8479f2175cbmr2758259b3a.35.1782820827394; Tue, 30 Jun 2026 05:00:27 -0700 (PDT) Received: from [10.125.112.20] ([210.184.73.204]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847a02cd39asm1834294b3a.34.2026.06.30.05.00.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 05:00:26 -0700 (PDT) Message-ID: Date: Tue, 30 Jun 2026 20:00:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 09/10] riscv: kdump: exclude non-dumpable reserved memory regions from vmcore To: Pratyush Yadav Cc: chenhuacai@kernel.org, kernel@xen0n.name, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, robh@kernel.org, saravanak@kernel.org, bhe@redhat.com, rppt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, kexec@lists.infradead.org, iommu@lists.linux.dev, zhaomeijing@lixiang.com, catalin.marinas@arm.com, will@kernel.org, alex@ghiti.fr, akpm@linux-foundation.org, pasha.tatashin@soleen.com, ruirui.yang@linux.dev, m.szyprowski@samsung.com, robin.murphy@arm.com References: <20260630074715.4126796-1-chenwandun1@gmail.com> <20260630074715.4126796-10-chenwandun1@gmail.com> <2vxzechoi8o0.fsf@kernel.org> Content-Language: en-US From: Wandun In-Reply-To: <2vxzechoi8o0.fsf@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260630_050028_786676_68EB8885 X-CRM114-Status: GOOD ( 16.13 ) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org On 6/30/26 19:12, Pratyush Yadav wrote: > On Tue, Jun 30 2026, Wandun Chen wrote: > >> From: Wandun Chen >> >> Apply the same non-dumpable reserved memory filtering to RISC-V kdump >> as was done for arm64. Use of_reserved_mem_kdump_exclude() to drop >> flagged regions from the elfcorehdr PT_LOAD segments, and >> of_reserved_mem_kdump_nr_ranges() to pre-size the crash_mem array. >> >> Signed-off-by: Wandun Chen >> --- >> arch/riscv/kernel/machine_kexec_file.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/riscv/kernel/machine_kexec_file.c b/arch/riscv/kernel/machine_kexec_file.c >> index 59d4bbc848a8..25359d583bc3 100644 >> --- a/arch/riscv/kernel/machine_kexec_file.c >> +++ b/arch/riscv/kernel/machine_kexec_file.c >> @@ -10,6 +10,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -64,6 +65,7 @@ static int prepare_elf_headers(void **addr, unsigned long *sz) >> >> nr_ranges = 1; /* For exclusion of crashkernel region */ >> walk_system_ram_res(0, -1, &nr_ranges, get_nr_ram_ranges_callback); >> + nr_ranges += of_reserved_mem_kdump_nr_ranges(); >> >> cmem = kmalloc_flex(*cmem, ranges, nr_ranges); >> if (!cmem) >> @@ -77,6 +79,8 @@ static int prepare_elf_headers(void **addr, unsigned long *sz) >> >> /* Exclude crashkernel region */ >> ret = crash_exclude_mem_range(cmem, crashk_res.start, crashk_res.end); >> + if (!ret) >> + ret = of_reserved_mem_kdump_exclude(cmem); >> if (!ret) >> ret = crash_prepare_elf64_headers(cmem, true, addr, sz); > > Nit: can you do the usual pattern of if (err) goto err; instead? > Sure, will fix in the next version. Best regards, Wandun > So this would look like: > > /* Exclude crashkernel region */ > ret = crash_exclude_mem_range(cmem, crashk_res.start, crashk_res.end); > if (ret) > goto out; > > ret = of_reserved_mem_kdump_exclude(cmem); > if (ret) > goto out; > > ret = crash_prepare_elf64_headers(cmem, true, addr, sz); > out: > ... > > With this, > > Acked-by: Pratyush Yadav >