From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from eu-smtp-delivery-151.mimecast.com ([185.58.85.151]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgTQG-009fod-14 for kexec@lists.infradead.org; Tue, 11 May 2021 14:31:45 +0000 From: David Laight Subject: RE: [PATCH v6 00/13] Add build ID to stacktraces Date: Tue, 11 May 2021 14:31:38 +0000 Message-ID: References: <20210511003845.2429846-1-swboyd@chromium.org> <20210511085235.09bc38a7@gandalf.local.home> <37ca7834a8514a5695ed002e073a83b6@AcuMS.aculab.com> In-Reply-To: MIME-Version: 1.0 Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: 'Petr Mladek' Cc: 'Steven Rostedt' , 'Stephen Boyd' , Andrew Morton , "linux-kernel@vger.kernel.org" , Alexei Starovoitov , Andy Shevchenko , Baoquan He , Borislav Petkov , Catalin Marinas , Dave Young , Evan Green , Hsin-Yi Wang , Ingo Molnar , Jessica Yu , Jiri Olsa , "kexec@lists.infradead.org" , Konstantin Khlebnikov , "linux-arm-kernel@lists.infradead.org" , "linux-doc@vger.kernel.org" , Matthew Wilcox , Rasmus Villemoes , Sasha Levin , Sergey Senozhatsky , Thomas Gleixner , Vivek Goyal , Will Deacon , "x86@kernel.org" , Christoph Hellwig , peter enderborg From: Petr Mladek > Sent: 11 May 2021 15:22 > > On Tue 2021-05-11 12:58:47, David Laight wrote: > > From: Steven Rostedt > > > Sent: 11 May 2021 13:53 > > > > > > On Tue, 11 May 2021 12:36:06 +0000 > > > David Laight wrote: > > > > > > > > x1 : ffffff93fef15788 x0 : ffffffe3622352e0 > > > > > Call trace: > > > > > lkdtm_WARNING+0x28/0x30 [lkdtm ed5019fdf5e53be37cb1ba7899292d7e143b259e] > > > > > direct_entry+0x16c/0x1b4 [lkdtm ed5019fdf5e53be37cb1ba7899292d7e143b259e] > > > > > full_proxy_write+0x74/0xa4 > > > > > > > > Is there any way to get it to print each module ID only once? > > > > > > If there's a trivial way to do that, then perhaps it should be done, but for > > > now, this patch series isn't as obnoxious as the previous versions. It only > > > affects stack traces, and I'm fine with that. > > > > True. Printing the id in the module list was horrid. > > > > The real downside is all the extra text that will overflow the > > in-kernel buffer. > > At least it shouldn't be extra lines causing screen wrap. > > Unless the variable names are long - hi rust :-) > > Note that the ID is printed only when CONFIG_STACKTRACE_BUILD_ID > is enabled. It will be used only by some distros/vendors that > use it to download the debuginfo packages. Until Ubuntu decide to turn it on :-) Actually, for the use case, the id could be trimmed significantly. It is only trying to differentiate between builds of a specific module. So even 8 digits would be plenty. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec