From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EDAFC5B552 for ; Fri, 30 May 2025 09:51:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wfAmhiX8GmCFAxokpsMnfWBjFSdezrVGBamjGu0rQl4=; b=FnixRV30ItcstTWMs6eZDAH8m+ D4vv9+HEiuoz8G4ITkiLEraOl4bN4oIh/Mo4BwyKm7UVnjD0rTnkkpmfLt97Kya33ddJz0XFFr+nt liVfKnxs030hw5ItAxhlcmSS3MLcVPYD2fGh9LCK+Y+sCzACeaeZ/gJv743R6GFtQOsqPzeORIOsH QivZ48Kwi4EU/MfBQ5UmJEMlkTPHAX7EIQOn7Mg3VEaIeqczvXrr3TRi2MbSvPL5b13og2GBZ8e+s 22wywzQu3VbtyOq152YaGWaU35h19FOzWx8ehZ7psRnvXyi4iGIVN4t3LOzvenzoqMjRnAwRacebx orZHk8wQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uKwOK-00000000DQ0-00by; Fri, 30 May 2025 09:51:08 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uKwLA-00000000Cwd-0ODP for kexec@lists.infradead.org; Fri, 30 May 2025 09:47:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748598470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wfAmhiX8GmCFAxokpsMnfWBjFSdezrVGBamjGu0rQl4=; b=Mait1I2W4FXd0sGpuCRen1m7f9JuDYopgfU4Z7nCm4/++f1qRZsAUNFeHf8U7AJ6mHkkJZ VquUHJ0MMb1g9Bx4/j5Ip9sd5EzYIHm0L8rGXatYnOW08tW9yah9oiCll7NPu4DrlZPnRu arEuoMTgJ3OzgjgfFk/nJRkcx2tVZS4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-133-FoKtV1anMU6earZmH9KMkQ-1; Fri, 30 May 2025 05:47:49 -0400 X-MC-Unique: FoKtV1anMU6earZmH9KMkQ-1 X-Mimecast-MFC-AGG-ID: FoKtV1anMU6earZmH9KMkQ_1748598468 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43eea5a5d80so10780565e9.1 for ; Fri, 30 May 2025 02:47:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748598468; x=1749203268; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=wfAmhiX8GmCFAxokpsMnfWBjFSdezrVGBamjGu0rQl4=; b=Jx7/3UHktAU1nHIaQ+XkAa7+TjQ4YNVFuu4z04Rgi+KIdjyYeuHyOIN+qzjaKasHer E3E1vTnCniIepKKpCmN3H5pYvHqaYCVlrXpyfIsKDtzQkp6V5Ws4q0eMeBYVoIeeP+nW MAD1dvstkPyRF1GTcCIXklyJCYb4O387Q31LFPSTHT7cCUyXp6H1UjCMVM7fOOfg9ZlL 5zbaOml6A2tkNrD5gIIglfSnpMm/9oYa7zHqmd23LRCyoZgha41qKVwvhp7EjRntOvFn Z5j+yw3R7ZHYvZmcrQ6eRXBsslN9HISgcdE6T/KcRQCKYNcwXDprfd1f5J2SmAVNFkNi Kbpw== X-Forwarded-Encrypted: i=1; AJvYcCXfZXo4d/4SwVw0an2tKCltspWZQ7evIcxP0bgDlpFe+HCv4Vh10hzNPRedDHoLTXKEKV2kcA==@lists.infradead.org X-Gm-Message-State: AOJu0YyYeHYdE7pKg7zLcUKmJVFXkGcyJHyKH8LibRKw5zC7DMQSMvbl 3zT2GQ3+ecIEr7J7SmG6JrP5dZi/YzA15rSgd6wWx3jfLqfSjTGkk+R5t9/adKRcy4UOOYv+HY2 mjWo+wgyjE+iya29sTcrFl1wbWL6OGrpIwDRDp43P2zZV1zn75W1WoJQJxV/tce2DYdVmsX+8 X-Gm-Gg: ASbGnctVOxUDCy88KzMb9n+1NEUryxW4qrG9QDciE68CAdUK5YOPLeYuhPAw+aLLGcw 6GWaLPKZW2Nx6FtuLONgpmX5Y7nDdadRzi/zvz59IybxQL40c4B225ZzfGuEPkg2PdGrZNZA142 vd4E4eRcsb63xNhq62pNgJrsIKR7X6Pz4CwYLOj1QpZKOTZMYPNjzFWwMACXBHsfIzGdng6ZIdC Gvt0wKszY+CtMwDb4epone8lTVSsQr0gTDsiH1SuKj/At8NR0r4kh4Cx28bg6YBAwPYPEfUx6Ks LyDO4Pi8BdCSOD7o9KfRmUU6oTn9jp9PLHeseE3qgsxSXmvNFerCK/a3QnNsf9KdMLJ8oBG7nvT YH4AtLYJtaM8Tg/MAHkF9IZ2VH6lTdwTvsrt36Ko= X-Received: by 2002:a05:600c:6207:b0:445:49e:796b with SMTP id 5b1f17b1804b1-450d886f1f3mr14894755e9.17.1748598468246; Fri, 30 May 2025 02:47:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHwHV3a7pm41ph3Tdq1BY1w51HsiBJlc3eQX7poOec+XB3vOA8eRZ2EJbez4lGCHx+/2UqnnA== X-Received: by 2002:a05:600c:6207:b0:445:49e:796b with SMTP id 5b1f17b1804b1-450d886f1f3mr14894395e9.17.1748598467820; Fri, 30 May 2025 02:47:47 -0700 (PDT) Received: from ?IPV6:2003:d8:2f03:5b00:f549:a879:b2d3:73ee? (p200300d82f035b00f549a879b2d373ee.dip0.t-ipconnect.de. [2003:d8:2f03:5b00:f549:a879:b2d3:73ee]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4f00a00f5sm4376727f8f.95.2025.05.30.02.47.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 May 2025 02:47:47 -0700 (PDT) Message-ID: Date: Fri, 30 May 2025 11:47:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/5] kdump: crashkernel reservation from CMA To: Jiri Bohac Cc: Michal Hocko , Baoquan He , Donald Dutile , Vivek Goyal , Dave Young , kexec@lists.infradead.org, Philipp Rudo , Pingfan Liu , Tao Liu , linux-kernel@vger.kernel.org, David Hildenbrand References: <04904e86-5b5f-4aa1-a120-428dac119189@redhat.com> <427fec88-2a74-471e-aeb6-a108ca8c4336@redhat.com> <04a49de5-eb79-431b-ba5b-eae2536781c6@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Jz2ndjurXE2dA4KfmawJEpm4H9bZx8IxsPd7GldHAxo_1748598468 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250530_024752_215125_4BACAEA2 X-CRM114-Status: GOOD ( 21.93 ) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org On 30.05.25 11:34, Jiri Bohac wrote: > On Fri, May 30, 2025 at 11:11:40AM +0200, David Hildenbrand wrote: >> On 30.05.25 11:07, Michal Hocko wrote: >>> On Fri 30-05-25 10:39:39, David Hildenbrand wrote: >>>> On 30.05.25 10:28, Michal Hocko wrote: >>> [...] >>>>> All that being said I would go with an additional parameter to the >>>>> kdump cma setup - e.g. cma_sane_dma that would skip waiting and use 10s >>>>> otherwise. That would make the optimized behavior opt in, we do not need >>>>> to support all sorts of timeouts and also learn if this is not >>>>> sufficient. >>>>> >>>>> Makes sense? >>>> >>>> Just so I understand correctly, you mean extending the "crashkernel=" option >>>> with a boolean parameter? If set, e.g., wait 1s, otherwise magic number 10? >>> >>> crashkernel=1G,cma,cma_sane_dma # no wait on transition >> >> But is no wait ok? I mean, any O_DIRECT with any device would at least take >> a bit, no? >> >> Of course, there is a short time between the crash and actually triggerying >> kdump. >> >>> crashkernel=1G,cma # wait on transition with e.g. 10s timeout >> >> In general, would work for me. > > I don't like extending the crashkernel= syntax like this. > It would make hooking into the generic parsing code in > parse_crashkernel() really ugly. The syntax is already > convoluted as is and hard enough to explain in the documentation. Would another boolean flag (on top of the other one you are adding) really make this significantly more ugly? > > Also I don't see how adding a boolean knob is better than adding > one that allows setting any arbitrary timeout. It has less > flexibility and all the drawbacks of having an extra knob. I guess Michals point is that specifying the higher-level problem and giving less flexibility mioght actually be less confusing for users. > > I am inclined to just setting the fixed delay to 10s for now and > adding a sysfs knob later if someone asks for it. > > Would that work for you? Sure. We could always add such a flag later if it's really a problem for someone. -- Cheers, David / dhildenb